From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#25552: 26.0.50; load cl unintendedly Date: Thu, 02 Feb 2017 18:05:55 -0800 Message-ID: <29437.1486087555@alto> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Trace: blaine.gmane.org 1486087573 11647 195.159.176.226 (3 Feb 2017 02:06:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Feb 2017 02:06:13 +0000 (UTC) Cc: yamaoka@jpl.org To: npostavs@users.sourceforge.net, 25552@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 03 03:06:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZTGK-0002qd-Nv for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Feb 2017 03:06:08 +0100 Original-Received: from localhost ([::1]:59813 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZTGQ-0006nY-C2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Feb 2017 21:06:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZTGI-0006m2-Bk for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2017 21:06:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZTGE-0002br-Bi for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2017 21:06:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56131) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZTGE-0002bl-8d for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2017 21:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cZTGD-0004wM-NX; Thu, 02 Feb 2017 21:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, mh-e-devel@lists.sourceforge.net Resent-Date: Fri, 03 Feb 2017 02:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25552 X-GNU-PR-Package: emacs,mh-e X-GNU-PR-Keywords: X-Debbugs-Original-To: npostavs@users.sourceforge.net, mh-e-devel@lists.sourceforge.net X-Debbugs-Original-Cc: Glenn Morris , Katsumi Yamaoka , 25552@debbugs.gnu.org Original-Received: via spool by 25552-submit@debbugs.gnu.org id=B25552.148608756018983 (code B ref 25552); Fri, 03 Feb 2017 02:06:01 +0000 Original-Received: (at 25552) by debbugs.gnu.org; 3 Feb 2017 02:06:00 +0000 Original-Received: from localhost ([127.0.0.1]:54329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZTGB-0004w6-W5 for submit@debbugs.gnu.org; Thu, 02 Feb 2017 21:06:00 -0500 Original-Received: from shell1.rawbw.com ([198.144.192.42]:50832 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZTGA-0004vx-JF for 25552@debbugs.gnu.org; Thu, 02 Feb 2017 21:05:59 -0500 Original-Received: from alto (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id v1325tO4006605; Thu, 2 Feb 2017 18:05:55 -0800 (PST) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be alto In-Reply-To: Noam's message of "Wed, 01 Feb 2017 08:51:05 -0500." <87vasuow8m.fsf@users.sourceforge.net> X-Mailer: MH-E 8.6+git; nmh 1.6; GNU Emacs 26.0.50 Content-ID: <29436.1486087555.1@alto> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128899 Archived-At: npostavs@users.sourceforge.net wrote: > Mike Kupfer writes: > > > Hi Katsumi and Glenn, I applied Glenn's patch to 25.1.90, and I'm afraid > > that it introduced a failure. [...] > I guess it's because defun-mh checks whether the alias target is fbound > at compile time: > > (defmacro defun-mh (name function arg-list &rest body) > "Create function NAME. > If FUNCTION exists, then NAME becomes an alias for FUNCTION. > Otherwise, create function NAME with ARG-LIST and BODY." > (let ((defined-p (fboundp function))) > (if defined-p > `(defalias ',name ',function) > `(defun ,name ,arg-list ,@body)))) > > It would be better to check at runtime: > > (defmacro defun-mh (name function arg-list &rest body) > `(if (fboundp ',function) > (defalias ',name ',function) > (defun ,name ,arg-list ,@body))) > > And/or require `mail-abbrev' at compile time > > --- i/lisp/mh-e/mh-compat.el > +++ w/lisp/mh-e/mh-compat.el > @@ -260,7 +260,7 @@ 'mh-line-end-position > 'line-end-position > 'point-at-eol)) > > -(mh-require 'mailabbrev nil t) > +(eval-and-compile (mh-require 'mailabbrev nil t)) > (defun-mh mh-mail-abbrev-make-syntax-table > mail-abbrev-make-syntax-table () > "Emacs 21 and XEmacs don't have `mail-abbrev-make-syntax-table'. Thanks, Noam! I did some light testing of Noam's change to defun-mh plus Glenn's patch. The problem that I reported is gone, and I haven't seen any other issues. I did the testing with both Emacs 25.1.90 and master (7cb7a58). Does anyone on the MH-E dev team have any concerns about this combination of changes? mike