From: Jim Porter <jporterbugs@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>,
Andreas Schwab <schwab@linux-m68k.org>
Cc: 56013@debbugs.gnu.org, Jeff Kowalski <jeff.kowalski@gmail.com>
Subject: bug#56013: 28.1; "gio open" and "xdg-open" fail silently under eshell
Date: Fri, 17 Jun 2022 11:25:58 -0700 [thread overview]
Message-ID: <292942b6-4a7f-0002-2af4-210b32612ba1@gmail.com> (raw)
In-Reply-To: <a388eeea-411a-7834-a104-d8fcb51d33dd@gmail.com>
On 6/17/2022 10:17 AM, Jim Porter wrote:
> On 6/17/2022 4:59 AM, Lars Ingebrigtsen wrote:
>> Andreas Schwab <schwab@linux-m68k.org> writes:
>>
>>> See bug#44824.
>>
>> Ah, right. The fix proposed there was:
>>
>> org.el: Avoid xdg-open silent failure
>> * lisp/org.el (org-open-file): Use 'pipe :connection-type instead of
>> 'pty to prevent killing of background process on handler exit.
>>
>> Perhaps Jim has some comments here; added to the CCs.
>
> Yeah, this is an issue with how `start-file-process' is being called in
> Eshell (see `eshell-gather-process-output'). If I call `(setq
> process-connection-type nil)' before running gio in Eshell, it works fine.
Oh right... I remember looking at a related issue before. Note: I don't
think this will directly fix the issue in this bug, but it might affect
how we do fix this, so I'm mentioning it here.
`eshell-needs-pipe-p' has a link to bug#1388, which discusses why that
function exists in the first place. Basically, if `eshell-needs-pipe-p'
didn't exist, then the following Eshell command wouldn't work right[1]:
~ $ *echo "1+1" | bc
However, the solution isn't quite right if you think about it: while
it's true that bc's stdin should be a pipe, couldn't its stdout still be
a pty? The all-or-nothing nature of "pipe vs pty" seems a bit
over-restrictive. For example, this is (part of) why piping to `less' is
so broken in Eshell. If you remove "less" from `eshell-visual-commands',
you can see some of the issues. The following works ok, though you get
the "dumb terminal" interface for less:
~ $ less file.txt
But this fails:
~ $ cat file.txt | less
Missing filename ("less --help" for help)
I believe that's because `less' sees that stdin is a pty in that case
and so it expects a filename. However, adding `less' to
`eshell-needs-pipe' fails though because then `less' thinks stdout is a
pipe too, so you don't even get the dumb terminal UI; it just forwards
stdin to stdout unchanged.
Fixing this would get rid of the current uses for `eshell-needs-pipe-p',
but then we'd probably want to keep it around in a slightly different
form in order to handle gio/xdg-open properly. What we do about the
issue described above would probably determine how the contents of
`eshell-needs-pipe' should be specified.
[1] The "*" in that command is to use the real /bin/echo, since bc
expects a trailing newline and Eshell's built-in echo doesn't do that.
next prev parent reply other threads:[~2022-06-17 18:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 3:18 bug#56013: 28.1; "gio open" and "xdg-open" fail silently under eshell Jeff Kowalski
2022-06-16 11:58 ` Lars Ingebrigtsen
2022-06-16 14:22 ` Andreas Schwab
2022-06-16 14:32 ` Andreas Schwab
2022-06-17 11:59 ` Lars Ingebrigtsen
2022-06-17 17:17 ` Jim Porter
2022-06-17 18:25 ` Jim Porter [this message]
2022-11-21 5:14 ` Jeff Kowalski
2022-11-22 20:19 ` Jim Porter
2022-11-22 21:00 ` Jeff Kowalski
2022-11-23 22:59 ` Jim Porter
2022-11-24 3:09 ` Jeff Kowalski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=292942b6-4a7f-0002-2af4-210b32612ba1@gmail.com \
--to=jporterbugs@gmail.com \
--cc=56013@debbugs.gnu.org \
--cc=jeff.kowalski@gmail.com \
--cc=larsi@gnus.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).