From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#21650: fix should be underneath MH-E Date: Mon, 01 Feb 2016 10:53:34 -0800 Message-ID: <29197.1454352814@allegro.localdomain> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Trace: ger.gmane.org 1454352864 2278 80.91.229.3 (1 Feb 2016 18:54:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Feb 2016 18:54:24 +0000 (UTC) Cc: Bill Wohler To: 21650@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 01 19:54:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aQJc2-0002M2-8i for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Feb 2016 19:54:10 +0100 Original-Received: from localhost ([::1]:53778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQJc1-0002W7-Ep for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Feb 2016 13:54:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQJbx-0002W0-4a for bug-gnu-emacs@gnu.org; Mon, 01 Feb 2016 13:54:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQJbt-0006Em-Um for bug-gnu-emacs@gnu.org; Mon, 01 Feb 2016 13:54:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQJbt-0006Ei-Qu for bug-gnu-emacs@gnu.org; Mon, 01 Feb 2016 13:54:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aQJbt-0002eV-Ll for bug-gnu-emacs@gnu.org; Mon, 01 Feb 2016 13:54:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Feb 2016 18:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21650 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.145435282910177 (code B ref -1); Mon, 01 Feb 2016 18:54:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Feb 2016 18:53:49 +0000 Original-Received: from localhost ([127.0.0.1]:45459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQJbh-0002e5-6d for submit@debbugs.gnu.org; Mon, 01 Feb 2016 13:53:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57295) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQJbf-0002ds-Ma for submit@debbugs.gnu.org; Mon, 01 Feb 2016 13:53:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQJbZ-00068c-Uo for submit@debbugs.gnu.org; Mon, 01 Feb 2016 13:53:42 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:57466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQJbZ-00068Y-RQ for submit@debbugs.gnu.org; Mon, 01 Feb 2016 13:53:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQJbY-0002Ow-TH for bug-gnu-emacs@gnu.org; Mon, 01 Feb 2016 13:53:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQJbV-00067U-NN for bug-gnu-emacs@gnu.org; Mon, 01 Feb 2016 13:53:40 -0500 Original-Received: from shell1.rawbw.com ([198.144.192.42]:28656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQJbV-00066l-Eh for bug-gnu-emacs@gnu.org; Mon, 01 Feb 2016 13:53:37 -0500 Original-Received: from allegro.localdomain (m208-249.dsl.rawbw.com [198.144.208.249]) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTP id u11IrY5L043665; Mon, 1 Feb 2016 10:53:35 -0800 (PST) (envelope-from m.kupfer@acm.org) X-Authentication-Warning: shell1.rawbw.com: Host m208-249.dsl.rawbw.com [198.144.208.249] claimed to be allegro.localdomain X-Mailer: MH-E 8.6+mdk02; nmh 1.6; GNU Emacs 24.5.2 Content-ID: <29196.1454352814.1@allegro.localdomain> X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112218 Archived-At: After some discussion with Bill Wohler, I've looked more carefully at the problem, paying more attention to the overall system design and layering. MH-E uses the MIME (mm) libraries to render emails. There is a variable mm-inline-text-html-with-image which, according to the documentation, should be sufficient to disable downloading of images. mm-inline-text-html-with-images is a variable defined in `mm-decode.el'. Its value is nil Documentation: If non-nil, Gnus will allow retrieving images in HTML contents with the tags. It has no effect on Emacs/w3. See also the documentation for the `mm-w3m-safe-url-regexp' variable. Unfortunately, shr does not honor mm-inline-text-html-with-images. Instead, it uses #'gnus-blocked-images as its control (see #'mm-shr). MH-E could temporarily rebind gnus-blocked-images before calling #'mm-display-part. But really, that's a hack to work around the fact that the documented mm API doesn't work. For email, it appears that a simple binary control is all that's needed (either fetch remote images or not). So it seems like it would be straightforward for #'mm-shr to use mm-inline-text-html-with-images, and for Gnus to set mm-inline-text-html-with-images as needed. But for newsgroups, it looks like finer control is desired. So I don't know what the fix should look like. But MIME libraries are documented as general-purpose, rather than private to Gnus. So this really ought to be resolved at the mm layer, rather than adding renderer-specific tweaks to MH-E. mike