unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mike Kupfer <m.kupfer@acm.org>
To: 21650@debbugs.gnu.org
Cc: Bill Wohler <wohler@newt.com>
Subject: bug#21650: fix should be underneath MH-E
Date: Mon, 01 Feb 2016 10:53:34 -0800	[thread overview]
Message-ID: <29197.1454352814@allegro.localdomain> (raw)
In-Reply-To: <yxq8u7dz416.fsf@chaos.i-did-not-set--mail-host-address--so-tickle-me>

After some discussion with Bill Wohler, I've looked more carefully at
the problem, paying more attention to the overall system design and
layering.

MH-E uses the MIME (mm) libraries to render emails.  There is a variable
mm-inline-text-html-with-image which, according to the documentation,
should be sufficient to disable downloading of images.

  mm-inline-text-html-with-images is a variable defined in `mm-decode.el'.
  Its value is nil
  
  Documentation:
  If non-nil, Gnus will allow retrieving images in HTML contents with
  the <img> tags.  It has no effect on Emacs/w3.  See also the
  documentation for the `mm-w3m-safe-url-regexp' variable.

Unfortunately, shr does not honor mm-inline-text-html-with-images.
Instead, it uses #'gnus-blocked-images as its control (see #'mm-shr).

MH-E could temporarily rebind gnus-blocked-images before calling
#'mm-display-part.  But really, that's a hack to work around the fact
that the documented mm API doesn't work.

For email, it appears that a simple binary control is all that's needed
(either fetch remote images or not).  So it seems like it would be
straightforward for #'mm-shr to use mm-inline-text-html-with-images, and
for Gnus to set mm-inline-text-html-with-images as needed.

But for newsgroups, it looks like finer control is desired.  So I don't
know what the fix should look like.  But MIME libraries are documented
as general-purpose, rather than private to Gnus.  So this really ought
to be resolved at the mm layer, rather than adding renderer-specific
tweaks to MH-E.

mike





  parent reply	other threads:[~2016-02-01 18:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-08 17:03 bug#21650: 24.5; mh-e keeps trying to open urls Simon Gerraty
2015-10-08 19:20 ` Eli Zaretskii
2015-10-08 20:19   ` Simon J. Gerraty
2015-10-08 21:21     ` Glenn Morris
2015-10-09 15:10       ` Simon J. Gerraty
2015-10-09  7:11     ` Eli Zaretskii
2015-12-23  6:07       ` Bill Wohler
2016-01-09  2:20         ` Mike Kupfer
2015-10-09  1:23 ` Wolfgang Jenkner
2016-02-01 18:53 ` Mike Kupfer [this message]
2016-02-02 18:28   ` bug#21650: fix should be underneath MH-E Glenn Morris
2016-02-02 22:23     ` Katsumi Yamaoka
2016-02-02 22:34       ` Glenn Morris
2016-02-02 23:34         ` Katsumi Yamaoka
2016-02-03  2:31         ` Lars Ingebrigtsen
2016-02-03  9:43           ` Katsumi Yamaoka
2016-02-03 22:52             ` Bill Wohler
2016-02-04  3:58               ` Mike Kupfer
2016-02-03  5:58       ` Bill Wohler
2016-02-04  6:09 ` Katsumi Yamaoka
2016-02-05  1:41   ` Mike Kupfer
2016-02-05  6:04 ` Katsumi Yamaoka
2016-02-06 22:53   ` Mike Kupfer
2016-02-05  6:41 ` Katsumi Yamaoka
2016-02-08 22:43 ` Katsumi Yamaoka
2016-02-09  0:41   ` Mike Kupfer
2016-02-09  3:24     ` Mike Kupfer
2016-02-09  1:49 ` Katsumi Yamaoka
2016-02-09  4:41 ` Katsumi Yamaoka
2016-02-09  5:49   ` Bill Wohler
2016-02-09 15:17   ` Mike Kupfer
2016-02-09 22:15 ` Katsumi Yamaoka
2016-02-10  2:23   ` Mike Kupfer
2016-02-10  3:51     ` Bill Wohler
2016-02-28  3:20     ` Mike Kupfer
2016-06-07  0:35 ` bug#21650: 21650: fixed in Emacs 25 Mike Kupfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29197.1454352814@allegro.localdomain \
    --to=m.kupfer@acm.org \
    --cc=21650@debbugs.gnu.org \
    --cc=wohler@newt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).