From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#48162: 28.0.50; Resizing using set-frame-width doesn't expand mode-line Date: Sun, 2 May 2021 18:57:08 +0200 Message-ID: <28c3ab57-5735-58fb-8008-dbb1b57c88f6@gmx.at> References: <0a6dc056-4950-0c3b-0d0a-733cc0ecddab@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9276"; mail-complaints-to="usenet@ciao.gmane.io" To: Alan Third , 48162@debbugs.gnu.org, pankaj@codeisgreat.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 02 18:58:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldFQO-0002JH-Ka for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 May 2021 18:58:32 +0200 Original-Received: from localhost ([::1]:42592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldFQN-0000Zn-NE for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 May 2021 12:58:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldFPu-0000Uq-Vo for bug-gnu-emacs@gnu.org; Sun, 02 May 2021 12:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60398) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldFPu-0004Gc-AJ for bug-gnu-emacs@gnu.org; Sun, 02 May 2021 12:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldFPu-0004wc-A4 for bug-gnu-emacs@gnu.org; Sun, 02 May 2021 12:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 May 2021 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48162 X-GNU-PR-Package: emacs Original-Received: via spool by 48162-submit@debbugs.gnu.org id=B48162.161997464718974 (code B ref 48162); Sun, 02 May 2021 16:58:02 +0000 Original-Received: (at 48162) by debbugs.gnu.org; 2 May 2021 16:57:27 +0000 Original-Received: from localhost ([127.0.0.1]:43705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldFPK-0004vy-U1 for submit@debbugs.gnu.org; Sun, 02 May 2021 12:57:27 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:56871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldFPI-0004vh-R4 for 48162@debbugs.gnu.org; Sun, 02 May 2021 12:57:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619974631; bh=8JfAnDsXellNTWErbYMJ5WIUjnRMF6T9P/eQ+mlzU8c=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=fhQeKnQML1WYr42fObSMzAyveIozOC2RlGmQxJ4w4M143YVGPONEfW6t9qamBhUtu VStZIWSNi0wOVICrXMPFfQUcM6H9F5erJKtdPUUtYk/Cq6BCsZqgF9NXk5zhR7+k9Y tYlIPHPpNXbhNTlyORl84vdYFNVNRGTorTHyUHuw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.190]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MQe5k-1lxW530Zz4-00Nj3P; Sun, 02 May 2021 18:57:11 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:kzn+E8ljWxyc7u3ixkvWN/D4jz54Ut+kc/IsP3aihjqNKUlbkyx wXNhlzzKQxjqRs3ONGRTt1WWQ2x9ERGrreaxwCtT6dNUY1ewUR5NoKOON/gGN+8xl4OYQBj oes/AMJIYwIlBPyjV58OxF8KMy4CCxsbM8HR/2VvjRaQ+KyoZITpSLaN/lQ/oyjJv4eqxBg iDnqQXoGJfk0uGThJEPKw== X-UI-Out-Filterresults: notjunk:1;V03:K0:umyeFWrQUV0=:CBkrASOzjFrMnd1mRLykli Q1AfMocM01ZVLw9jzWyM3AT4JysY9H016qsPEcxRp94UwWJqE1+xfIm757ONgvm163Mh+iHdV wr/KDVJsBiGmhtcJUVcWHthNzJZ4/iCI+YrMifNlDdbDtQhsAiXl8krMiTmFW4pXQSzgZUffv gBHa8RVU6DOXE0Xx8k+0YnpcugL4Odeml8+XwbgvEaj0bKUHTonecQ3LXVVjhayWYu7PinXSa Og0DAhbVhJtwIzkLETFg9d+Rd0k8gjthsjiaEnB+DxC8Qlwzf+fZaH7lLE8N8YENcLMkTYQhM Ww/t2nvgO4G65zeSKiJp13PBSbfNRXWLXlpJPCz9etxUJUm3GInRrr5CrbJzY1PvDRpHscNI1 nkMg9Nae8j9Lo/qJy+rDNPVKHy+hjqMjN1l4tNiVF5OV+T5t887H9cx/mMjqoZR1dlXRKnPgi z7q0MsvXNhLaUOafUmoyIRkb1wWZ1ZSpmgYD9Eaaxcs6RqaHW4hRdxVR7e0h3OsmutuZ3kRS3 +/oAUGvwiQymOOsr9d4PHskrbwMdCe5W9YOa7vFo6dsP66/acRnPHCNosdGVb2jsOEWz/IwH1 YBAV1fgPyBdfhrEtd5gK9BtQDBWMOWR01vKbnxkKjek6Gtxluh2b4axcyVZUU+qHa0TKjygZ1 CXU3iARNYCJepUOl2apKWyxEzWF1URA1Z62cP0xMR+/zBhMy3RBOuXpNURkxQu3yan3prceTm y4NIas4mVtJVDVhICkQtptR9iqQDqhbRiFnPLjxn3IfzYuZEX5jS5lWqy3AZVPq5uRF8QRzv X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205441 Archived-At: > This patch reintroduces the infinite loop I was trying to avoid. > > viewDidResize is called every time the view's "frame" is touched. Most > of the time this happens when nothing has changed, but calling > change_frame_size, even when nothing has changed, appears to cause the > toolbar to redraw, which causes viewDidResize to be called again, and > so on ad infinitum. > > So I put in the check whether the new frame size that's reported is > actually the same as the previous frame size, and if so do nothing. > Then realised that I need to check the new_height and new_width > settings in case the change is already pending. > > I'm not sure where new_size_p comes into it, perhaps we don't even > need to check it in viewDidResize, because all we care about is the > final outcome? > > Maybe this really isn't the way to do it and I need to keep track of > the frame size separately, which is something I was hoping to avoid. new_size_p true means that Emacs has already received a resize event for this frame but was not yet able to process it. So the additional || (newh == emacsframe->new_height && neww == emacsframe->new_width))) in that case should "do nothing" when "nothing has changed". Where does my reasoning go wrong? martin