From: Phil Sainty <psainty@orcon.net.nz>
To: 58608@debbugs.gnu.org
Subject: bug#58608: 29.0.50; Nasty bug with pasting primary selection in term buffers
Date: Wed, 19 Oct 2022 16:22:32 +1300 [thread overview]
Message-ID: <28b4d56584b38019d38d6c7c9e0bb2d1@webmail.orcon.net.nz> (raw)
In-Reply-To: <901d65e2e6e961136ff0053917d57a05@webmail.orcon.net.nz>
> In line mode middle click calls `mouse-yank-primary'
I realised I should look at this as well, and sure enough it has
some handling for `select-active-regions':
(defun mouse-yank-primary (click)
"Insert the primary selection at the position clicked on.
Move point to the end of the inserted text, and set mark at
beginning. If `mouse-yank-at-point' is non-nil, insert at point
regardless of where you click."
(interactive "e")
;; Give temporary modes such as isearch a chance to turn off.
(run-hooks 'mouse-leave-buffer-hook)
;; Without this, confusing things happen upon e.g. inserting into
;; the middle of an active region.
(when select-active-regions
(let (select-active-regions)
(deactivate-mark)))
(or mouse-yank-at-point (mouse-set-point click))
(let ((primary (gui-get-primary-selection)))
(push-mark)
(insert-for-yank primary)))
The call to (mouse-set-point click) is also conditional here:
(or mouse-yank-at-point (mouse-set-point click))
As opposed to:
(defun term-mouse-paste (click)
"Insert the primary selection at the position clicked on."
(interactive "e")
;; Give temporary modes such as isearch a chance to turn off.
(run-hooks 'mouse-leave-buffer-hook)
(setq this-command 'yank)
(mouse-set-point click)
(term-send-raw-string (gui-get-primary-selection)))
I don't know if `mouse-yank-at-point' needs consideration here too?
I wondered whether both of these could be rewritten to use a common
subroutine, but it might be a bit awkward. Failing that, I would
cross-reference them in code comments (are there any other similar
functions besides?).
next prev parent reply other threads:[~2022-10-19 3:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 10:10 bug#58608: 29.0.50; Nasty bug with pasting primary selection in term buffers Phil Sainty
2022-10-18 23:10 ` Phil Sainty
2022-10-19 0:53 ` Phil Sainty
2022-10-19 1:19 ` Phil Sainty
2022-10-19 2:09 ` Phil Sainty
2022-10-19 3:22 ` Phil Sainty [this message]
2022-10-19 5:03 ` Phil Sainty
2022-10-19 11:05 ` Eli Zaretskii
2022-10-19 22:14 ` Phil Sainty
2022-10-20 5:36 ` Eli Zaretskii
2023-03-14 12:46 ` Phil Sainty
2023-03-14 14:28 ` Phil Sainty
2023-03-16 7:17 ` Eli Zaretskii
2023-03-26 12:45 ` Phil Sainty
2023-03-26 13:47 ` Eli Zaretskii
2023-03-26 13:48 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28b4d56584b38019d38d6c7c9e0bb2d1@webmail.orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=58608@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).