From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61396: diff mode could distinguish changed from deleted lines Date: Fri, 15 Sep 2023 13:20:36 +0300 Message-ID: <289a8389-9b8d-a0cb-fa7a-810602fd4aa1@gutov.dev> References: <85f73356-3a11-c76c-dd9a-f2dc1f6ef504@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33668"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 61396@debbugs.gnu.org, Samuel Wales To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 15 12:21:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qh5wp-0008Nd-Hv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Sep 2023 12:21:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qh5wa-00031z-Bp; Fri, 15 Sep 2023 06:21:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh5wW-00031W-2Y for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 06:20:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qh5wV-0001h4-Pj for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 06:20:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qh5wb-0003IX-Ss for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 06:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Sep 2023 10:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61396 X-GNU-PR-Package: emacs Original-Received: via spool by 61396-submit@debbugs.gnu.org id=B61396.169477325812660 (code B ref 61396); Fri, 15 Sep 2023 10:21:01 +0000 Original-Received: (at 61396) by debbugs.gnu.org; 15 Sep 2023 10:20:58 +0000 Original-Received: from localhost ([127.0.0.1]:42152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh5wX-0003I7-Kl for submit@debbugs.gnu.org; Fri, 15 Sep 2023 06:20:57 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:41027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh5wS-0003Hq-Mk for 61396@debbugs.gnu.org; Fri, 15 Sep 2023 06:20:56 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5F5745C0182; Fri, 15 Sep 2023 06:20:39 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 15 Sep 2023 06:20:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1694773239; x=1694859639; bh=BRm1XfYIoErkmaHkiUYPJUnFNKCIvEQA+my 261rap9U=; b=QJQeH2KRo5LL/vGb+2EBv4SwHk4gt3oQVAiBQOLdBJKcykxVnuz 2KA5Kw3cSdjdOuVuWDLNkG1xgt95rNYFjf2uM6bQ8oP5g8dRJxH4dSDAOpVls9LF OfuFcpVraSix6ny+Ef40PnUe43w+jV35zmohWwSKgZUHTwkYm0Vk1IRD6QnKS5si uCDqQreFKtPE5LidMt5LYUZy30t7oB3zN+qGk51vZHO7sWc/ss25T4edmbTmjm1Q DSpuqEd7AMSRJ4hJIbZj2MpFRdpsLFBvYmLkcbuTsyrHgm/51QlyG0an1ny9b10G LrlunzwwFEdmNyOcHC3JPho0bfbbgMs8EjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1694773239; x=1694859639; bh=BRm1XfYIoErkmaHkiUYPJUnFNKCIvEQA+my 261rap9U=; b=U8hJGNcvlK8iPPO60rKMNbTGhrtSa4Za14IBDIy7Rm4CQxrmR3g Iy4GFCGOKh+4A0XNWamg5JUzrR9Mso/NbJQcDjDQf9efvXm/MgCSHgrFOQynAnR2 Tlch7Nhr094RBvuQQZPlOhG4sCwqSkA26KMdAKuFVEFNsGhgWReRPnGtNLT6graG NyQrDApmgCWPAELGKsXfejYrkZpbrlQkvwZv9RPo+5UkJBvyZhlb8dE9JeZPb8hK V1NytfR7GK9dUhi5gItaDUTf764gF/4k8GCFN8pVLLzOlrFQjpllYXStUb/LVEp4 +lN9FsKpgpKXZLB8LAax7WtuEcojPh029KA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudejvddgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Sep 2023 06:20:38 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270514 Archived-At: On 15/09/2023 04:34, Stefan Monnier wrote: >> - Like Samuel mentioned, attenuate the indicators' column. Except instead of >> inverse video just apply the refine faces? See >> diff-refine-indicators.png. Looks good to me color-wise, though the change >> in the indication method is somewhat an inconsistency. > I think I like that. But I'm not sure how to adapt this to my case > where I "prettify" the indicators into the fringe. Fringes can use faces; those faces' backgrounds are also used for the background of the fringe. So in theory I don't see any problem, although how to write it in Lisp to keep both possibilities (fringe and non-fringe), might require some effort. > Maybe a related idea would be to use the diff-refine-added/removed face > on the line-end: the reduced contrast is not a problem there since > there's no text. But it's not always visible (for long enough lines). > > I suspect we'll have to provide various alternatives and see which > ones stick.