From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konrad Podczeck Newsgroups: gmane.emacs.bugs Subject: bug#62234: Toolbar does not work properly (with Emacs 29 or 30) Date: Thu, 23 Mar 2023 15:57:35 +0100 Message-ID: <289259DB-505A-40BB-AEC9-E4A8554A3B03@univie.ac.at> References: <83sfe3eqaf.fsf@gnu.org> <83jzzfegy0.fsf@gnu.org> <87a60a3nrj.fsf@yahoo.com> <871qlm3g9t.fsf@yahoo.com> <838rfn6g7x.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_F564C7BA-383A-438E-9E6D-EDB1B24F8A66" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33520"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 62234-done@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 23 15:58:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfMOf-0008RX-UA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Mar 2023 15:58:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfMOC-0007gr-Ux; Thu, 23 Mar 2023 10:58:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfMOA-0007gR-M2 for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 10:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfMOA-0008Ha-DY for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 10:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfMOA-0001VH-AA for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 10:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konrad Podczeck Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Mar 2023 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62234 X-GNU-PR-Package: emacs Original-Received: via spool by 62234-done@debbugs.gnu.org id=D62234.16795834615749 (code D ref 62234); Thu, 23 Mar 2023 14:58:02 +0000 Original-Received: (at 62234-done) by debbugs.gnu.org; 23 Mar 2023 14:57:41 +0000 Original-Received: from localhost ([127.0.0.1]:39091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfMNp-0001Uf-29 for submit@debbugs.gnu.org; Thu, 23 Mar 2023 10:57:41 -0400 Original-Received: from grace.univie.ac.at ([131.130.3.115]:48980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfMNm-0001UU-Kf for 62234-done@debbugs.gnu.org; Thu, 23 Mar 2023 10:57:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=univie.ac.at; s=rev3; h=References:To:Cc:In-Reply-To:Date:Subject: Mime-Version:Content-Type:Message-Id:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=oGHT6/xGjirFSZkxRRi/n/ndmKG30hvnwzkZC/m1/Bg=; b=HJPlggDkGlyEh1Xa26/tRLwMBx TRxxq/edeP2+fqToUcTrfBOvfgi4v/pQz5DpKyEtSPSB6pqdevG8riTkUksUmmapWQUBu/BrVndxy PJYrubo2qN29h9crsOniT7eo6Kt367i2v4E/s1zgEx/pN7qi83YYMhSbd1RmdlJxfSeBNbsI085dQ Tk1KBxPu0+3ToWDDNd92TgS+WrI4ndyNtNDDPuqfUQyloU7XLQrzkcb3oW4pbS8WpWYIEZTv+lMuT nts4+g6cSw7NjCS+kqGZl2uHtgf3feGBH5HfsmX7uHDD8EMlNxNOry74ke4mvB+16+B3P/Oedv/jS vklz9R9w==; Original-Received: from joan.univie.ac.at ([131.130.3.110] helo=joan.univie.ac.at) by grace.univie.ac.at with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pfMNk-007p4X-21; Thu, 23 Mar 2023 15:57:36 +0100 Original-Received: from 80-109-8-38.cable.dynamic.surfer.at ([80.109.8.38] helo=smtpclient.apple) by joan.univie.ac.at with esmtpsa (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.96) (envelope-from ) id 1pfMNk-006E9R-12; Thu, 23 Mar 2023 15:57:36 +0100 In-Reply-To: <838rfn6g7x.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.120.41.1.2) X-Univie-Virus-Scan: scanned by ClamAV on joan.univie.ac.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258462 Archived-At: --Apple-Mail=_F564C7BA-383A-438E-9E6D-EDB1B24F8A66 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Thanks! Konrad > Am 23.03.2023 um 09:10 schrieb Eli Zaretskii : >=20 >> From: Daniel Mart=C3=ADn > >> Cc: Eli Zaretskii >, = 62234@debbugs.gnu.org , Konrad Podczeck >> > >> Date: Sat, 18 Mar 2023 11:25:51 +0100 >>=20 >> Po Lu writes: >>=20 >>>> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem >>>> +{ >>>> + return [toolbarItem isEnabled]; >>>> +} >>>> + >>>=20 >>> This does no harm on GNUstep. However, please indent with two = spaces, >>> and place spaces after -, :, and ): >>>=20 >>> - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem >>> { >>> return [toolbarItem isEnabled]; >>> } >>>=20 >>> Otherwise, LGTM. Thanks. >>=20 >> OK, I've attached a new version of the patch. Konrad, could you = check >> if with this patch the Emacs toolbar works as you expect? Thanks. >=20 > Thanks, installed on the emacs-29 branch, and closing the bug. --Apple-Mail=_F564C7BA-383A-438E-9E6D-EDB1B24F8A66 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Thanks!

Konrad

Am 23.03.2023 um 09:10 schrieb = Eli Zaretskii <eliz@gnu.org>:

From: Daniel Mart=C3=ADn <mardani29@yahoo.es>
Cc: Eli Zaretskii = <eliz@gnu.org>, =  62234@debbugs.gnu.org,  Konrad Podczeck
<konrad.podczeck@univie.ac.at>
Date: Sat, = 18 Mar 2023 11:25:51 +0100

Po Lu <luangruo@yahoo.com> = writes:

+-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem
+{
+    return [toolbarItem = isEnabled];
+}
+

This does no harm on GNUstep. =  However, please indent with two spaces,
and place = spaces after -, :, and ):

- (BOOL) = validateToolbarItem: (NSToolBarItem *) toolbarItem
{
 return [toolbarItem isEnabled];
}

Otherwise, LGTM.  Thanks.

OK, I've attached a new version = of the patch.  Konrad, could you check
if with this = patch the Emacs toolbar works as you expect?  Thanks.

Thanks, installed on the emacs-29 branch, and closing the = bug.

= --Apple-Mail=_F564C7BA-383A-438E-9E6D-EDB1B24F8A66--