From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64088: [PATCH] Make project-root for vc projects return an absolute path Date: Sun, 18 Jun 2023 03:43:27 +0300 Message-ID: <288fccb0-be65-eb90-6c45-2db2ecebc979@gutov.dev> References: <838rckt0lz.fsf@gnu.org> <7dc390c9-5888-ee7b-386e-21054ec9f2d6@gutov.dev> <835y7msizj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38835"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: sbaugh@janestreet.com, 64088@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 18 02:44:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qAgWX-0009ru-Fi for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Jun 2023 02:44:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAgWR-00004v-R0; Sat, 17 Jun 2023 20:44:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAgWQ-0008Uq-G5 for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2023 20:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAgWQ-00006j-6d for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2023 20:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAgWQ-0000Mf-28 for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2023 20:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 00:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64088 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64088-submit@debbugs.gnu.org id=B64088.16870490191365 (code B ref 64088); Sun, 18 Jun 2023 00:44:02 +0000 Original-Received: (at 64088) by debbugs.gnu.org; 18 Jun 2023 00:43:39 +0000 Original-Received: from localhost ([127.0.0.1]:52831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAgW3-0000Lx-IH for submit@debbugs.gnu.org; Sat, 17 Jun 2023 20:43:39 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:37111) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAgW0-0000Le-Az for 64088@debbugs.gnu.org; Sat, 17 Jun 2023 20:43:37 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4027B5C00F5; Sat, 17 Jun 2023 20:43:31 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 17 Jun 2023 20:43:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1687049011; x=1687135411; bh=WDtRLaUBCtg7d5n0ry06dQFf1pr5IyCUb+H D20m/e6U=; b=YrgBFM5XToObeIzBtH9M5/IWC5TI3g51MqmDqe71BzGzpbzcAjc 0RUhExUhObuQVYkda4MMJYPAOYxS2GFl6YofPs0z/A2GZTo4a3Lz4cmE13CPkKTG QzJiT1480Xg9GJlNHK928LQ4HVMQwVL7psI6W2mVAwkUXCwss+lY5S7s8gzte9nk QW2cyLDqQLHT5nEbHxdUZZlmJs8l3CBPx5lUEE9sVcTYZH47Lhmv/8dMjLPUSzY3 +5/3+1FtU3fFNt6igoPENbBcf8PeqPm9XDOYKwPUGsYrNDFynjtLI/nkVuaiOqem QYkAOeS7/f7mWKH+eaMTBZQ+Gfl7sGWmZ5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687049011; x=1687135411; bh=WDtRLaUBCtg7d5n0ry06dQFf1pr5IyCUb+H D20m/e6U=; b=fUcYmm8nt2RcuHqH/QoIg0YycFPXN6z9zvTiIoVy0LEC3/edot5 mzwMeA96Mj6Rf1IILajI8KvtVEYQgvHLC1t8izku+m90upchn5s1y3XwPLvQOWTz oAUYBA3FLO1/hpIuuKW8evXqeOeRZ50DwHtW+3oleCFifT2hmycQPyveobsZs17v Vh5ip8PzAGUa7HDeF6SHYiYIBrb2aDECHzXVym1BJY636CSd75XkZKEESA+4JwRS UtVc8o4ZYSXRzpdDci6mvxx19hBy7ze5PmpODLOdnWoeztkinYSXiDeRpOAy+hiD 5buCnJzjTLufjbhhwH+cAaE8iO9D1RdidPQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvkedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 17 Jun 2023 20:43:29 -0400 (EDT) Content-Language: en-US In-Reply-To: <835y7msizj.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263591 Archived-At: On 17/06/2023 09:25, Eli Zaretskii wrote: > IME, low-level functions should not make any assumptions about what > higher-level code will need. On the contrary, it's higher-level code > which knows what it needs that should do the conversions it needs. That's the idea: project-root is always a callee, not a caller, so it's "low-level", in your terminology. The conversion (or normalization) would happen on the higher level: when the projects are added to the list, or searched.