From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61340: 29.0.60; Extra space in xref buffer Date: Sun, 19 Feb 2023 00:04:05 +0200 Message-ID: <283e5bae-64a8-eb08-fa53-f384b6d1d02f@yandex.ru> References: <868rh9zzws.fsf@mail.linkov.net> <6a7e3db4-bc2b-2742-bc6c-ad9da8203b85@yandex.ru> <86r0v0zk1o.fsf@mail.linkov.net> <86r0v080cf.fsf@mail.linkov.net> <86edqyralw.fsf@mail.linkov.net> <8c00c717-f046-41a5-56a3-6abebf996b63@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5190"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 61340@debbugs.gnu.org, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 18 23:05:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTVKd-0001CB-T8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Feb 2023 23:05:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTVKK-0003u6-Dx; Sat, 18 Feb 2023 17:05:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTVKI-0003tr-Od for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 17:05:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTVKI-0005jb-Dj for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 17:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTVKI-0003t0-0b for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 17:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2023 22:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61340 X-GNU-PR-Package: emacs Original-Received: via spool by 61340-submit@debbugs.gnu.org id=B61340.167675785514850 (code B ref 61340); Sat, 18 Feb 2023 22:05:01 +0000 Original-Received: (at 61340) by debbugs.gnu.org; 18 Feb 2023 22:04:15 +0000 Original-Received: from localhost ([127.0.0.1]:45111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTVJX-0003rS-75 for submit@debbugs.gnu.org; Sat, 18 Feb 2023 17:04:15 -0500 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:51839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTVJV-0003rD-Mf for 61340@debbugs.gnu.org; Sat, 18 Feb 2023 17:04:14 -0500 Original-Received: by mail-wm1-f48.google.com with SMTP id bg33so51089wmb.1 for <61340@debbugs.gnu.org>; Sat, 18 Feb 2023 14:04:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=t78fSSp0onUJN9YkGL3O2h3ZSm1I/MsEWf8jOiPNC5M=; b=QL4bb4X+/NWaF9is+wMvghsbZGSAjYY3X1l6n7o73fGY3IxvfFXQS0P6b7uXo9G2ym Jcc60WjANRC3sMVFWbBxwFxqKrdDJfzkcIqM1u017ccj9VJgZDwiiqd4j63FSaL14Faz 3uQv3MOJrLn8DqS1xj3Oldxn3WVX97XgGTd9PyTYTfcd09Tu2+t7Y5hinTYhjgrhJRGX E332VsDvBTZWtGDTKWYDV1RuknRlNJ757y9HEDJhFcV+HRadU5STnmB8vCZBpHLCV+BP lD0/hBoRn4Up1W0GzZgw6R83ZXBxkZKa6cVp8aKKdKOifNzUsY48XAeqgHex0mQ6Md97 /i0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t78fSSp0onUJN9YkGL3O2h3ZSm1I/MsEWf8jOiPNC5M=; b=A1uJolPmMo+qfcVJvktXbNfmrFGNpTW+QpWOZ1eQXKVOv6RAGBzwkvYbwTmJPioSMi pjf/xpOl/5AgD/gjEMKbn2hn1iNAKz4tJkfcEbaXKnFwybOWbKPcADC5wVlISqVuGkPA 5vdRzd8i/6NTHyEG6CK8LJi6eTNaa0/c1hRzNMkzhQZmkqsJNpr/k5je+49jVbTnYIw/ k1JcETZoPcJjpTkMtvmFtrDVADMxGrMb2L9O57ldwdGnfieRd5enzw404DkkYhPCQvyz tPFf8+5yQHEfdlDmKAaYXmUqdiyRYgefDtO4wNw3eE7lAJNXFTo/8AwEUTxJx5KnMvLb 5U5A== X-Gm-Message-State: AO0yUKUqN9wqCPn1qWSbyNZnHNFZmJwlM0VuC/5OTieMHvCXwI8lZlI8 NInhrlLugx/C+oN7PV6Pvuc= X-Google-Smtp-Source: AK7set8SIrIOr4I/P4iSyR9bEfYsDBcelMJmEjPYBd+u0s0S2uAUM937Yw3XkGlSf6h65qnwzOBUaw== X-Received: by 2002:a05:600c:13d5:b0:3df:c284:7e78 with SMTP id e21-20020a05600c13d500b003dfc2847e78mr4461370wmg.38.1676757847623; Sat, 18 Feb 2023 14:04:07 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id i17-20020adfefd1000000b002c55551e6e9sm423385wrp.108.2023.02.18.14.04.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Feb 2023 14:04:07 -0800 (PST) Content-Language: en-US In-Reply-To: <8c00c717-f046-41a5-56a3-6abebf996b63@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255999 Archived-At: Hi Eli, Should we backport this to emacs-29? The improvement is minor, but the risk is very small as well. On 09/02/2023 21:58, Dmitry Gutov wrote: > On 09/02/2023 19:51, Juri Linkov wrote: >>> Here's the change I was suggesting. >>> >>> The difference is subtle, but seems like an improvement: >>> >>> diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el >>> index 63e065e696e..581eda0513e 100644 >>> --- a/lisp/progmodes/xref.el >>> +++ b/lisp/progmodes/xref.el >>> @@ -1126,7 +1126,9 @@ xref--insert-xrefs >>>                                      maximize (xref-location-line >>>                                                (xref-item-location >>> xref))) >>>              for line-format = (and max-line >>> -                                  (format "%%%dd:" (1+ (floor (log >>>                                     max-line 10))))) >>> +                                  (format >>> +                                   #("%%%dd:" 0 4 (face >>> xref-line-number) >>> 5 6 (face shadow)) >> Thanks, this looks nice and closer to the grep output fontification.