From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#33771: 27.0.50; Error building Harfbuzz branch on Debian testing Date: Sun, 16 Dec 2018 21:18:04 -0800 Message-ID: <28241.1545023884@alto> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1545023828 9984 195.159.176.226 (17 Dec 2018 05:17:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2018 05:17:08 +0000 (UTC) Cc: Philipp , 33771@debbugs.gnu.org, far.nasiri.m@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 17 06:17:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYlH5-0002Tu-UB for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2018 06:17:04 +0100 Original-Received: from localhost ([::1]:44928 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYlJC-0003xp-Es for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2018 00:19:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYlJ3-0003xF-Qd for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 00:19:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYlJ0-0004GF-Iy for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 00:19:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46509) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gYlJ0-0004G3-F3 for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 00:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gYlJ0-0005rn-8z for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2018 00:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Dec 2018 05:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33771 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33771-submit@debbugs.gnu.org id=B33771.154502389522487 (code B ref 33771); Mon, 17 Dec 2018 05:19:02 +0000 Original-Received: (at 33771) by debbugs.gnu.org; 17 Dec 2018 05:18:15 +0000 Original-Received: from localhost ([127.0.0.1]:50767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYlIE-0005qd-Sq for submit@debbugs.gnu.org; Mon, 17 Dec 2018 00:18:15 -0500 Original-Received: from shell1.rawbw.com ([198.144.192.42]:38217 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYlIC-0005qT-DT for 33771@debbugs.gnu.org; Mon, 17 Dec 2018 00:18:13 -0500 Original-Received: from alto (96-95-200-133-static.hfc.comcastbusiness.net [96.95.200.133]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id wBH5I5GR009302 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 16 Dec 2018 21:18:10 -0800 (PST) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 96-95-200-133-static.hfc.comcastbusiness.net [96.95.200.133] claimed to be alto In-Reply-To: Your message of "Sun\, 16 Dec 2018 21\:52\:34 +0200." <83r2ehdzb1.fsf@gnu.org> X-Mailer: MH-E 8.6+git; nmh 1.6; GNU Emacs 26.1.90 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153506 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii wrote: > Does the below fix the problem? It helps, thanks. I needed to make a similar change in a few other places, at least for building on Solaris. I've attached the patch I ended up with. I still can't get a clean build, because of Checking /export/home/kupfer/src/emacs-git/lisp/leim/quail/japanese.el ... Fatal error 11: Segmentation Fault Backtrace: /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'emacs_backtrace+0x43 [0x5b63f3] /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'terminate_due_to_signal+0x8b [0x59c40b] /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'0x1b4cfe [0x5b4cfe] /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'deliver_thread_signal.constprop.13+0x2a [0x5b4eea] /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'handle_sigsegv+0x1f [0x5b4f4f] /lib/amd64/libc.so.1'__sighndlr+0x6 [0x7fffbe44ebe6] /lib/amd64/libc.so.1'call_user_handler+0x2f1 [0x7fffbe4406b1] /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'decode_char+0x3db [0x53804b] /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'decode_coding_iso_2022+0x141e [0x544bde] /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'decode_coding+0x18f [0x54976f] /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'decode_coding_gap+0x15f [0x550f9f] /export/home/kupfer/src/emacs-git/src/bootstrap-emacs'Finsert_file_contents+0x11fb [0x5cf5eb] ... I got the same failure building master, so it's not related to HarfBuzz. I'll follow up about this second failure when I get some time; maybe next week. cheers, mike --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=otf-harfbuzz-2.patch Content-Description: patch: HarfBuzz but no libotf diff --git a/src/ftcrfont.c b/src/ftcrfont.c index 6d74d937a7..ae5b0a92ee 100644 --- a/src/ftcrfont.c +++ b/src/ftcrfont.c @@ -302,7 +302,7 @@ struct font_driver const ftcrfont_driver = #ifdef HAVE_LIBOTF .otf_capability = ftfont_otf_capability, #endif -#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ +#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ) .shape = ftfont_shape, #endif #ifdef HAVE_OTF_GET_VARIATION_GLYPHS diff --git a/src/ftfont.c b/src/ftfont.c index bc98896393..bbdc936ffd 100644 --- a/src/ftfont.c +++ b/src/ftfont.c @@ -2931,7 +2931,7 @@ ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face ft_face, hb_font_t *hb_font, #endif /* HAVE_HARFBUZZ */ -#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ +#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ) Lisp_Object ftfont_shape (Lisp_Object lgstring) @@ -2956,7 +2956,7 @@ ftfont_shape (Lisp_Object lgstring) } } -#endif /* defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ */ +#endif /* HAVE_LIBOTF && (HAVE_M17N_FLT || defined HAVE_HARFBUZZ) */ static const char *const ftfont_booleans [] = { ":antialias", @@ -3037,7 +3037,7 @@ static struct font_driver const ftfont_driver = #ifdef HAVE_LIBOTF .otf_capability = ftfont_otf_capability, #endif -#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ +#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ) .shape = ftfont_shape, #endif #ifdef HAVE_OTF_GET_VARIATION_GLYPHS diff --git a/src/ftxfont.c b/src/ftxfont.c index 4d4ff6ee0c..a30b07636e 100644 --- a/src/ftxfont.c +++ b/src/ftxfont.c @@ -359,7 +359,7 @@ struct font_driver const ftxfont_driver = .otf_capability = ftfont_otf_capability, #endif .end_for_frame = ftxfont_end_for_frame, -#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ +#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ) .shape = ftfont_shape, #endif #ifdef HAVE_OTF_GET_VARIATION_GLYPHS diff --git a/src/xftfont.c b/src/xftfont.c index e0bd243467..5111936f3e 100644 --- a/src/xftfont.c +++ b/src/xftfont.c @@ -672,7 +672,7 @@ xftfont_draw (struct glyph_string *s, int from, int to, int x, int y, return len; } -#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ +#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ) static Lisp_Object xftfont_shape (Lisp_Object lgstring) { @@ -784,7 +784,7 @@ struct font_driver const xftfont_driver = .otf_capability = ftfont_otf_capability, #endif .end_for_frame = xftfont_end_for_frame, -#if defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ +#if defined HAVE_LIBOTF && (defined HAVE_M17N_FLT || defined HAVE_HARFBUZZ) .shape = xftfont_shape, #endif #ifdef HAVE_OTF_GET_VARIATION_GLYPHS --=-=-=--