From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74725: 31.0.50; image-scaling-factor is ignored by create-image Date: Sat, 7 Dec 2024 17:27:13 +0100 Message-ID: <2793f551-8715-4679-8f52-b4673dd6802d@orange.fr> References: <2304cad6-884f-4528-a85e-ab9c06b80016@orange.fr> <868qsrim4a.fsf@gnu.org> Reply-To: David Ponce Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6422"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Alan Third , Eli Zaretskii , 74725@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 07 17:28:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJxfK-0001Xy-IO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Dec 2024 17:28:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJxf3-0002kE-ES; Sat, 07 Dec 2024 11:28:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJxf0-0002iz-Dw for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 11:28:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJxf0-0007Ej-4w for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 11:28:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=I6T4MmXuKWGtCGlvmMO2ULPlQZn1BjyvBHcIRObjgZE=; b=CJAEUPtfTaL/XROdvkT5d+9Mn++v3RxeBDto14EU/e/KAu5WoO4EzX27ONLWCyWP/0+4sQOMDC336v2J5+KTwjfYiI+WMZOgE6NrgSiErCrGDPIJTcIGqDAi9SIEHggyb09IU6djgPUVTceOezpyDGci2O5pE0VGo+JSPp7FYnybbSmts6Zqfc2A08XT+HL6ZCvWUfRT81lQvSgN3XvpeFoqxO3amgsvff9Ql+8eyHevjsVyG0ixr9g57sqQaWC7xt8K6iOlISWipw9Wc4mlXCDdRoBhVsrVIGA68BEPa4Ok8SP1/kVMsU9Hb4BDV6hTMKHrtDTW7XP+/JEv4Tvv5Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJxez-00068U-Vm for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 11:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2024 16:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74725 X-GNU-PR-Package: emacs Original-Received: via spool by 74725-submit@debbugs.gnu.org id=B74725.173358883923493 (code B ref 74725); Sat, 07 Dec 2024 16:28:01 +0000 Original-Received: (at 74725) by debbugs.gnu.org; 7 Dec 2024 16:27:19 +0000 Original-Received: from localhost ([127.0.0.1]:48286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJxeJ-00066r-AI for submit@debbugs.gnu.org; Sat, 07 Dec 2024 11:27:19 -0500 Original-Received: from smtp-24.smtpout.orange.fr ([80.12.242.24]:47175 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJxeG-00066g-TX for 74725@debbugs.gnu.org; Sat, 07 Dec 2024 11:27:18 -0500 Original-Received: from [192.168.1.21] ([90.112.40.65]) by smtp.orange.fr with ESMTPA id JxeDtKcbce9OfJxeEtw2uf; Sat, 07 Dec 2024 17:27:15 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1733588835; bh=I6T4MmXuKWGtCGlvmMO2ULPlQZn1BjyvBHcIRObjgZE=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=ik+/2WClY6HFQs93O7e1qFCVF6uhUNxJk8NRRJMviKo7JZ2wfFHjV+qIc4S3Kq3Ha vfiCmbXRmv95iqEkYRBVTjyB2GeRV6SUU36tDDwvQlrQeFFv6EktjrKwVy3KcPSRC/ JRPSJIfnr+xKxbhNOpnxUncJjCJlREv49DOodF6t/GDQ51eaz2gE8oIlnumIhQS87g erA1J5hLqvhsxBct4q+QUMVMdXwFXdCRrHfQnouXumSyPxGRVYzgHYE+8/HI74c1ui khWC3DC+NDyp2EnjSFdRhstsnSHQU0JvB1Vfa14SxpdaJu+NHIhke47VVafVGlfICb /KHwTCYvk9/+A== X-ME-Helo: [192.168.1.21] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Sat, 07 Dec 2024 17:27:15 +0100 X-ME-IP: 90.112.40.65 Content-Language: fr, en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296579 Archived-At: On 2024-12-07 16:49, Alan Third wrote: > On Sat, Dec 07, 2024 at 04:49:41PM +0200, Eli Zaretskii wrote: >>> Date: Sat, 7 Dec 2024 13:13:58 +0100 >>> From: David Ponce via "Bug reports for GNU Emacs, >>> the Swiss army knife of text editors" >>> >>> While working with images, I found what seems an issue to me with >>> `create-image' which unconditionally set the :scale image property to >>> 'default' when not specified, ignoring the value of the option >>> `image-scaling-factor'. >>> >>> Here is an illustration: >>> >>> (let ((image-scaling-factor 1.0)) >>> (image-size >>> (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg"))) >>> t)) >>> => (63 . 63) >>> >>> (let ((image-scaling-factor 2.0)) >>> (image-size >>> (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg"))) >>> t)) >>> => (63 . 63) >>> >>> (image-size >>> (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg" :scale 1))) >>> t) >>> => (48 . 48) >>> >>> (image-size >>> (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg" :scale 2))) >>> t) >>> => (96 . 96) >>> >>> You can replace `image-size' with `insert-image' and observe the same. >>> >>> Here is a simple patch which fix the issue for me: >>> >>> diff --git a/lisp/image.el b/lisp/image.el >>> index ce97eeb3ca1..2c1e865c336 100644 >>> --- a/lisp/image.el >>> +++ b/lisp/image.el >>> @@ -536,7 +536,9 @@ create-image >>> file-or-data) >>> (and (not (plist-get props :scale)) >>> ;; Add default scaling. >>> - (list :scale 'default)) >>> + (list :scale (if (numberp image-scaling-factor) >>> + image-scaling-factor >>> + 'default))) >>> props))) >>> ;; Add default smoothing. >>> (unless (plist-member props :transform-smoothing) >> >> AFAIU, this is supposed to be taken care of in image.c. >> >> Alan, any ideas why this doesn't seem to work? > > It's because the image spec doesn't change so the image is pulled from > the cache each time. > > Flushing the image between calls to image-size fixes it: > > (image-flush (find-image '((:file "icons/hicolor/scalable/apps/emacs.svg")))) > > I'm not sure what the solution is here. My feeling is that > image-scaling-factor isn't intended as something you set for each > image as you load it, it's a set-and-forget setting, so perhaps we > just need to document that in order for it to take effect the image > cache needs to be flushed. > > Alternatively we make the image cache aware of it. > > Perhaps we can flush the cache automatically when it changes? That > might give unexpected results too. This is exactly what I also observe. It seems due to this change: author Po Lu 2024-06-03 16:34:51 +0800 committer Po Lu 2024-06-03 16:36:29 +0800 commit 56376585134d627f96c71b7b063ec51548d3ad3f (patch) Which replaced - (list :scale - (image-compute-scaling-factor - image-scaling-factor))) By this + (list :scale 'default)) In create-image. With the side effect that the image spec don't change when the scaling factor changes, so the same cached image in always used. Not sure either what a solution could be.