From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Bill Wohler Newsgroups: gmane.emacs.bugs Subject: bug#25552: 26.0.50; load cl unintendedly Followup-To: gmane.mail.mh-e.devel Date: Sun, 30 Apr 2017 22:10:40 -0700 Organization: Newt Software Message-ID: <27497.1493615440__17345.818601507$1493615533$gmane$org@olgas.newt.com> References: <4893.1491747946@alto> <12659.1492133413@alto> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1493615533 28539 195.159.176.226 (1 May 2017 05:12:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 1 May 2017 05:12:13 +0000 (UTC) Cc: 25552@debbugs.gnu.org, mkupfer@alum.berkeley.edu To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 01 07:12:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d53d2-0007KH-B0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 May 2017 07:12:08 +0200 Original-Received: from localhost ([::1]:46892 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d53d8-00026D-1X for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 May 2017 01:12:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d53d1-00025r-F9 for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 01:12:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d53cw-0000A3-BT for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 01:12:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50200) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d53cw-00009y-8C for bug-gnu-emacs@gnu.org; Mon, 01 May 2017 01:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d53cv-0007mh-T5; Mon, 01 May 2017 01:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Bill Wohler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, mh-e-devel@lists.sourceforge.net Resent-Date: Mon, 01 May 2017 05:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25552 X-GNU-PR-Package: emacs,mh-e X-GNU-PR-Keywords: X-Debbugs-Original-Cc: rgm@gnu.org, mh-e-devel@lists.sourceforge.net, 25552@debbugs.gnu.org, Mike Kupfer Original-Received: via spool by 25552-submit@debbugs.gnu.org id=B25552.149361546529854 (code B ref 25552); Mon, 01 May 2017 05:12:01 +0000 Original-Received: (at 25552) by debbugs.gnu.org; 1 May 2017 05:11:05 +0000 Original-Received: from localhost ([127.0.0.1]:48399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d53c1-0007lS-IM for submit@debbugs.gnu.org; Mon, 01 May 2017 01:11:05 -0400 Original-Received: from ecbiz204.inmotionhosting.com ([173.205.126.39]:29137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d53by-0007ky-T7 for 25552@debbugs.gnu.org; Mon, 01 May 2017 01:11:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=newt.com; s=default; h=Message-ID:Date:Content-Type:MIME-Version:From:References: In-reply-to:Subject:cc:To:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RUJLUr+jhAB3esdCMaL1kbu9W9AujlZ+/1Ayw2TjB/c=; b=EH+JSB75V+sNZbsF/f4jeCJw0o F1gQOogCq1T6V02b441LGrgod9tPWWjClhFCGSAhZcIt4AIAY6ZFEqVjnxdVJhXGGl8aVQm/7a8Bq 3akrLmRGzUFjMSQAyp+RgNk1oMQtXcWQJ0ssak4ND0tlsY3fmA8ejPiSf0eE15KhI0fZ5+WARW2lk 1q25IHzQLq5Fu1geuUFHxInh7ecCuSaS7x0VdeXKFyJPv3C8xzA5UOi1diGRp4YG5zDNO9tlanUsb zp2wU0NdFBozH3r+/IJB243ruoXlPmADYN79QWGRPWO+bZUdYskhEqaAYIr76iqFnRkF2TkwXUJrw 9nsBUcbg==; Original-Received: from c-73-93-110-194.hsd1.ca.comcast.net ([73.93.110.194]:48125 helo=olgas.newt.com) by ecbiz204.inmotionhosting.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1d53bc-002FvT-Ra; Mon, 01 May 2017 01:10:51 -0400 Original-Received: by olgas.newt.com (Postfix, from userid 1000) id 4820D3843FE; Sun, 30 Apr 2017 22:10:40 -0700 (PDT) In-reply-to: Comments: In-reply-to Noam Postavsky message dated "Fri, 14 Apr 2017 10:36:02 -0400." X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.4.1 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png Mail-Followup-To: mh-e-devel@lists.sourceforge.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ecbiz204.inmotionhosting.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - newt.com X-Get-Message-Sender-Via: ecbiz204.inmotionhosting.com: authenticated_id: wohler@newt.com X-Authenticated-Sender: ecbiz204.inmotionhosting.com: wohler@newt.com X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132150 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noam Postavsky wrote: > On Thu, Apr 13, 2017 at 9:30 PM, Mike Kupfer = wrote: > > > >> I thought we had switched to just supporting the current Emacs > >> version, rather than doing a separate MH-E release that supports > >> multiple Emacs versions. > > > > Yes, I've confirmed with Bill Wohler that that's what we're doing. > > > > I'm happy for either you or Glenn to push those patches, but I can do it > > if you prefer (probably next week sometime). > > > > Oh, and to close the loop with some suggestions that Glenn made back in > > February (e.g., use cl-lib instead of cl)... I do plan to look into > > those suggestions, but I don't know how long it will take me. So fixing > > the immediate cl problem now seems to me like a good thing. >=20 > That all sounds fine, push at your convenience, there's no special urgenc= y. I tested what I think we have so far (appended) and haven't noticed anything amiss. Please push what you have at your convenience, as I don't think I see it on master yet. I tried to add eval-and-compile to mailabbrev, but got the following compilation error: mh-e/mh-compat.el:263:1:Error: Symbol=E2=80=99s function definition is = void: mh-require --=20 Bill Wohler aka http://www.newt.com/wohler/ GnuPG ID:610BD9AD --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=mh-e.diff diff --git a/lisp/mh-e/mh-acros.el b/lisp/mh-e/mh-acros.el index 0c89efbe3c..2e778eafb9 100644 --- a/lisp/mh-e/mh-acros.el +++ b/lisp/mh-e/mh-acros.el @@ -81,7 +81,7 @@ mh-do-in-xemacs ;;;###mh-autoload (defmacro mh-funcall-if-exists (function &rest args) "Call FUNCTION with ARGS as parameters if it exists." - (when (fboundp function) + (when (fboundp function) `(when (fboundp ',function) (funcall ',function ,@args)))) @@ -90,10 +90,9 @@ defun-mh "Create function NAME. If FUNCTION exists, then NAME becomes an alias for FUNCTION. Otherwise, create function NAME with ARG-LIST and BODY." - (let ((defined-p (fboundp function))) - (if defined-p - `(defalias ',name ',function) - `(defun ,name ,arg-list ,@body)))) + `(if (fboundp ',function) + (defalias ',name ',function) + (defun ,name ,arg-list ,@body))) (put 'defun-mh 'lisp-indent-function 'defun) (put 'defun-mh 'doc-string-elt 4) diff --git a/lisp/mh-e/mh-compat.el b/lisp/mh-e/mh-compat.el index 3f3990e869..099fc9bbba 100644 --- a/lisp/mh-e/mh-compat.el +++ b/lisp/mh-e/mh-compat.el @@ -40,7 +40,7 @@ ;; Items are listed alphabetically (except for mh-require which is ;; needed sooner it would normally appear). -(require 'mh-acros) +(eval-when-compile (require 'mh-acros)) (mh-do-in-gnu-emacs (defalias 'mh-require 'require)) @@ -374,7 +374,6 @@ mh-write-file-functions (provide 'mh-compat) ;; Local Variables: -;; no-byte-compile: t ;; indent-tabs-mode: nil ;; sentence-end-double-space: nil ;; End: --=-=-=--