unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Gregory Heytings <gregory@heytings.org>
To: Juri Linkov <juri@linkov.net>
Cc: Bob Floyd <bobfloyd@comcast.net>, 47755@debbugs.gnu.org
Subject: bug#47755: 27.1; mouse-yank-at-click fails
Date: Tue, 13 Apr 2021 20:57:20 +0000	[thread overview]
Message-ID: <2725e560cff8ac637900@heytings.org> (raw)
In-Reply-To: <2725e560cf58d8cfd791@heytings.org>

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]


>>>> You should see error "Lisp nesting exceeds `max-lisp-eval-depth`"
>>> 
>>> It's an infinite recursion inside isearch-mouse-2.
>> 
>> This is because let-binding overriding-terminal-local-map to nil
>>
>>  (let ((overriding-terminal-local-map nil))
>>    (key-binding (this-command-keys-vector) t))
>> 
>> doesn't disable its current value anymore.
>
> No, it's because commit 57b14370cd added isearch-mode to 
> minor-mode-map-alist without let-binding it to nil in isearch-mouse-2. 
> Patch attached.
>

Patch attached now ;-)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff; name=Fix-Bug-47755-in-Isearch.patch, Size: 995 bytes --]

From 1146545d7249dcb7e4901ff852e36fc8a4d88abd Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Tue, 13 Apr 2021 20:49:02 +0000
Subject: [PATCH] Fix Bug#47755 in Isearch

* lisp/isearch.el (isearch-mouse-2): Let-bind minor-mode-map-alist
to nil.
---
 lisp/isearch.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/isearch.el b/lisp/isearch.el
index 5efac4c78f..1525913948 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -2561,7 +2561,8 @@ isearch-mouse-2
 is bound to outside of Isearch."
   (interactive "e")
   (let ((w (posn-window (event-start click)))
-        (binding (let ((overriding-terminal-local-map nil))
+        (binding (let ((overriding-terminal-local-map nil)
+                       (minor-mode-map-alist nil))
                    (key-binding (this-command-keys-vector) t))))
     (if (and (window-minibuffer-p w)
 	     (not (minibuffer-window-active-p w))) ; in echo area
-- 
2.30.2


  reply	other threads:[~2021-04-13 20:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 17:57 bug#47755: 27.1; mouse-yank-at-click fails Bob Floyd
2021-04-13 18:11 ` Eli Zaretskii
2021-04-13 18:31   ` Bob Floyd
2021-04-13 19:44   ` Juri Linkov
2021-04-13 20:27     ` Juri Linkov
2021-04-13 20:55     ` Gregory Heytings
2021-04-13 20:57       ` Gregory Heytings [this message]
2021-04-14 16:24         ` Bob Floyd
2021-04-14 18:36       ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2725e560cff8ac637900@heytings.org \
    --to=gregory@heytings.org \
    --cc=47755@debbugs.gnu.org \
    --cc=bobfloyd@comcast.net \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).