From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74413: [PATCH] Allow to store and read repository information of VCS builds Date: Wed, 20 Nov 2024 09:55:22 +0200 Message-ID: <27187.2422121064$1732089392@news.gmane.org> References: <86frnovhg8.fsf@gnu.org> <867c90vbfk.fsf@gnu.org> <861pz8uzyo.fsf@gnu.org> <86zflwtjlz.fsf@gnu.org> <86wmgztfse.fsf@gnu.org> <87ttc3td5x.fsf@thaodan.de> <86frnntalh.fsf@gnu.org> Reply-To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24414"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: luangruo@yahoo.com, 74413@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 20 08:56:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDfZX-00064Z-Rw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Nov 2024 08:56:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDfZF-0000wS-CO; Wed, 20 Nov 2024 02:56:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDfZD-0000vk-Bw for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 02:56:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDfZD-0002BT-46 for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 02:56:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=CWv2UfK8KQH0neyleq4IGbfYX3uG4AtaI/1kSITGWQQ=; b=btV+0U6XHD76JRZpUpZCERWVL1YL8Q9RBAIBAX8LTea5R2X9TnENUfLYHaRiNvFuzQO/FWA6cqx564583ogBVW/gyLncKyIggkQJPrEgd3XveIQUevDn/7I8BsSDxU4nLkKpVIX/4IxT4RnVTo8HYg2P25D/Rtx79oBoWwEQJ8zgc1GZpBOXeICNuj1iiQcOwmI90YQvmOypbHbzi+QM7FStOCGYZVWDbgRJ5ABvvl9kKDGizCLmVF/xOjtMLuGgHRUzfq2ve+4tPpKJK8zcQ65BC10/rMs++HCu5QgRaFzlvdv83hDPHD4JXYl66NLqdvv8FHSRYINvi7UrYn3M+Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDfZC-0005lg-GI for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 02:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2024 07:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74413 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74413-submit@debbugs.gnu.org id=B74413.173208933022129 (code B ref 74413); Wed, 20 Nov 2024 07:56:02 +0000 Original-Received: (at 74413) by debbugs.gnu.org; 20 Nov 2024 07:55:30 +0000 Original-Received: from localhost ([127.0.0.1]:45084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDfYf-0005kq-Ue for submit@debbugs.gnu.org; Wed, 20 Nov 2024 02:55:30 -0500 Original-Received: from thaodan.de ([185.216.177.71]:34018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDfYc-0005kh-Kz for 74413@debbugs.gnu.org; Wed, 20 Nov 2024 02:55:27 -0500 Original-Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 9364AD00077; Wed, 20 Nov 2024 09:55:23 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1732089323; bh=cdVVl/6/OUOV+rGXCjQGA7aPthgruNFN6uRsQpiUBdQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=BBB86yOUVstOh8rAxr65aXgFbfKJWEI1GPAkyb64Yf5mxTsJML/pVY/WtIgRYD7sq ShXakN++6/SpO3VN5aldlBO2QTv0n6LuigRlsmQmQLhQZrvOVwE7rVPYTHxVx6d1ph NlxnlDuB3/JzAhE6/Oi4aFYkutmYV8qfUN59UMpBAqIWWxXKoTNhIRnoYmWlYIQmFe icWww7VtPwnxJSdJJgaHXrzp8HK9xTva43nc6IVPF01ZoEpQkUIjAR/vXkhHrGjhuR 2Ztuxa2FyK2YJYdySKa+zBUfig4pDPz+I7cEVlEzmMuN7iekRnXG8BCXidIASUMKsB M/YI60ag28URbLseSXhfcx0vkUK9Yxyn8VIh/h3SHXcVIbZ7stXF77DOy6sIOYuQ3h +gDI6byESbvvH7aGPjtuy4CzqldSvGFDv49USUUhz1IZXz8+dV+6vsE6tRtDuOflXx pOg7qUVHrj0Xa3qNQSssrs1P1ht0aAsBYJOQxF3cRmd9Xp4dI8O/tL89YRvCTJtWku UoTeibeakeXw6Of7X/f/ktnuKRcnVp75/93/aCj3OcBHM2HBd6bkaTmJBSwEHEGmMw spcesfKCzFk5QK8bVb/ZWXAkpr9pLZCQc4dp7lNheRShR0TyWSMDf1emYDX3Ty4E6Q ujlfAHC8xLPTxuQCoFkCbACE= In-Reply-To: <86frnntalh.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Nov 2024 19:08:42 +0200") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295667 Archived-At: Eli Zaretskii writes: >> From: Bj=C3=B6rn Bidar >> Cc: stefankangas@gmail.com, luangruo@yahoo.com, 74413@debbugs.gnu.org >> Date: Tue, 19 Nov 2024 18:13:14 +0200 >>=20 >> >> If the source is generated by the CI it can also store this informati= on >> >> in the build source which then can be extracted from the ci metadata = to >> >> the Emacs sources on the builder. >> >>=20 >> >> I can be sure that Emacs was built from that revision as much as I can >> >> trust the CI to use the sources I told it to use. If I can't trust on= e, >> >> I can't trust the other. >> > >> > But CI builds from Git, doesn't it? If so, the Emacs it produces >> > already records the revision and the branch. >>=20 >> The source generator, the source service runs git but the builder >> doesn't. >> Because the builder doesn't have to deal with git the rebuild chain is >> smaller, build dependency changes can trigger rebuilds, and the worker >> doesn't have to have git installed. >>=20 >> In most cases it's not required or wanted that worker have git as the >> only allowed purpose would be to get access already existing metadata but >> not change anything on the sources itself. >>=20 >> Providing the metadata to the VCS emacs-repository-branch and >> emacs-repository-version with the previously generated metadata that >> belongs to the package sources removes the need for git in the build wor= ker. > > Thanks, but I still don't understand the problem you are trying to > solve. I guess I'm missing something very fundamental here. You are > talking about "builder", "source generator", "metadata", etc., and I > don't understand these terms. The last sentence seems to confirm my > guess: you tage the Git revision from a repository, and then build > from another directory, which can easily cause a mismatch. It could be that I either assume some things or don't explain them well eno= ugh. I generate a tarball from one repository, store the last commit's refernce = the snapshot of that repository which the tarball was generated from. The configuration of the program that generates the tarball contains the branch it pulls the sources from. Both of these then are put into the the same file that is used by the Android builds. > So this > feature looks completely redundant to me, based on the little I do > understand in these matters. But I will now bow out of this > discussion; if Stefan (and others) think it's okay, I won't object. To reduce any possible I could make the make target shared with the Android builds if that helps. > Thank you for your patience.