From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jacob Faibussowitsch Newsgroups: gmane.emacs.bugs Subject: bug#75226: [31.0.50] C++ ts-mode missing "alignof" as keyword Date: Thu, 2 Jan 2025 09:03:26 -0500 Message-ID: <2707B02F-C5A9-4B7E-A85C-04031CCAD958@gmail.com> References: <7F2C7BC4-F609-4C59-BF1D-BAE12F10CFFE@gmail.com> <86ed1llntt.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_DB09B0DD-1E0E-4057-8721-828DB9E429A4" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5211"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , 75226@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 15:04:16 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTLo7-0001Bw-Tw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 15:04:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTLnx-0003t6-Kx; Thu, 02 Jan 2025 09:04:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTLnw-0003sa-0K for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 09:04:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTLnv-0003cp-OA for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 09:04:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:Date:Mime-Version:From:To:Subject; bh=6LR+xaMEz/mCxQRbWiQUV1w8Qs6Dh3olYvNUW5JqsE0=; b=bKmKrvX+Iez5TJXaqX6JsstdAeJRE1kvxi3pIf0NKZYopfR8BnB952mWT3j0yO1/+nAq2gpJ9VDQACLVTpbXzd4hIldGiCozYocFvCaNOC+3bWmCoi8G481a8QsHGoT6jNqC2P/lVHwaarDLU3KFuP1tUpCy4PV/nJf885B3oM1DmtEqUhTiwC9J3gAsd/M1/mZDmNlX6Wjiu4+a6IL2Cl9imdP5LE9kOCyQFZzidP9jOPLhBOMWk62vyxK6koBvWPUKFD64I34dM/l3jSbSmtOdooPfAJBIoZfzPiGPkUx8b9Pj8x0ZKZBcgDWTeI1C/9lEfGREYnt4QZN+GDBIcw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTLnu-0001pc-KX for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 09:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jacob Faibussowitsch Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75226 X-GNU-PR-Package: emacs Original-Received: via spool by 75226-submit@debbugs.gnu.org id=B75226.17358266216989 (code B ref 75226); Thu, 02 Jan 2025 14:04:02 +0000 Original-Received: (at 75226) by debbugs.gnu.org; 2 Jan 2025 14:03:41 +0000 Original-Received: from localhost ([127.0.0.1]:43250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTLnZ-0001of-1F for submit@debbugs.gnu.org; Thu, 02 Jan 2025 09:03:41 -0500 Original-Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]:61526) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTLnW-0001oV-Fx for 75226@debbugs.gnu.org; Thu, 02 Jan 2025 09:03:39 -0500 Original-Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-6d900c27af7so88939726d6.2 for <75226@debbugs.gnu.org>; Thu, 02 Jan 2025 06:03:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735826618; x=1736431418; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=6LR+xaMEz/mCxQRbWiQUV1w8Qs6Dh3olYvNUW5JqsE0=; b=hZXNk94KLuNkWJ8+Ce8lMiV5Vw+MeXFpFvSrFEuSzHOz6IIF1kdlKMYldRyzYeAPzM KHIG+lL1N9lT08j61i6KasVVauGWDVE7zfYonPK0dqtUdsYQKZMPkZ32hvaJC2autKNd vdpiFb/r80cwQeR4nDpX9K7NMztZHCEIizDgujxfSoMc+AAdYvXI+DEzZ8Ofi2fd4960 z3WmkGdvY3rdjJmqe15outeCPvyzTbIg7+SSZHmpTPuULDtmEl0reU1O+dLcYR8acE6L THY/tvcFmJ14QylA3eukzws7xz3wx8lM/2LPknDJK2XsbHf3jgULrh/rDmfTokjl1VLR FJdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735826618; x=1736431418; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6LR+xaMEz/mCxQRbWiQUV1w8Qs6Dh3olYvNUW5JqsE0=; b=Vf+pcgjAj+pyx7WnrhNwyFu8ecCC9Mnlj/B5Ft4EYB0DoQGGJKPlhOdT8B+alG0smq +bLp//SFejduDdWDQfZxWdQsfL/z+g+bXDNdiyaQKhksASmM/DvRSor6YhvsqBJrOE9q AkdxFc+QL8hdD7xHctthX5hu/pqiXaioZ93+sn4R8pUVKg/PMmkDzvzUfi0x6dKBGLFu 39iyJljvCtNgLqfPuYaWKAfJ9hV1O+LDUvfsgi7K9F83QnI0zHKHgyPTYJjng2SVRW0o C/Y8mfSLShrCkhRqrywerdF2Xig5p5HMgqsxVDzmAOxiS3jLK6CLa2oIWBqyqvrgC0T/ zb3g== X-Forwarded-Encrypted: i=1; AJvYcCWRzSc2YVLrXyDH/FAIC7+V6owH1vGgm7Kl2U/98e27HilRwkzC4IxIox5GKmOJcZSeXutzIA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yyz7ADTu8f1AAh/86k26/dOb9oUaxTAYGnmoQYi703YO1DnJws8 9JKgM/3lo8CZN/5aZusBnG4jcM2o+kd+Z96tn9j7sNkpnLrnVE7o X-Gm-Gg: ASbGncutlrryXYT156cIu5QYmQiLugwd5xhenp38MKg/0rhxwY5h3UOpwpEvi9+BhCj NBnlkfkg5TXXEhwhScrhhaVlLCY4qX0s1SN8UNHcVxx1jp0A8CaRxskGvMequXpgWss2IQs19sW KKJdRdCv5sXiXSOTLbjpnsRqDQmrpZNEe7DdnkrVbaCbX1+CIvfZvvjvJtlSnlcHYKaDXwAMCWH 5qs/A8dHMnIR5tKCRSMvqegpCgWjozel5Wpp6FKhoMAhUCmhbm8CLl2CDU2QQNXJfVCVw== X-Google-Smtp-Source: AGHT+IHlEZRU99qfYILrc7pqVXUdv20d74poZVHV1n6ojdkT9Sx+3dXyO0SVLNZO21ENbZ5adbuoWA== X-Received: by 2002:ad4:5c61:0:b0:6d8:7eb9:9bd7 with SMTP id 6a1803df08f44-6dd233b7865mr650240906d6.43.1735826617676; Thu, 02 Jan 2025 06:03:37 -0800 (PST) Original-Received: from smtpclient.apple ([70.23.89.94]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd1810d4e1sm132227006d6.42.2025.01.02.06.03.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jan 2025 06:03:36 -0800 (PST) In-Reply-To: <86ed1llntt.fsf@gnu.org> X-Mailer: Apple Mail (2.3826.300.87.4.3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298167 Archived-At: --Apple-Mail=_DB09B0DD-1E0E-4057-8721-828DB9E429A4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Should also do `alignas` and friends while you=E2=80=99re at it. I = noticed it is missing from `c-ts-mode--keywords` as well. Best Regards, Jacob Faibussowitsch (Jacob Fai - booss - oh - vitch) > On Jan 2, 2025, at 1:41=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> Cc: 75226@debbugs.gnu.org >> From: Yuan Fu >> Date: Wed, 1 Jan 2025 19:28:35 -0800 >>=20 >>=20 >>=20 >>> On Dec 31, 2024, at 8:01=E2=80=AFAM, Jacob Faibussowitsch = wrote: >>>=20 >>> C++ ts-mode is missing =E2=80=9Calignof=E2=80=9D as a builtin = keyword like sizeof. >>>=20 >>> Best Regards, >>>=20 >>> Jacob Faibussowitsch >>> (Jacob Fai - booss - oh - vitch) >>>=20 >>=20 >> Thanks for reporting this. It seems tree-sitter-c/cpp supports = '__alignof__', '__alignof', '_alignof', 'alignof', =E2=80=98_Alignof=E2=80= =99, I can add all of them as keywords. The feature is added in = tree-sitter-c in Aug 9, 2023 [1], and appears in v0.20.5. >>=20 >> Eli, what=E2=80=99s the status of Emacs 30 right now? Can I push to = emacs-30 and have this change queued for Emacs 30.2? Or should I wait a = bit? >=20 > If this just adds a bunch of strings to c-ts-mode--keywords, it's okay > to add them on emacs-30. >=20 > Thanks. --Apple-Mail=_DB09B0DD-1E0E-4057-8721-828DB9E429A4 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Should also do = `alignas` and friends while you=E2=80=99re at it. I noticed it is = missing from `c-ts-mode--keywords` as well.

Best Regards,

Jacob = Faibussowitsch
(Jacob Fai - booss - oh - vitch)

On Jan 2, 2025, at 1:41=E2=80=AFAM= , Eli Zaretskii <eliz@gnu.org> wrote:

Cc: 75226@debbugs.gnu.org
From: Yuan Fu = <casouri@gmail.com>
Date: Wed, 1 Jan 2025 19:28:35 = -0800



On Dec 31, 2024, at = 8:01=E2=80=AFAM, Jacob Faibussowitsch <jacob.fai@gmail.com> = wrote:

C++ ts-mode is missing =E2=80=9Calignof=E2=80=9D as a = builtin keyword like sizeof.

Best Regards,

Jacob = Faibussowitsch
(Jacob Fai - booss - oh - = vitch)


Thanks for reporting this. It seems = tree-sitter-c/cpp supports '__alignof__', '__alignof', '_alignof', = 'alignof', =E2=80=98_Alignof=E2=80=99, I can add all of them as = keywords. The feature is added in tree-sitter-c in Aug 9, 2023 [1], and = appears in v0.20.5.

Eli, what=E2=80=99s the status of Emacs 30 = right now? Can I push to emacs-30 and have this change queued for Emacs = 30.2? Or should I wait a bit?

If this = just adds a bunch of strings to c-ts-mode--keywords, it's okay
to add them on = emacs-30.

Thanks.

= --Apple-Mail=_DB09B0DD-1E0E-4057-8721-828DB9E429A4--