From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>
Cc: 27238@debbugs.gnu.org
Subject: bug#27238: 24.5; Rename `face-spec-set-2' and give it a better doc string
Date: Sun, 4 Jun 2017 12:38:10 -0700 (PDT) [thread overview]
Message-ID: <26a213b3-908e-43b1-a009-b8a18f0a1c23@default> (raw)
In-Reply-To: <<83wp8ra9g6.fsf@gnu.org>>
> > This is a useful, general function, not just a helper.
>
> FWIW, I don't think it's general enough, because it is tightly couples
> with face-x-resources.
That's only the _implementation_.
(That reasoning would apply also to `face-spec-recalc', `face-spec-set',
`face-set-after-frame-default', `custom-face-set', `custom-face-save',
`custom-face-mark-to-save', `custom-face-reset-saved',
`custom-face-mark-to-reset-standard', `custom-declare-face',
`custom-theme-set-faces', `custom-reset-faces', `woman-default-faces',
...)
Unless you essentially repeat its body, it is the only way
to do what it does. Here's one use case:
(face-spec-set-2 TARGET-FACE
FRAME
(face-spec-choose
(get SOURCE-FACE 'face-defface-spec)
FRAME))
next parent reply other threads:[~2017-06-04 19:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<06a7cc83-a2a8-45a0-97d4-bd3a478aab92@default>
[not found] ` <<83wp8ra9g6.fsf@gnu.org>
2017-06-04 19:38 ` Drew Adams [this message]
2017-06-05 2:27 ` bug#27238: 24.5; Rename `face-spec-set-2' and give it a better doc string Eli Zaretskii
[not found] <<<<<<<06a7cc83-a2a8-45a0-97d4-bd3a478aab92@default>
[not found] ` <<<<<<<83wp8ra9g6.fsf@gnu.org>
[not found] ` <<<<<<26a213b3-908e-43b1-a009-b8a18f0a1c23@default>
[not found] ` <<<<<<83tw3v9njh.fsf@gnu.org>
[not found] ` <<<<<c2f33d90-673d-4f13-894f-a26a52cf1a0d@default>
[not found] ` <<<<<83lgp6a257.fsf@gnu.org>
[not found] ` <<<<139eede5-534a-47ad-805a-bad9995526eb@default>
[not found] ` <<<<83d1ai9yy1.fsf@gnu.org>
[not found] ` <<<2ceee035-593d-4831-be30-06443ba3bc92@default>
[not found] ` <<<83bmq29x63.fsf@gnu.org>
[not found] ` <<a67cb3cf-a77f-4161-babd-eb475e16da95@default>
[not found] ` <<83a85m9sxe.fsf@gnu.org>
2017-06-05 19:36 ` Drew Adams
2017-06-10 8:41 ` Eli Zaretskii
[not found] <<<<<<06a7cc83-a2a8-45a0-97d4-bd3a478aab92@default>
[not found] ` <<<<<<83wp8ra9g6.fsf@gnu.org>
[not found] ` <<<<<26a213b3-908e-43b1-a009-b8a18f0a1c23@default>
[not found] ` <<<<<83tw3v9njh.fsf@gnu.org>
[not found] ` <<<<c2f33d90-673d-4f13-894f-a26a52cf1a0d@default>
[not found] ` <<<<83lgp6a257.fsf@gnu.org>
[not found] ` <<<139eede5-534a-47ad-805a-bad9995526eb@default>
[not found] ` <<<83d1ai9yy1.fsf@gnu.org>
[not found] ` <<2ceee035-593d-4831-be30-06443ba3bc92@default>
[not found] ` <<83bmq29x63.fsf@gnu.org>
2017-06-05 17:56 ` Drew Adams
2017-06-05 18:43 ` Eli Zaretskii
[not found] <<<<<06a7cc83-a2a8-45a0-97d4-bd3a478aab92@default>
[not found] ` <<<<<83wp8ra9g6.fsf@gnu.org>
[not found] ` <<<<26a213b3-908e-43b1-a009-b8a18f0a1c23@default>
[not found] ` <<<<83tw3v9njh.fsf@gnu.org>
[not found] ` <<<c2f33d90-673d-4f13-894f-a26a52cf1a0d@default>
[not found] ` <<<83lgp6a257.fsf@gnu.org>
[not found] ` <<139eede5-534a-47ad-805a-bad9995526eb@default>
[not found] ` <<83d1ai9yy1.fsf@gnu.org>
2017-06-05 16:40 ` Drew Adams
2017-06-05 17:11 ` Eli Zaretskii
[not found] <<<<06a7cc83-a2a8-45a0-97d4-bd3a478aab92@default>
[not found] ` <<<<83wp8ra9g6.fsf@gnu.org>
[not found] ` <<<26a213b3-908e-43b1-a009-b8a18f0a1c23@default>
[not found] ` <<<83tw3v9njh.fsf@gnu.org>
[not found] ` <<c2f33d90-673d-4f13-894f-a26a52cf1a0d@default>
[not found] ` <<83lgp6a257.fsf@gnu.org>
2017-06-05 15:55 ` Drew Adams
2017-06-05 16:33 ` Eli Zaretskii
[not found] <<<06a7cc83-a2a8-45a0-97d4-bd3a478aab92@default>
[not found] ` <<<83wp8ra9g6.fsf@gnu.org>
[not found] ` <<26a213b3-908e-43b1-a009-b8a18f0a1c23@default>
[not found] ` <<83tw3v9njh.fsf@gnu.org>
2017-06-05 5:44 ` Drew Adams
2017-06-05 15:24 ` Eli Zaretskii
2017-06-04 17:42 Drew Adams
2017-06-04 18:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26a213b3-908e-43b1-a009-b8a18f0a1c23@default \
--to=drew.adams@oracle.com \
--cc=27238@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).