From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#74430: 30.0.92; pixel-scroll-precision-mode hiding Eshell prompt after some commands Date: Thu, 21 Nov 2024 10:37:08 -0800 Message-ID: <2689fac8-0a2f-ed4e-b46e-afa4f36ab840@gmail.com> References: <86cyiorh6m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5766"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74430@debbugs.gnu.org To: Eli Zaretskii , Ashton Wiersdorf , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 21 19:39:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEC5K-0001L2-L3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Nov 2024 19:39:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEC51-0005mv-SY; Thu, 21 Nov 2024 13:39:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEC50-0005k1-9t for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2024 13:39:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEC50-0002qu-1B for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2024 13:39:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=QthYWcQuV+pm+Am8780zDI8MYNuEf0vgSWVx0FNNH0c=; b=tHbQc2Rn+3gCqJRthOjw9+Gy/zZLLbIyq/bxFQI462BqZghLA9iRaVqf6eLpwT0PCaEBB8bshJ2vP/aLdss40KpdJf39qqT+Z9NLok2E/coFC0SaZiDKXBwv8NfKg0gPx0y5zajBnbOaQhhAZpc317rFbkPIAkPJBJ9j00eCOuFISfo1HBsKH3b98Dw8uN3v0dYBfj/uWpsmXw4Qg+dnU84MJVczJJD0wzsZOtU498TngdZ/Tbwdl+8e3zOS+xKfb/nnX1kNZ+R4BUjYv0iN9TV34zz5kp4R2fSSXt5y4d/dyw7egdTFBjw0wDiVKC9UL/JO7Q0sP9LujoYUja5mmw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEC4z-0000Oy-Rx for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2024 13:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2024 18:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74430 X-GNU-PR-Package: emacs Original-Received: via spool by 74430-submit@debbugs.gnu.org id=B74430.17322142991479 (code B ref 74430); Thu, 21 Nov 2024 18:39:01 +0000 Original-Received: (at 74430) by debbugs.gnu.org; 21 Nov 2024 18:38:19 +0000 Original-Received: from localhost ([127.0.0.1]:51687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEC4I-0000Nn-Jh for submit@debbugs.gnu.org; Thu, 21 Nov 2024 13:38:18 -0500 Original-Received: from mail-pf1-f179.google.com ([209.85.210.179]:58854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEC4G-0000NX-2K for 74430@debbugs.gnu.org; Thu, 21 Nov 2024 13:38:16 -0500 Original-Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7242f559a9fso1273456b3a.1 for <74430@debbugs.gnu.org>; Thu, 21 Nov 2024 10:38:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732214230; x=1732819030; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=QthYWcQuV+pm+Am8780zDI8MYNuEf0vgSWVx0FNNH0c=; b=H8aTEjIlOdtjQPyWkgf6mDg6yQmTTxAIcqCcbdFEzMzbNjRVFWNcGMh8+9O2yf7qlt LhIayK4pyhN66woMhy4o5Ju+BCmSJ0de1+7MzTRs6GRI/EazPRFcAEMBAmlkwhDjsaVJ fnON3fDFkkts3+IBwLMbkBN/gVeriT6NQBmpNzvuFlL+pZct2FOqrkZuUYOvvxAs5lc8 HK09kZcggUl7AHbSvH6dixJmfhJYuuEQaegNVcChxFDkhTCKDMDrGaFlaQn0Vb0UNggk SSFU6uyAsW2+9QsD8DtM+xDXY+TZJbyx98VHrFke9o+FtXFg8ViGYWPNy6XzYhxjFt8i Bmvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732214230; x=1732819030; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QthYWcQuV+pm+Am8780zDI8MYNuEf0vgSWVx0FNNH0c=; b=lYiicRdDxD2yb9Ncd9lTA6orOU31qsCXaMGV70kLxXaQX9/4C8VpxfysxY+IBecuaO knygLv+ZLW7MHm9LhSt0xI/e5cUofQiEur6mibM8lA/aczk7HlbRE1tiLJHRCYhySMzF Tyuuc5KvvFlLk3+d0y7ghta3NFU+GRYgiKfmcE2mweXMsstHifo24BhNrnf5ZSH0SJhF Wza+ngNlr6QT7aMoXRSzG6reXy/e6rtBB9FfGpqYia0qqDdpMXimXk/VwXkVCFoWjCXt wMovyScOzdhBH44JVXuSN1nDdclQoGJoeZcWesZY/fl5lxdcPItG242D0GEGW75VIPwe KlBA== X-Gm-Message-State: AOJu0YxX5HYqMW15N/gaBuyd04qpTRKFtzOIvshmsU8dbCB8QNvWjRGG pJGd/lcqL2OzBnakm41Ex74N8LChDHtBs9YYHpdfnCd5CflIoNo9 X-Gm-Gg: ASbGncsPneY41E2xuwwYMArFKfUPMtGIO2ldBJYYi9SCsnQza9PjMiQjdet28TY5TAC UqiK0ADQzPyWsyugY7COHQJMnkSLzBRKC3Ycopp033szYlAa6lr990g7s/GBlupCHNAGxUOqOcu IupGWOc9TJJyofJ7+Gfv8pp29p30RWmXkMmwuwDPVE0W7S7+7C2Z9j0OKbGNCYeiGG0GU9ys0pE ZSEwc67rcIlJOX14Cuw9gmj0abX4cXyaEd5D2IPaIdc2xpI5oY1JlXnXN3UWyIBxtOCoD71fJqD gb8D87MnbP1g1KqtroIgp4XBRMU= X-Google-Smtp-Source: AGHT+IGERw8Mej+yB5U6+8QjDdAHJDJTe+P18ACI66koA28/5CeqPCzWA+6tehCF32HaLlHfHPy9+Q== X-Received: by 2002:a17:902:e5d2:b0:20c:7661:dce8 with SMTP id d9443c01a7336-2129f35e9edmr960625ad.36.1732214230099; Thu, 21 Nov 2024 10:37:10 -0800 (PST) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2129dba274csm1500235ad.70.2024.11.21.10.37.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 10:37:09 -0800 (PST) Content-Language: en-US In-Reply-To: <86cyiorh6m.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295740 Archived-At: On 11/21/2024 2:53 AM, Eli Zaretskii wrote: >> From: Ashton Wiersdorf >> Date: Mon, 18 Nov 2024 10:52:27 -0700 >> >> When the command finished, the Eshell prompt was almost entirely >> obscured by the modeline. >> >> The bug does not manifest when I turn off >> `pixel-scroll-precision-mode`. >> It returns when I turn `pixel-scroll-precision-mode` back on. > > Po Lu and Jim, could you look into this, please? I'm only dimly aware of how 'pixel-scroll-precision-mode' works, but I seem to recall that it sets the window's vscroll to allow scrolling past *part* of a line. On the Eshell side, I believe the relevant function is 'eshell-postoutput-scroll-to-bottom', which calls 'recenter' to scroll the window. I'm guessing these interact badly, and what we actually want to do is to reset the vscroll when Eshell calls 'recenter'. However, I'm not sure what the best way to do this would be. Is there some better function Eshell can call that would handle this case correctly?