From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vincenzo Pupillo Newsgroups: gmane.emacs.bugs Subject: bug#73779: 30.0.91; [PATCH] php-ts-mode: Better indentation and font locking, support for the latest grammar version. Date: Sun, 13 Oct 2024 11:19:31 +0200 Message-ID: <26655922.1r3eYUQgxm@fedora> References: <2520493.XAFRqVoOGU@fedora> <86a5f8vbro.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1261"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73779@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 13 11:21:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1szumb-0000A9-QU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Oct 2024 11:21:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szumP-0006Am-8C; Sun, 13 Oct 2024 05:20:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szumN-0006AL-EC for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 05:20:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szumN-0008Rc-5d for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 05:20:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=hNJt2hpDGZszAZbG1+CFL1eAvuHqrHNE2nzzrUTfpco=; b=DuTQNnCnibc8sVdn8YPGWrKmJSY57sb6O7iN41OQbTK6hudLfSk1dJTzbT6xw6RqDc26jybcmYjdCtd1lsPZNbGwDMi/ij4skeYsWvlR/wFT3oKfss1HFhdD9xbB7bHhZNKlkQ8PrB8QelnJb8Pc2eY74hjYoXRX2G4NsfaBplNtqe9PIWSpbK9IYHv3fJPtLyi6mOrsL5RpJu6wQ//xXYTqIpc1o/v7H9fFI7uCUxcAFRw0pparOAolLFIsdAHTiejH+wE6vyvyKq5OUhxuRtqD/JYZ4eQAbdd6vlaiClBt8tX4Hb97uws9jvv8qrft5zGIYTsIHlzyJYkUXiQtjA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1szumc-0005lV-9f for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 05:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vincenzo Pupillo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2024 09:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73779-submit@debbugs.gnu.org id=B73779.172881125022133 (code B ref 73779); Sun, 13 Oct 2024 09:21:02 +0000 Original-Received: (at 73779) by debbugs.gnu.org; 13 Oct 2024 09:20:50 +0000 Original-Received: from localhost ([127.0.0.1]:50193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szumQ-0005ks-DJ for submit@debbugs.gnu.org; Sun, 13 Oct 2024 05:20:50 -0400 Original-Received: from mail-ej1-f41.google.com ([209.85.218.41]:42322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szumP-0005kk-8K for 73779@debbugs.gnu.org; Sun, 13 Oct 2024 05:20:49 -0400 Original-Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a99f629a7aaso113841966b.1 for <73779@debbugs.gnu.org>; Sun, 13 Oct 2024 02:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728811173; x=1729415973; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hNJt2hpDGZszAZbG1+CFL1eAvuHqrHNE2nzzrUTfpco=; b=fVtzj/BDmmfDMchqkT4r2IFL7vbS8aRHgGq5Qg6EuEgIBDh4mkrT+Oe4OO09ROACDi ZrBTlF39yhp/J2U1enQJGgcjSnvvPzvOqUsliKurCN1yoSEpZJPsq4/CS/zST37u763P ufDY8qtylYWnurhgx3KvZcsLZygrVNmMDrRatSeYC1a8Ozxt8ZHGmEO1jWqFDmmCfiFN qBhJs7DwLCyKJYkl+iz4KZCLaK4HV/vVs4yHSHlVI7NhYrtowiRKzCn2kXvYec+0cRtH hZ4Q2H6yFK7fqYwZ/uJ3l6l6w3oh0XfaFbltnFlt6A0ZOI8xEUIZ37BB+NGjHxqlFXBk mULw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728811173; x=1729415973; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hNJt2hpDGZszAZbG1+CFL1eAvuHqrHNE2nzzrUTfpco=; b=Bc3axJDjjjo6IiZd3PhcTZSbxZf7v25B9EjCcDYNN/f69+LFYBpp6fsfVl60TDHQTp WT4bsQ1ZaiDKJw2PuuJG2E2sTkpQQJ7HfBl00ChiBwJT1FluTBu5BaKvhmY+914s7tg9 t7e5iwKDOJqmzIpGLpaekljM3ts0HC8hkwO8vkMrYTs0dghqxm6FjlPKis8sEiifZBVg glr/Zk/t900LousBNFIs5c64aZwyqqBE05MnIaegYnhi46lkkMy4NEHyi3yu8P3TNo81 dCenZj9fJVsOtKT+ijJHPh/PkAhuRfm9gxVKQJ8TqiQAudD4HR0NRINzBLQ6a9eaoc8T GzFA== X-Gm-Message-State: AOJu0YyiQHqfOwNkg6INqLQL6QHbzFrBhou2OrzAQlCWBsfYpl1hR8vg BVc6gPAceeLa5t9jqpls8sQFJHPZyyQdMuv/hzCuTwkAfgbRrK49 X-Google-Smtp-Source: AGHT+IHidBVHuQPtcghZSiUnGvZywScEZK6LJ6Rrt8416joKh4AruXNKZ33RPA4BYkVCrdF56F12rA== X-Received: by 2002:a17:906:6a03:b0:a9a:bec:9dc9 with SMTP id a640c23a62f3a-a9a0bec9fb5mr17989166b.24.1728811172969; Sun, 13 Oct 2024 02:19:32 -0700 (PDT) Original-Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99faa195bfsm104156666b.33.2024.10.13.02.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Oct 2024 02:19:32 -0700 (PDT) In-Reply-To: <86a5f8vbro.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293504 Archived-At: Ciao Eli, > I have two questions about this: > > . will the code which uses the "asymmetric property visibility" also > work without problems with versions of the grammar library before > 0.23.3? Yes, I tested it with older versions of the grammars. 'php-ts-mode--test-visibility-modifier-operation-clause-p' is used to check if this new feature is defined or not, and behaves accordingly. > . do you consider the code changes to be tested well enough and thus > safe to be installed on the emacs-30 release branch? > Yes, I've been using this patch at work for about a week and haven't had any problems. > I'd prefer to install on emacs-30, because this mode is new in Emacs > 30, unless you are not sure the code is safe enough. Thank you. Vincenzo