From: Vincenzo Pupillo <v.pupillo@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 73779@debbugs.gnu.org
Subject: bug#73779: 30.0.91; [PATCH] php-ts-mode: Better indentation and font locking, support for the latest grammar version.
Date: Sun, 13 Oct 2024 11:19:31 +0200 [thread overview]
Message-ID: <26655922.1r3eYUQgxm@fedora> (raw)
In-Reply-To: <86a5f8vbro.fsf@gnu.org>
Ciao Eli,
> I have two questions about this:
>
> . will the code which uses the "asymmetric property visibility" also
> work without problems with versions of the grammar library before
> 0.23.3?
Yes, I tested it with older versions of the grammars.
'php-ts-mode--test-visibility-modifier-operation-clause-p' is used to check if
this new feature is defined or not, and behaves accordingly.
> . do you consider the code changes to be tested well enough and thus
> safe to be installed on the emacs-30 release branch?
>
Yes, I've been using this patch at work for about a week and haven't had any
problems.
> I'd prefer to install on emacs-30, because this mode is new in Emacs
> 30, unless you are not sure the code is safe enough.
Thank you.
Vincenzo
next prev parent reply other threads:[~2024-10-13 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 20:12 bug#73779: 30.0.91; [PATCH] php-ts-mode: Better indentation and font locking, support for the latest grammar version Vincenzo Pupillo
2024-10-13 4:59 ` Eli Zaretskii
2024-10-13 9:19 ` Vincenzo Pupillo [this message]
2024-10-18 6:51 ` Eli Zaretskii
2024-10-19 12:13 ` Vincenzo Pupillo
2024-10-19 13:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26655922.1r3eYUQgxm@fedora \
--to=v.pupillo@gmail.com \
--cc=73779@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).