From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#11795: 24.1.50; wdired: C-c C-c loses marks and positions of renamed files Date: Wed, 27 Jun 2012 07:59:56 -0700 Message-ID: <265F7BD815DD41BDB6F876690A37426E@us.oracle.com> References: <87r4t1sk9o.fsf@web.de> <87sjdhily5@ch.ristopher.com><06AF8E7E174A4F768ADB2B901755EA3C@us.oracle.com> <871ul0bymm@ch.ristopher.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1340809283 24891 80.91.229.3 (27 Jun 2012 15:01:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 27 Jun 2012 15:01:23 +0000 (UTC) To: "'Christopher Schmidt'" , <11795@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 27 17:01:22 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sjtk5-0006x4-8L for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jun 2012 17:01:17 +0200 Original-Received: from localhost ([::1]:54013 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sjtk5-0005CF-45 for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jun 2012 11:01:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sjtjt-0005C7-Qr for bug-gnu-emacs@gnu.org; Wed, 27 Jun 2012 11:01:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sjtjj-0007BO-Tb for bug-gnu-emacs@gnu.org; Wed, 27 Jun 2012 11:01:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sjtjj-0007BJ-Q7 for bug-gnu-emacs@gnu.org; Wed, 27 Jun 2012 11:00:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sjtnh-0000XR-VC for bug-gnu-emacs@gnu.org; Wed, 27 Jun 2012 11:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Jun 2012 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11795 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11795-submit@debbugs.gnu.org id=B11795.13408094502007 (code B ref 11795); Wed, 27 Jun 2012 15:05:01 +0000 Original-Received: (at 11795) by debbugs.gnu.org; 27 Jun 2012 15:04:10 +0000 Original-Received: from localhost ([127.0.0.1]:60518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sjtms-0000WJ-3o for submit@debbugs.gnu.org; Wed, 27 Jun 2012 11:04:10 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:50312) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sjtmo-0000WB-TL for 11795@debbugs.gnu.org; Wed, 27 Jun 2012 11:04:08 -0400 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q5RExwTe008148 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Jun 2012 14:59:59 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q5RExvP7008469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 27 Jun 2012 14:59:58 GMT Original-Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q5RExv55028562; Wed, 27 Jun 2012 09:59:57 -0500 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 27 Jun 2012 07:59:57 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <871ul0bymm@ch.ristopher.com> Thread-Index: Ac1Uc99sjexA3nA8T5ydYNS8/D0cWAAAIlmA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61329 Archived-At: > >> This patch for wdired.el fixes the problem here (GNU Emacs 24.1.1). > > > > But shouldn't Wdired respect the user's setting of option > > `dired-keep-marker-rename'? IOW, shouldn't users be able to control > > whether exiting wdired removes marks? > > Right. Looks OK to me. A question is whether we should bother to invoke `dired-remember-marks' if `dired-keep-marker-rename' is nil. This patch is local to `wdired-finish-edit', which I think is intended to be more or less atomic (a transaction), so I guess the answer is no (a user cannot change the option value during `wdired-finish-edit'). Not calling `dired-remember-marks' if `dired-keep-marker-rename' is nil would save a little time (not important), and I don't think we would lose anything doing that. But it's a question. BTW, I wonder if there isn't some part of `wdired-finish-edit' that should be in an `unwind-protect'. Not thinking of anything in particular - just a feeling...