From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#72824: Eglot highlights matches incorrectly wrt case sensitivity Date: Thu, 29 Aug 2024 00:20:43 +0300 Message-ID: <25f7bdb6-aa71-4ba7-98da-9ac56d23b4f6@gutov.dev> References: <05924929-997f-4d37-ba3b-a4620a687c03@gutov.dev> <7cf49afe-e52f-471c-942d-72a0a39d0905@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25963"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 72824@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 28 23:21:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sjQ6U-0006Up-Bu for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Aug 2024 23:21:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sjQ6H-0004g3-Ia; Wed, 28 Aug 2024 17:21:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sjQ6G-0004fo-1S for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2024 17:21:08 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sjQ6F-0003tG-Ni for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2024 17:21:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=kWMMgKEe+l/rm6tEoD+0waeGQ9Nmqy14yLiWFXCcD+A=; b=hFPHqyf6CoAoMOVbfqa5zXqtN4wQXgqitIGo6JYUR/mNGK72YZM05L7XrD6E2pwbRXXXlztrJm2yAP+1hrhSngAQQ3x2y0nuldaeG/o5KitNcjDsv5s17Irbh29KekPcXrEkGERZhnPkvh9Lp7j+BgnNjodDcvjx3mRw9N3vqqIQwss9HBcu91bKXfQCrt3PMOZSKp0TlrP0v08v75juER3TfSdxGyta07A2yzQIRdBh1y7zWG/M4SM4MgKFBDFKkJ5El2bhlwblF7Z6erjxI0/yA+dL/PLzcQW3NIkJxOYUHIPp5ijwcxXSYvUAcwx6+v+Y3nhjMYmVXV3dLhmFFA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sjQ78-0004ZA-4O for bug-gnu-emacs@gnu.org; Wed, 28 Aug 2024 17:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Aug 2024 21:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72824 X-GNU-PR-Package: emacs Original-Received: via spool by 72824-submit@debbugs.gnu.org id=B72824.172488011217523 (code B ref 72824); Wed, 28 Aug 2024 21:22:02 +0000 Original-Received: (at 72824) by debbugs.gnu.org; 28 Aug 2024 21:21:52 +0000 Original-Received: from localhost ([127.0.0.1]:49817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjQ6y-0004YW-4d for submit@debbugs.gnu.org; Wed, 28 Aug 2024 17:21:52 -0400 Original-Received: from fhigh5-smtp.messagingengine.com ([103.168.172.156]:52247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sjQ6t-0004YE-6R for 72824@debbugs.gnu.org; Wed, 28 Aug 2024 17:21:51 -0400 Original-Received: from phl-compute-07.internal (phl-compute-07.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 61CE21151AA3; Wed, 28 Aug 2024 17:20:47 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Wed, 28 Aug 2024 17:20:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1724880047; x=1724966447; bh=kWMMgKEe+l/rm6tEoD+0waeGQ9Nmqy14yLiWFXCcD+A=; b= HqvSoc7LYSGyjq8VQlbbWe1g3VAHq68Qig3TfuwFN2cibGquzQu3j3LzBu9oybvd w3NzhARQ7VGVn90jFgQWOaBWsyTXNPNsbvENoLRyZASHjuDElBmw+C2im5jF3n6R udS53L8Lcn0q+2XJQBB81klRQNUq7ns/8rIDobwNpd6hcQ5x/pd9p88v/K14EwB+ vCNbCTpNmI3rq7C3ng4WjBbjVXpBi6K2jyTpNVCVNHaUPP09Yiqq6UZXCT5Ke+47 gaEDNWa0TGc+OG/c1cF6rMiqP0b5+yNkZ3oC4BNB/PnuF9/ZXKTIdM0Go02KXClM nel2BRXqeUrWQj1UduARag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1724880047; x= 1724966447; bh=kWMMgKEe+l/rm6tEoD+0waeGQ9Nmqy14yLiWFXCcD+A=; b=e EsgFNEPrMAXKkv3VwvYJwHgzQosZjKzRP/7r5Tb+KVVCIdi256B2wPEZJT0VOFrh 5+sYq17HlLCayntt6HS7CcBCtADuDFwHTL+pqJZ+pmgsELb2dY9qL7ErEr+nxn6F /Vb1wFgyV3vEXEoj3CWuglAqFmg6xr79O6XHxKvh8qR9Zd8uYf510ZM4t/Dy/5b3 Z11Mek25+FFnBYqNFJ6tiORzHe766uJo7xptEIJGfLyw3fFL0ppx4bxjBGNOVygw vhVLV+64/wA9G3NujV9jdYx819F6jlAb2BmvKll14RKcCDVs8zB9xTxx3QCBKeJq WMddmuxLk33jRuO4Z7fBA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudefvddgudehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttddv jeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrd guvghvqeenucggtffrrghtthgvrhhnpeefvdejveeiffefueekleevieekgedttdevieel vefgvdfghfdtgfegfeefgeeigfenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrhih sehguhhtohhvrdguvghvpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuth dprhgtphhtthhopehjohgrohhtrghvohhrrgesghhmrghilhdrtghomhdprhgtphhtthho peejvdekvdegseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 28 Aug 2024 17:20:46 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290886 Archived-At: On 28/08/2024 12:03, João Távora wrote: > On Tue, Aug 27, 2024 at 11:57 PM Dmitry Gutov wrote: > >> This change should help eliminate the inconsistency between parts of the >> current completion style, but for the next release we might migrate to a >> more "passthrough" one. > > What's that? Modulo bugs (one of which you've fixed recently) the "dumb" > is the most passthrough one, except for the completion-ignore-case. > Do you want to remove that? I added it at some user request... seemed > reasonable. Maybe it's not. "dumb" does some filtering in its all-completion call (the predicate arg is used for its return value, AFAICT). A "passthrough" style would only add highlighting but not filter. >> Or not, you know. I've seen users request prefix-only matching instead >> of the fuzzy one provided by the language servers, and I'm sure there >> will be ones who prefer to match case-sensitively only too. > > There is no way to do that. We don't have a say in what the server > gives us. If the user types foo and the server ignores "foobar" and > prefers "farfromsober" or std::foobar for whatever scoring reason, then > there's nothing we can do about it. I suppose that can happen if total completions exceed the cutoff number. > These users are continuously > misinformed about LSP inability to follow Emacs's completion styles, > despite my frequent admonishing. My observation from the sidelines is that people are still happier to have such half-measures available, rather than not: https://github.com/emacs-lsp/lsp-mode/issues/1653#issuecomment-1125055989 It might be a matter of expectations.