From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 35496@debbugs.gnu.org
Subject: bug#35496: 27.0.50; smie-blink-matching-open blinks token before point after RET
Date: Wed, 8 May 2019 12:51:00 +0300 [thread overview]
Message-ID: <25c51540-6c49-ba79-bbb4-e60b1e616fc6@yandex.ru> (raw)
In-Reply-To: <jwvy33hbu5p.fsf-monnier+emacs@gnu.org>
On 08.05.2019 4:44, Stefan Monnier wrote:
>> 1. Disable show-paren-mode if it's enabled.
>> 2. Evalute the attached .el file (which defined a major mode).
>> 3. Create a new bufferand type M-x foo-mode.
>> 4. Type 'def foo do' (without quotes) and press RET.
>> 5. Cursor will hang around on the first line even after the newline
>> is inserted.
>
> It's not a bug, it's a feature: we can't highlight the matching `def`
> when you hit the `o` because we don't know yet whether you actually
> intended to type `do` or a longer identifier, so we postpone the
> blinking to the next char.
But we don't end up blinking to `def` after RET, we blink to `do`.
There must be an opportunity to check that we don't blink to the
preceding token.
> smie-blink-matching-triggers defaults to ?\s and ?\n so the "next char"
> where the blinking can happen is SPC or RET.
>
> Maybe we shouldn't postpone the blinking (i.e. we should add ?o to
> smie-blink-matching-triggers)?
SMIE fills it automatically based on the current set of tokens. If I add
it myself, yeah, the behavior is better in this case. But I kinda buy
your reasoning about not having it there (even though it's not a
panacea: the user can type whatever token, not only ones in the
smie-closer-alist.
Overall, I feel that the smie-blink-matching-inners might be too much as
default anyway. So it's not a big deal if elixir-mode has to disable it.
next prev parent reply other threads:[~2019-05-08 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 20:57 bug#35496: 27.0.50; smie-blink-matching-open blinks token before point after RET Dmitry Gutov
2019-05-07 22:38 ` Dmitry Gutov
2019-05-08 1:44 ` Stefan Monnier
2019-05-08 9:51 ` Dmitry Gutov [this message]
2019-05-08 17:42 ` Stefan Monnier
2019-05-13 0:52 ` Dmitry Gutov
2021-09-22 21:34 ` Lars Ingebrigtsen
2021-09-22 23:12 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25c51540-6c49-ba79-bbb4-e60b1e616fc6@yandex.ru \
--to=dgutov@yandex.ru \
--cc=35496@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).