From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#66431: [PATCH] Fix reset treesit--explorer-last-node when explorer buffer was killed Date: Sat, 14 Oct 2023 10:08:09 -0700 Message-ID: <25E47103-A348-4F93-8968-67D84F06B35D@gmail.com> References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35643"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66431@debbugs.gnu.org To: nvp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 14 19:09:06 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qri8Q-00094s-0l for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Oct 2023 19:09:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qri86-0007J6-U8; Sat, 14 Oct 2023 13:08:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qri85-0007IY-0o for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 13:08:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qri7y-00058e-4D for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 13:08:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qri8L-0002eA-PM for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 13:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2023 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66431 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66431-submit@debbugs.gnu.org id=B66431.169730333410160 (code B ref 66431); Sat, 14 Oct 2023 17:09:01 +0000 Original-Received: (at 66431) by debbugs.gnu.org; 14 Oct 2023 17:08:54 +0000 Original-Received: from localhost ([127.0.0.1]:50337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qri8E-0002do-1k for submit@debbugs.gnu.org; Sat, 14 Oct 2023 13:08:54 -0400 Original-Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:60660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qri8A-0002dW-DT for 66431@debbugs.gnu.org; Sat, 14 Oct 2023 13:08:53 -0400 Original-Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6b6f4c118b7so954843b3a.0 for <66431@debbugs.gnu.org>; Sat, 14 Oct 2023 10:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697303301; x=1697908101; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GvKPropiW1ou3lVays5dJUCwU4Nl1ftb8skQA04p6Xc=; b=BY+JHqeWWsDRCpcqItlsgAtcADK3uJV08W74RObzsnmmTbHspBKqKPMugpdXW4fNLd /Z0YWg4DSd+A4e14NRc3J0JwkIAU/FFPtBV4E2NBag8rVB4tEoY5yA/YV18RbqeRQDsG 3Nsbw05x6A5QUcp6GSJRMWyoYVQVJCWrZ+5dUC+7ouukyWx24AoclLlBJYSEL/3JlKiz 4psIF4IiiPyqcq27XPyEq4RYO3c56qug53K7qI9uSvNPsPXgC72B1mHRvNPgonQnxuaA mmOyGoyYb1ihD+YXmug2+azP6ep3eL7Eq4nEjDWkBbSfjon/9QJhzK7SsUfGEMElGvyO osmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697303301; x=1697908101; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GvKPropiW1ou3lVays5dJUCwU4Nl1ftb8skQA04p6Xc=; b=tVcluNNcxwGJATTIWfCbtE6pz2MEyZnFVRBJC6ThMFgIpfi5OzmYFyyFTvC09NKHw6 m5kKN0PUVHHrHVr96I3s3z4S3UGnRGgT9CmsmLc7XGVqYloqsA6yI0op1pnnt3xFp3IO 8os9YoWnvDcBqyabqICFCwtRKs6ThT87fzAyZPWOmazrhIghZtCjOkTZ3NsOAfMJhHL5 hGvkwv6c2vG6NYkcP47RGdyT0DOXU2vkID90NNXvDNO0IkS+2ufYCG+NC0R1kOxz+dFY dpTXoP6XMhVr4YleitflkDpCgtZWU42vl5WaCThNi40DzCvpsj+vO8F5pzsgmld4gn6P wl6g== X-Gm-Message-State: AOJu0YwYnzv/aCpTVf1iTyXM8mJt/UjdQNt3emwhcdLrR3lQ9+0S2mUs Jp9bKhdCw7iLSC0I7t8gH8g= X-Google-Smtp-Source: AGHT+IFWBBQpojym8Lp2uVqTg5B5UT9JyvpQbSFM/WkK7MJ5OHHStPGIwU/IOFiQgMZBAny8I15zYg== X-Received: by 2002:a05:6a00:1409:b0:68f:dd50:aef8 with SMTP id l9-20020a056a00140900b0068fdd50aef8mr30697041pfu.4.1697303300629; Sat, 14 Oct 2023 10:08:20 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id x24-20020aa79ad8000000b006b341144ad0sm2979319pfp.102.2023.10.14.10.08.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Oct 2023 10:08:20 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272447 Archived-At: > On Oct 9, 2023, at 11:02 PM, nvp wrote: >=20 > Tags: patch >=20 >=20 > Bug: After `treesit-explorer-mode` is enabled in a buffer and its > associated `treesit--explorer-buffer` is killed, a subsequent call > to `treesit-explorer-mode` initially displays an empty explorer > buffer b/c `treesit--explorer-refresh` sees old value for > `treesit--explorer-last-node`. >=20 > * lisp/treesit.el (treesit-explorer-mode): reset > `treesit--explorer-last-node` when `treesit--explorer-buffer` was = killed Hmm, I can=E2=80=99t reproduce what you described. Besides, = treesit--explorer-last-node is only set in the source buffer, not the = explorer buffer. But the patch tries to reset it for the explorer = buffer. Also treesit--explorer-last-node is reset at the end of = treesit-explore-mode. We can start from reliably reproducing the bug you are seeing, and see = what=E2=80=99s the true cause of it. Yuan=