From: John Wiegley <jwiegley@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 6205@debbugs.gnu.org, Kevin Ryde <user42@zip.com.au>,
John Wiegley <johnw@gnu.org>
Subject: bug#6205: 23.1; align.el error deleting a lot of whitespace
Date: Wed, 19 May 2010 05:55:24 -0400 [thread overview]
Message-ID: <25CC99A7-2F8C-4C33-AE6D-530584B78D73@gmail.com> (raw)
In-Reply-To: <jwvsk5osh2b.fsf-monnier+emacs@gnu.org>
On May 18, 2010, at 11:33 PM, Stefan Monnier wrote:
> John, what's your opinion?
> The patch looks OK to me, but at the same time, the code is pretty
> impenetrable from here,
Just be really careful with this change. align.el is extremely sensitive to cursor positions. If it gets enough testing, I'm fine with it.
One thing I used to do to test it back in the day was to run align-code on a very large C file. If the result looked upon visual examination, I was happy.
John
next prev parent reply other threads:[~2010-05-19 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 23:29 bug#6205: 23.1; align.el error deleting a lot of whitespace Kevin Ryde
2010-05-19 3:33 ` Stefan Monnier
2010-05-19 9:55 ` John Wiegley [this message]
2010-06-08 2:01 ` Kevin Ryde
2019-11-23 13:20 ` Lars Ingebrigtsen
2020-08-10 13:06 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25CC99A7-2F8C-4C33-AE6D-530584B78D73@gmail.com \
--to=jwiegley@gmail.com \
--cc=6205@debbugs.gnu.org \
--cc=johnw@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).