From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode Date: Sun, 14 Apr 2024 16:32:43 -0700 Message-ID: <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@gmail.com> References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5174"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Noah Peart , Eli Zaretskii , 70362@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 15 01:34:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rw9MP-00019X-9Q for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Apr 2024 01:34:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rw9M9-00070g-Te; Sun, 14 Apr 2024 19:33:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rw9M7-00070Y-Hi for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 19:33:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rw9M7-0007x0-1v for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 19:33:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rw9MI-00065w-BR for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 19:34:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Apr 2024 23:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70362-submit@debbugs.gnu.org id=B70362.171313759422989 (code B ref 70362); Sun, 14 Apr 2024 23:34:02 +0000 Original-Received: (at 70362) by debbugs.gnu.org; 14 Apr 2024 23:33:14 +0000 Original-Received: from localhost ([127.0.0.1]:36379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rw9LW-0005yi-JH for submit@debbugs.gnu.org; Sun, 14 Apr 2024 19:33:14 -0400 Original-Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:57365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rw9LU-0005xy-Dw for 70362@debbugs.gnu.org; Sun, 14 Apr 2024 19:33:13 -0400 Original-Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1e3f17c6491so21498695ad.2 for <70362@debbugs.gnu.org>; Sun, 14 Apr 2024 16:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713137575; x=1713742375; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=OIdqWkrUzOO57Pt0V2WRkzS1ZmPWYaRg8u1KrtjyyUI=; b=Yc38XQd16eLVDS5h7yinKHmqJx64rqkZV/Yx+tEk3jZR/WtvkH1Dh/+ypAi1mRqw3h wDE/Mlyp8T40bg+7/MtRHwzUCq0WvJkpAJmG37nqA6JVbK50pJ5Q2CBBnOlohOEc4Da5 xeX8tRPH87OM/ebKP4fYE1Pj/BVnJ4RAmOxz1FCwAxVmoaJ9svSL5PmfdduX2WYE5uXz 5INIdEkxfSzLUeFGvpWfNtbt0sBu3595bPM9PYGhNwMdKWI9z/ZwR1wVNWyqEVjezbm8 5FxvOMyCyS2hSfOcVqxnOc/EGd+Jkl8aD4j50ZwrOWNj8xp22+Oj6RyFxbp7DmNCdfLB RuzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713137575; x=1713742375; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OIdqWkrUzOO57Pt0V2WRkzS1ZmPWYaRg8u1KrtjyyUI=; b=cOmTaqcLUJFMJ5brfdw22wzGwMcqiQr79YZTAYi8kc6l5ww8d3DBgsVRfHgw3zQTFF PqZWIb51M4rz+/1iSBNjau434Mm2qnLP/IH4FEuFdhzNnq2FFInY1W41AFYoLy8mLmCY tpM1ou5Zxpmcx4gjGPCTp1eN8Ay7/16TQPjJrfcGoEQhWuMCWxiC/DTSKmtMNwu9SNKT FLOf+Z2s5oMoVd1mV1iSs/9u8fVdaF3r3t0twlfi86jbPIoLXBTR0PR/IY+cOAGS+pE7 RJLeDUTVnwlAByWCFY7tU1TrLSjtEIRwVA0beYduZmiZc8MbAa1AWfEMBOqrga3aELNi fj4Q== X-Forwarded-Encrypted: i=1; AJvYcCWnddDJ+t8jCANf4LpWT1X0GCttwCHQtVh0TLlWi2U+wklsiBikDnZVfq4dDpc10wjDua7pfpQP2Al2oF/E0tUH+Vb4JLQ= X-Gm-Message-State: AOJu0Yw8wPQKWZntRJOUq79q/EIkXAtrOt8pzpG1IGPsPF3WQQ/CC0bk a6l2mWWr4XD11mQXT8oxX7CfA6PE+1kyunR7cuOCL50+u1u6cDXFsHSj6Q== X-Google-Smtp-Source: AGHT+IG1kjwNuY08YtDIG9CX1WxS6kynRkD9ADRSf/+0qyYVL0Bdv9JEnwBNsxEVGYABfSQgqIHNvg== X-Received: by 2002:a17:902:f68e:b0:1e4:a120:14f3 with SMTP id l14-20020a170902f68e00b001e4a12014f3mr7774620plg.51.1713137575213; Sun, 14 Apr 2024 16:32:55 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:641:300:4910:ddd5:ebc3:f048:bab8]) by smtp.gmail.com with ESMTPSA id x5-20020a170902a38500b001e55671bd35sm6623261pla.29.2024.04.14.16.32.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Apr 2024 16:32:54 -0700 (PDT) X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283326 Archived-At: Dmitry Gutov writes: > On 13/04/2024 10:40, Noah Peart wrote: >> I put it at level 3 following the conventions in other treesit modes >> I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put >> builtins at level 3. >> But, I haven't done a full census of the ts modes so there might be >> variability. > > SGTM. If classic major modes highlight a thing (and they do that for > built-ins), we usually put it in the default highlighting for ts modes > as well (meaning level 3 or lower). Right. And the patch looks good to me. Yuan