From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Fri, 20 Aug 2021 19:06:20 +0200 Message-ID: <254C8F2C-423D-4DBE-9836-A92BD63827D7@acm.org> References: <74BC00E9-2509-47DA-9428-1523FF7F3B33@acm.org> <87v942pvcj.fsf@mail.linkov.net> <004A628A-99CC-4C62-8AE2-921C4C38D42A@acm.org> <87h7fkh8z8.fsf@mail.linkov.net> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_C25ECE58-4080-4F19-9312-BF36DA51730B" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3201"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Third , Tak Kunihiro , tkk@misasa.okayama-u.ac.jp, Dmitry Gutov , Lars Ingebrigtsen , 50067@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 20 19:07:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mH7z3-0000fu-Lu for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Aug 2021 19:07:09 +0200 Original-Received: from localhost ([::1]:35846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mH7z2-0001iI-GO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Aug 2021 13:07:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mH7yw-0001iA-Cq for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 13:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52154) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mH7yw-0004K5-5T for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 13:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mH7yv-0001ZH-UQ for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 13:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Aug 2021 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.16294791965992 (code B ref 50067); Fri, 20 Aug 2021 17:07:01 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 20 Aug 2021 17:06:36 +0000 Original-Received: from localhost ([127.0.0.1]:35467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mH7yV-0001Ya-Tz for submit@debbugs.gnu.org; Fri, 20 Aug 2021 13:06:36 -0400 Original-Received: from mail1453c50.megamailservers.eu ([91.136.14.53]:54042 helo=mail266c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mH7yS-0001YH-MU for 50067@debbugs.gnu.org; Fri, 20 Aug 2021 13:06:34 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629479185; bh=wE53CSVU2M6T+n7mKvqwVSzSA1Z4X2uIRj6hvqvA8co=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=O1MjRJsO8rdxvC9bk+AZJvWVLYzOGQKSu/RHjKZ4zqFqdFCFjtaXXNWlzAIdbB7x0 OdEj/d6rMdWEags9XuFCGjZb/5Y/Whh+JXpUNMYpj7duTlcEzvwzfAtvYz7/4EpDFr wlajV3WGfm/MZlah/dfjNQ9PwqReKY3ZS/vxIVss= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail266c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17KH6Li0023014; Fri, 20 Aug 2021 17:06:22 +0000 In-Reply-To: <87h7fkh8z8.fsf@mail.linkov.net> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1D.611FE111.006C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=UeYvt5aN c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=ucMQw-l_AAAA:8 a=TzWVU1kqNxKw69pBDi0A:9 a=CjuIK1q_8ugA:10 a=Fq6NDgnhy04kry1FW4EA:9 a=B2y7HmGcmWMA:10 a=xkTruGkd22MpkFU079mG:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212298 Archived-At: --Apple-Mail=_C25ECE58-4080-4F19-9312-BF36DA51730B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 20 aug. 2021 kl. 09.31 skrev Juri Linkov : > If the existing `xref-backend-identifier-at-point` can't be reused > by adding a new optional arg `click`, then a cleaner solution > would be to add `xref-backend-identifier-at-mouse` indeed. `xref-backend-identifier-at-point` is a generic function implemented by = each backend; a new function appears cleaner. Suggested patch attached! More discoveries and questions: * If I start emacs -Q and enable context-menu-mode, right-clicking on an = identifier in an elisp buffer still doesn't produce the Find Definition = entry, presumably because xref hasn't been loaded. Shouldn't it be = arranged to be autoloaded somehow, which is how xref works when invoked = by keystrokes? * `xref-make-match` requires (contrary to its doc string) its LOCATION = argument to be of type `xref-file-location`, but some backends may only = be able to make an `xref-buffer-location`. Would anyone object to = changing the :location slot of `xref-match-item` to have type = `xref-location`? I don't see how it could hurt. --Apple-Mail=_C25ECE58-4080-4F19-9312-BF36DA51730B Content-Disposition: attachment; filename=0001-Add-Find-References-to-context-menu.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Add-Find-References-to-context-menu.patch" Content-Transfer-Encoding: quoted-printable =46rom=208001c94088d1ee8418001e7fc1875f9cb2ec84f9=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Fri,=2020=20Aug=202021=2018:19:43=20+0200=0A= Subject:=20[PATCH]=20Add=20"Find=20References"=20to=20context=20menu=0A=0A= The=20new=20entry=20appears=20next=20to=20"Find=20Definition"=20and=20= like=20it=20only=0Aappears=20when=20the=20context=20menu=20was=20invoked=20= on=20an=20identifier.=0A=0A*=20lisp/progmodes/prog-mode.el=20= (prog-context-menu):=20New=20menu=20entry.=0A*=20lisp/progmodes/xref.el=20= (xref-find-references-at-mouse):=20New=0Afunction,=20analogous=20to=20= `xref-find-definitions-at-mouse`.=0A---=0A=20lisp/progmodes/prog-mode.el=20= |=2015=20++++++++++++---=0A=20lisp/progmodes/xref.el=20=20=20=20=20=20|=20= 14=20++++++++++++++=0A=202=20files=20changed,=2026=20insertions(+),=203=20= deletions(-)=0A=0Adiff=20--git=20a/lisp/progmodes/prog-mode.el=20= b/lisp/progmodes/prog-mode.el=0Aindex=20a8b608b018..89e2eb54d6=20100644=0A= ---=20a/lisp/progmodes/prog-mode.el=0A+++=20= b/lisp/progmodes/prog-mode.el=0A@@=20-51,14=20+51,23=20@@=20= prog-context-menu=0A=20=20=20=20=20=20=20'(menu-item=20"Find=20= Definition"=20xref-find-definitions-at-mouse=0A=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20:visible=20(save-excursion=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (mouse-set-point=20last-input-event)=0A-=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (xref-backend-identifier-at-point=20(xref-find-backend)))=0A-=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20:help=20"Find=20definition=20= of=20function=20or=20variable")=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (xref-backend-identifier-at-point=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (xref-find-backend)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20:help=20"Find=20definition=20of=20identifier")=0A=20=20=20=20=20=20= =20'prog-separator)=0A+=20=20=20=20(define-key-after=20menu=20= [xref-find-ref]=0A+=20=20=20=20=20=20'(menu-item=20"Find=20References"=20= xref-find-references-at-mouse=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20:visible=20(save-excursion=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(mouse-set-point=20= last-input-event)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(xref-backend-identifier-at-point=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(xref-find-backend)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20:help=20"Find=20references=20to=20identifier")=0A+=20=20= =20=20=20=20'xref-find-def)=0A=20=20=20=20=20(define-key-after=20menu=20= [xref-pop]=0A=20=20=20=20=20=20=20'(menu-item=20"Back=20Definition"=20= xref-pop-marker-stack=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20:visible=20(not=20(xref-marker-stack-empty-p))=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20:help=20"Back=20to=20the=20= position=20of=20the=20last=20search")=0A-=20=20=20=20=20=20= 'xref-find-def))=0A+=20=20=20=20=20=20'xref-find-ref))=0A=20=20=20menu)=0A= =20=0A=20(defvar=20prog-mode-map=0Adiff=20--git=20= a/lisp/progmodes/xref.el=20b/lisp/progmodes/xref.el=0Aindex=20= b6ad485407..254d00e722=20100644=0A---=20a/lisp/progmodes/xref.el=0A+++=20= b/lisp/progmodes/xref.el=0A@@=20-1349,6=20+1349,20=20@@=20= xref-find-definitions-at-mouse=0A=20=20=20=20=20=20=20=20=20= (xref-find-definitions=20identifier)=0A=20=20=20=20=20=20=20(user-error=20= "No=20identifier=20here"))))=0A=20=0A+;;;###autoload=0A+(defun=20= xref-find-references-at-mouse=20(event)=0A+=20=20"Find=20references=20to=20= the=20identifier=20at=20or=20around=20mouse=20click.=0A+This=20command=20= is=20intended=20to=20be=20bound=20to=20a=20mouse=20event."=0A+=20=20= (interactive=20"e")=0A+=20=20(let=20((identifier=0A+=20=20=20=20=20=20=20= =20=20(save-excursion=0A+=20=20=20=20=20=20=20=20=20=20=20= (mouse-set-point=20event)=0A+=20=20=20=20=20=20=20=20=20=20=20= (xref-backend-identifier-at-point=20(xref-find-backend)))))=0A+=20=20=20=20= (if=20identifier=0A+=20=20=20=20=20=20=20=20(let=20= ((xref-prompt-for-identifier=20nil))=0A+=20=20=20=20=20=20=20=20=20=20= (xref-find-references=20identifier))=0A+=20=20=20=20=20=20(user-error=20= "No=20identifier=20here"))))=0A+=0A=20(declare-function=20= apropos-parse-pattern=20"apropos"=20(pattern))=0A=20=0A=20;;;###autoload=0A= --=20=0A2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_C25ECE58-4080-4F19-9312-BF36DA51730B--