From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.bugs Subject: bug#54133: 29.0.50; Buffer-menu-visit-tags-table disrupts non-tags buffers Date: Thu, 24 Feb 2022 13:02:40 -0500 Message-ID: <25111.51264.11851.407727@orion.rgrjr.com> References: <25110.43271.146078.920965@orion.rgrjr.com> <8335k8s3bp.fsf@gnu.org> <25111.49357.417530.307552@orion.rgrjr.com> <83zgmgqhzd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17092"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54133@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 24 19:03:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNIT2-0004Bd-Mo for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Feb 2022 19:03:52 +0100 Original-Received: from localhost ([::1]:39598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNIT1-0006oW-CJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Feb 2022 13:03:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNISO-0006na-7E for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 13:03:12 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNISE-0005RT-8u for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 13:03:11 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNISE-0005MY-1S for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 13:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bob Rogers Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Feb 2022 18:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54133 X-GNU-PR-Package: emacs Original-Received: via spool by 54133-submit@debbugs.gnu.org id=B54133.164572576920595 (code B ref 54133); Thu, 24 Feb 2022 18:03:01 +0000 Original-Received: (at 54133) by debbugs.gnu.org; 24 Feb 2022 18:02:49 +0000 Original-Received: from localhost ([127.0.0.1]:50339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNIS0-0005M7-L9 for submit@debbugs.gnu.org; Thu, 24 Feb 2022 13:02:48 -0500 Original-Received: from mail-qt1-f181.google.com ([209.85.160.181]:40820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNIRy-0005Lt-N2 for 54133@debbugs.gnu.org; Thu, 24 Feb 2022 13:02:47 -0500 Original-Received: by mail-qt1-f181.google.com with SMTP id t28so191134qtc.7 for <54133@debbugs.gnu.org>; Thu, 24 Feb 2022 10:02:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rgrjr-com.20210112.gappssmtp.com; s=20210112; h=from:mime-version:content-transfer-encoding:message-id:date:to:cc :subject:in-reply-to:references; bh=2VZ62R9Yq4w9cpBDcruX6XOjpK0HCrKrsTDrCXTBNQc=; b=WrwYXhgfCOIhBeCaQOpXV+nXWcP+WwgZbqsmwu04rKhmCS/SJoC4ib6sMfjEtCqzxf T6b3r2qGiktgdrOjL2baZCC3RBWNJQR3JDAXL4fV83cH0hbKCqoS6k4O1jtUrpQf7nMA El/y9KE3B0ZSfK+FvnCqDyxP8zs7tlP+/TOZJFVXFkCugWlB8lZYhCC0+UxCogzJVlDl Jk23fKuJigpkFvU3aogTZfvoek4XwsdUL9+VV4ETFQwJ0VHoio3APqgrJoSmCHM2EI84 fulkWgsrlo04DzqZN6Zzb/f/XJikIZ23J/SaCMknGJtzQB59GMfql3iL6ZiiC5Bsy8yo 5y9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references; bh=2VZ62R9Yq4w9cpBDcruX6XOjpK0HCrKrsTDrCXTBNQc=; b=cgrCWXfaL+C+BENSeTD7qt/G1vQamJPLit1n/WtSTUXXP0BZft+Sx/ZEU+qej+APlr FTOaS8QeYHFnXQQvUhHRvCLHbLKTAf0rFdxP2ywpqVrAQgDLIht9BCqe63sYxtVZZ/d4 yenJwvDB9jcxMMyK9Oun/n/KWjgIGjf2JhE4Yy7jFC+8ULREPJNckk7t+RkBogQ5g2Ft rGT9rfRIB1Se2ocyy0crlUKG8xOTEFEXQYD4xZvgFZvoSLmvQoL0ME5aKZOOakJlIXjn pMw+bD2TyDzt4jo05zM4l3F3dRGmylhnZRY1OqY1G+1UJQRDRKEeLZnxbl2wf0pCggwt DaCQ== X-Gm-Message-State: AOAM532lzv3HE5bxTj1s30CC433E4TyzemOOWqbaa7YheBkbvlW44Glz qVIO2sGImy+kvmkF2kbJAibUlc+5+T3xmsQk X-Google-Smtp-Source: ABdhPJynvtCRiut665dBkdcZtGlNM67ntwqfhW0uHkwWMCdnf72/nTKtw7oTx4Lew80V5FS1qaI8dg== X-Received: by 2002:ac8:5bcc:0:b0:2dd:d673:e596 with SMTP id b12-20020ac85bcc000000b002ddd673e596mr3512781qtb.553.1645725761226; Thu, 24 Feb 2022 10:02:41 -0800 (PST) Original-Received: from orion.rgrjr.com ([2601:19c:4600:3270::c]) by smtp.gmail.com with ESMTPSA id h11-20020a05620a21cb00b005089fdd033bsm148674qka.39.2022.02.24.10.02.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 10:02:40 -0800 (PST) In-Reply-To: <83zgmgqhzd.fsf@gnu.org> X-Mailer: VM 7.19 under Emacs 29.0.50 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227593 Archived-At: From: Eli Zaretskii Date: Thu, 24 Feb 2022 19:42:14 +0200 > From: Bob Rogers > Date: Thu, 24 Feb 2022 12:30:53 -0500 > > . . . > > This does ineed work, and I had considered something similar, but > was concerned that it would not be as robust . . . Maybe we should have a more thorough implementation in etags-verify-tags-table, then. But that function's purpose is to do what we need here. That would require disentangling detection and initialization. Which shouldn't be all that hard; it just seemed like more work than necessary to scratch this particular itch. > In short, I thought checking the major mode was the better choice, > since the file was already present in a buffer. But what if the file is already in a buffer, but not under the right major-mode? E.g., what if the file was visited literally? Ah, so you mean that Buffer-menu-visit-tags-table is normally meant to introduce tags-table-mode in buffers not already there. I see now that is implied by "Visit the tags table ..." in the command documentation. In which case I withdraw my reservations. And maybe I'll have a look at cleaning up etags initialization when I get a chance . . . -- Bob