From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.bugs Subject: bug#54133: 29.0.50; Buffer-menu-visit-tags-table disrupts non-tags buffers Date: Thu, 24 Feb 2022 12:30:53 -0500 Message-ID: <25111.49357.417530.307552@orion.rgrjr.com> References: <25110.43271.146078.920965@orion.rgrjr.com> <8335k8s3bp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15220"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54133@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 24 18:32:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNHyW-0003lh-K7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Feb 2022 18:32:20 +0100 Original-Received: from localhost ([::1]:58720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNHyV-0005z8-4d for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Feb 2022 12:32:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNHyJ-0005ye-KI for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 12:32:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNHyD-0000AX-QC for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 12:32:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNHyD-0004Xk-Mn for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 12:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bob Rogers Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Feb 2022 17:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54133 X-GNU-PR-Package: emacs Original-Received: via spool by 54133-submit@debbugs.gnu.org id=B54133.164572386217397 (code B ref 54133); Thu, 24 Feb 2022 17:32:01 +0000 Original-Received: (at 54133) by debbugs.gnu.org; 24 Feb 2022 17:31:02 +0000 Original-Received: from localhost ([127.0.0.1]:50272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNHxG-0004WW-2k for submit@debbugs.gnu.org; Thu, 24 Feb 2022 12:31:02 -0500 Original-Received: from mail-qk1-f181.google.com ([209.85.222.181]:43621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNHxE-0004W2-DA for 54133@debbugs.gnu.org; Thu, 24 Feb 2022 12:31:00 -0500 Original-Received: by mail-qk1-f181.google.com with SMTP id z66so2395746qke.10 for <54133@debbugs.gnu.org>; Thu, 24 Feb 2022 09:31:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rgrjr-com.20210112.gappssmtp.com; s=20210112; h=from:mime-version:content-transfer-encoding:message-id:date:to:cc :subject:in-reply-to:references; bh=ab9rJA4CtRELjo2XTRLyvHNd9vUNHph3XkcirUBWk+w=; b=4pVqVTlR4dJlzGsH96RtZO4YLiP7Fmx47LHpg/G/DiOXNEPmo6/H2Kl6VgovzqjdOv ozeT2UN4coaQm4PwkOguXwC272zIycswWpXdugToupeFf1V6NNwHfzFZOuHVM7/30xqM UF4CK5CawOdim6YzZqc/LRRbR/vSOg1XSdgvUmIgohrxN+Bwqv/kwt2ts3OtL8szR8f9 SHfJGi/tsuBaBuGcmIFsJhD2Ql3tSs6Vnzr0ekkC2fm9VHzLtALO6I5kgci9jTMrqGKV 1l3zyAsw4+0JFb830Vul0spHV928rThtnmBxPY5AB5v/gRH+1vnVk1pze7HbwUZeG8pl V/yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references; bh=ab9rJA4CtRELjo2XTRLyvHNd9vUNHph3XkcirUBWk+w=; b=kmgElyb3QCAnzIg0o1dcbxKpc+9qBVFJyxU6Wd6HblkznxKeTeQtvkW2e+qcVur0Ne 9S9taJ41Z1XR13eTaOTv6EHpeso1LjzHSALY8vTt4Z4ZmtlWRX0NaMDTCt/6gE6QKdwS Ais32PG1Ui0wVhIX/cPn/XHKxovDGZ7KMCdixzG+ObwIuYf+A7c5+ABg82Ncn7kXhJsp SjqYaYHOLlfeMooZR31PE7Z+JsyJPpk0h+wiIS1NWUBbViyqkGJKE9gnArbSswqDyExR UUYOlGXUpIte8HfC8jyzq/h322FhlNWjc26LCfpItQpnogvPs6qpaULEEbKpuqRsNX+z 19YA== X-Gm-Message-State: AOAM530P3cxh5fR2qlCG50QSwI+cm1kNWCR460gizck9UXD8yprVFek6 pBQdfijQcLhQT0fOjVhK3FEBCeopPo/Gru5X X-Google-Smtp-Source: ABdhPJwgdZzXd8E/LxkMWtbiIUVXTBZ+YlrYx3eA48aVLv2z+TTzfr4E5AFGw5tlxnygZb07A35CvA== X-Received: by 2002:a05:620a:148d:b0:47d:8d4b:5070 with SMTP id w13-20020a05620a148d00b0047d8d4b5070mr2429113qkj.726.1645723854757; Thu, 24 Feb 2022 09:30:54 -0800 (PST) Original-Received: from orion.rgrjr.com ([2601:19c:4600:3270::c]) by smtp.gmail.com with ESMTPSA id u12sm2067131qta.76.2022.02.24.09.30.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 09:30:54 -0800 (PST) In-Reply-To: <8335k8s3bp.fsf@gnu.org> X-Mailer: VM 7.19 under Emacs 29.0.50 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227589 Archived-At: From: Eli Zaretskii Date: Thu, 24 Feb 2022 17:15:54 +0200 > From: Bob Rogers > Date: Wed, 23 Feb 2022 16:37:11 -0500 > > . . . > > The real problem is that visit-tags-table assumes that the user knows > what they're doing, and makes these irreversible changes before being > sure of having a valid tags table. That would be a harder thing to fix, > though -- and might not deal as well with my buffer-menu typos. ;-} Does the alternative patch below give good results? This does ineed work, and I had considered something similar, but was concerned that it would not be as robust. etags-verify-tags-table is called from etags-recognize-tags-table, which is only a part of the tags-table-format-functions extension mechanism used by initialize-new-tags-table. So to avoid breaking this mechanism I would either have had to call initialize-new-tags-table and have it possibly set unwanted local variables, or delve more deeply into the internals by running tags-table-format-functions myself. In short, I thought checking the major mode was the better choice, since the file was already present in a buffer. -- Bob