From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Date: Fri, 3 Feb 2023 04:51:04 +0200 Message-ID: <250a9090-8415-9fda-1622-cc9073328fb9@yandex.ru> References: <645D27C7-0376-45F9-A5C9-CD84F9467ED4@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27063"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 61205@debbugs.gnu.org, Theodor Thornhill , Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , randy taylor To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 03 03:52:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNmBP-0006pH-V7 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Feb 2023 03:52:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNmBH-00017p-NS; Thu, 02 Feb 2023 21:52:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNmBG-00017e-En for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 21:52:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNmBG-0003DL-3u for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 21:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNmBF-0006Mr-Pj for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 21:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 02:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs Original-Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167539267624419 (code B ref 61205); Fri, 03 Feb 2023 02:52:01 +0000 Original-Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 02:51:16 +0000 Original-Received: from localhost ([127.0.0.1]:36231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNmAW-0006Ln-6N for submit@debbugs.gnu.org; Thu, 02 Feb 2023 21:51:16 -0500 Original-Received: from mail-ej1-f43.google.com ([209.85.218.43]:41930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNmAS-0006LV-J0 for 61205@debbugs.gnu.org; Thu, 02 Feb 2023 21:51:14 -0500 Original-Received: by mail-ej1-f43.google.com with SMTP id m2so11689594ejb.8 for <61205@debbugs.gnu.org>; Thu, 02 Feb 2023 18:51:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=pHJ/IGDn++00Fll+wqbuNCH7fuHA8UHd2Yu7UA2u0uQ=; b=LYzflvXCVEjUcacSLbe/YDZ0xODxqFn4g/q5eC5rbPHJWYxITs13ii8EoFD6fk/t8x tZaKrk6XxSn8XxApbG8r5GJSSJK8jA6S5ZR24wGyFAE1yCKhxVzzk3E0vtuqADB0q0vM dDdfAzVt2bz0QIy+T16fiXHaOtSO9tk5RBW/sxtyeQu1qNLdlf2cnkV9orWsqlpO4wy0 7m2tn6p4rSAfJvIgLW0LhBAVwJOYZrSsH2eXyf3la5+cFTcfFr8/x9D+PW4/TvQIvBfx JiuTCP2GYlhcJuuDDAkE+q7/cvny0HxNSPIWUTCxJy8F5gsGO0XNQR+H+uKg1NCapBGW EjWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pHJ/IGDn++00Fll+wqbuNCH7fuHA8UHd2Yu7UA2u0uQ=; b=OMoWAfJznJVFH3XREV5X/w/jXN/iu49D9uw89ta7O58LEHx8sMml8lOq00xoLSODf7 C+YJUFO7Mgdgkalx6HT19nz/5IY6udoPP6qQYMkorToZkeNIWLWIh3oIemBOj96QzThy w5CzBwTzLtC6FyZaK5cRPn67NNzzL3lRCobBzi7yZRWrcUcMQs0zdHR+p4o1+ly017iZ 5q7h1PM8HOAv+7VkyD1vmyGOyxVYVZML5boEME2p0Am17UgURzKJg8NI+3vViDPdGy2E uB4y6gJlNhSiwgOVPm5M+BOTf+98ztmnBBnKy6oUkUC49sii5cE9E6pjGfs3Z89mBIUJ Npag== X-Gm-Message-State: AO0yUKWx7y4xlh/KVasuMJOYYlOM2om00ZzR7iT/ryn7Lr5xjHmZJzxt ybqXogQXdbu4MtQY1J557M0= X-Google-Smtp-Source: AK7set/NQ5jBd87D9vMa3jyIiNBNznHat/bM8yegy3wsoadmlMk+7tZ96YkDohXvfVNm+msl325PUg== X-Received: by 2002:a17:906:b7d7:b0:88d:fe1:1aca with SMTP id fy23-20020a170906b7d700b0088d0fe11acamr9172747ejb.34.1675392666620; Thu, 02 Feb 2023 18:51:06 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id cd11-20020a170906b34b00b008720c458bd4sm682785ejb.3.2023.02.02.18.51.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 18:51:05 -0800 (PST) Content-Language: en-US In-Reply-To: <645D27C7-0376-45F9-A5C9-CD84F9467ED4@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254707 Archived-At: On 03/02/2023 04:38, Yuan Fu wrote: > > >> On Feb 2, 2023, at 12:25 PM, Dmitry Gutov wrote: >> >> On 01/02/2023 07:18, Yuan Fu wrote: >>>> On Jan 31, 2023, at 6:08 PM, Dmitry Gutov wrote: >>>> >>>> X-Debbugs-Cc: Yuan Fu, Randy Taylor >>>> >>>> Some new built-in modes has 'function' feature highlighting thus enabled by default. >>>> >>>> rust-ts-mode, go-ts-mode, cmake-mode >>>> >>>> Should we move it to 4 for consistency with the rest? >>>> >>>> Previously, we talked about that and concluded that function calls are usually everywhere and are easy to notice without additional highlighting. >>> Right, I think they should be level 4. >> >> On a related note: 'property' is in level 3 in c-ts-mode. >> >> Should it to go level 4? > > I believe property is level 3. Quoting the (emacs) manual: > > Level 1 > This level usually fontifies only comments and function names in > function definitions. > Level 2 > This level adds fontification of keywords, strings, and data types. > Level 3 > This is the default level; it adds fontification of assignments, > numbers, properties, etc. > Level 4 > This level adds everything else that can be fontified: operators, > delimiters, brackets, other punctuation, function names in function > calls, variables, etc. The manual could be updated. Here's where we seem to have agreed that is should be level 4: https://lists.gnu.org/archive/html/emacs-devel/2022-12/msg01221.html Even that discussion aside, property accesses and function calls seem to be similar enough as syntactic elements (in terms of position, usage, and frequency), so they should probably be on the same level. Don't you think?