From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70622: [PATCH] New window parameter 'cursor-type' Date: Mon, 29 Apr 2024 11:48:07 +0200 Message-ID: <250a655e-58b1-406e-9d3b-28b395e8e243@gmx.at> References: <864jbmuf39.fsf@gnu.org> <8634r5tsit.fsf@gnu.org> Reply-To: martin rudalics Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19412"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 70622@debbugs.gnu.org To: Eli Zaretskii , Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 29 11:49:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s1NdR-0004nt-9S for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Apr 2024 11:49:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1NdF-0000Fg-0U; Mon, 29 Apr 2024 05:49:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1Nd4-0000Dy-9G for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2024 05:48:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s1Nco-0000e9-Qi for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2024 05:48:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s1Nd8-0005bB-MH for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2024 05:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2024 09:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70622 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70622-submit@debbugs.gnu.org id=B70622.171438412021392 (code B ref 70622); Mon, 29 Apr 2024 09:49:02 +0000 Original-Received: (at 70622) by debbugs.gnu.org; 29 Apr 2024 09:48:40 +0000 Original-Received: from localhost ([127.0.0.1]:56229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1Ncl-0005Yw-It for submit@debbugs.gnu.org; Mon, 29 Apr 2024 05:48:39 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:50037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1Ncj-0005YI-Fx for 70622@debbugs.gnu.org; Mon, 29 Apr 2024 05:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1714384089; x=1714988889; i=rudalics@gmx.at; bh=htAUV2Kv5m0/JiodBWlvmF0FK8rxO9uJieuTrMNZPjg=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=jOE2GvahcwdBhtR84nrQssbjiR8BHLxz9mMK1Mi26JjmbtS2VZCw3xu2G9PGaK6g CvKT/O/1uN36H6D1eRjcz/rKU0Ps4KuSsoetWl54HhFyN2t+WXNnDHIeU+lq9ATV0 hTiOqqH/X7i85EgsMTFZcbZSopM5insNHEPq+k0+gPYVKruMgg+WB8B/wsZOCQMXG 32QwiAwvKwleDI2VrsRaCJHuCIi0+zVd82K1HJTTu6XLFEj50nJ6l1BvbK27/JDSD i/+Hp0lieLeNaIraqeEoAF0Ut8MY1dZLzY9MaOX4WjPwnmgx2dVE8710+yBVzW87B tAJxJFOzt5QAqr6eTQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([212.95.5.32]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M3lcJ-1s0Yfa1RyN-001V9R; Mon, 29 Apr 2024 11:48:09 +0200 Content-Language: en-US In-Reply-To: <8634r5tsit.fsf@gnu.org> X-Provags-ID: V03:K1:f4xbDRmQuo6H2ClLK7JG1lZsIK8P2EYZVddPc6UhoSin1oUMa21 wFMcjHpqbTohgOgJ8dN2gCp/AF5Lzv867y6yzfdBFV1KtiZgzUXITIQjsON/6vi8wAL+VCJ in8xvIznC2XjUWCDSYijG+vkbGK6TizZJ+ZgPUbfgzZ5K89Q/X+Cp/tQsrLvZ0S8HEH2aZN VB/0cmGnBAYlkDynTIvsg== UI-OutboundReport: notjunk:1;M01:P0:Aod8NmCeGjA=;0qA4sxzymSmeJIml8KnMncsZFVi hwLNjI/PoLdYxPoWsXZb2tiIkUbTzbTk5SfyhBbqJKyYIRZjruW9siKT5vmQX6sdYpyq5ms46 0jPY9dw3yRXKNCzRWOP9JbUj4e3NgMdvFwyH9b99Hjz8dodTSI8Jb2tbmNnb/P8fxPF0xqoq2 tnR4XBLoJO+THDTaFSOcLesg/Z2lMzsWIfMQ92FPrDFj5PVhmqSUgmjgMk3IZrWLa53kXLyuL 2bawlhp2n2LEr7CT4p/c3i/pT9XSHWWtAOs9COGMVReTEgI/4ModSM+V7cOPzfBNnG5UclPJA BMcoueBvQAyod9VrIzcaeJtY/ropiQhH35vpZf8/nrQrVKjMHAFdQokevSjiY3Rp5n0uck/bm PrkijgsXZAFJdpBco6dgUdwF1PxMZOrdiFvFs3EayX4uXqQzx+N1HZcLcyOg4iiNtzrc/ukwc rMG2nyNI6aeRSi0UqiHrOvMmbk1+FDM2vcbJCqMK6cMSpJpqtRnREmfEFq7wW8sHqo9HRtKTr hVYVbjfx5zpn6FPTjifh6EJBonPEP2rN0t92IeDNh43VHUOLh/k6ZMQQMtLK7bnLTFnwNEAhS npybNvOffOzO/RJ98zSaN1PjupMZJfShMONlBCgSW12BPYR2WXliQ6O2eSUo0JbVdFSZivytr B4xmT0l1hO2N9ddFHrp76FJDQ02GYFa3xDJwjOG/BnPOha0ChQ5sJbV8fX0jZoVUghhgd3ZRP 0w/lNPTbcb2pSrqsrfG6pWBpLjdufPECd3dqUjxMapv7WGGqaDHEXZp3SCMLI/G0GoAIY8pI X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284131 Archived-At: >> WRT cursor-in-non-selected-windows, I think >> there are two viable options: >> >> 1. Give cursor-in-non-selected-windows precedence over the new window >> parameter, and add another window parameter to override >> cursor-in-non-selected-windows. >> 2. Give the new window parameter precedence also over >> cursor-in-non-selected-windows. >> >> In the updated patch, I went with option 2, so if you set the >> cursor-type window parameter, that overrides any buffer-local variable, >> whether or not the window is selected. I think that's sensible enough, >> WDYT? > > I tend to think option 1 is better, but I'm curious what others think. > Martin, WDYT? I'd give 'cursor-in-non-selected-windows' precedence over the new window parameter and not add another window parameter to override it. IIUC that's what a buffer-local value of 'cursor-in-non-selected-windows' currently does to a 'cursor-type' frame parameter. >> Not necessarily. In cases where we want to ensure the cursor is redrawn >> immediately in a non-selected window, we can use force-window-update >> after setting the window parameter. Should that be mentioned in the >> documentation as well? > > I think it would be better to make sure the parameter takes effect > immediately. Documenting the force-window-update thing should be > fallback, if the immediate effect is impossible. I think 'set-window-parameter' should handle 'cursor-type' specially - when it changes, it should set that window's redisplay flag. martin