From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#55628: debug-timer-check fails on macOS 11.6.6 Date: Thu, 26 May 2022 15:15:56 +0200 Message-ID: <2508D80D-E65A-4407-A09C-8E1A2E8E80AF@acm.org> References: <87sfoxdcso.fsf@gnus.org> <015331C8-C4AF-49DB-A859-BE01012B77BF@acm.org> <87D17F2F-BA51-45E3-BD81-A8CF9044C3BE@acm.org> <83sfoxpmff.fsf@gnu.org> <837d68plsk.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_E25A00F3-9D13-4F03-A77C-585DF49FCCA5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25903"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55628@debbugs.gnu.org, Lars Ingebrigtsen To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 26 15:17:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuDMk-0006Ug-Ui for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 May 2022 15:17:27 +0200 Original-Received: from localhost ([::1]:40290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuDMj-0000Xy-GL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 May 2022 09:17:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuDMM-0000XK-TH for bug-gnu-emacs@gnu.org; Thu, 26 May 2022 09:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35286) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuDMM-0006H2-ID for bug-gnu-emacs@gnu.org; Thu, 26 May 2022 09:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuDMM-00041C-DZ for bug-gnu-emacs@gnu.org; Thu, 26 May 2022 09:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 May 2022 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55628 X-GNU-PR-Package: emacs Original-Received: via spool by 55628-submit@debbugs.gnu.org id=B55628.165357097215382 (code B ref 55628); Thu, 26 May 2022 13:17:02 +0000 Original-Received: (at 55628) by debbugs.gnu.org; 26 May 2022 13:16:12 +0000 Original-Received: from localhost ([127.0.0.1]:57416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuDLX-000401-Nu for submit@debbugs.gnu.org; Thu, 26 May 2022 09:16:11 -0400 Original-Received: from mail1440c50.megamailservers.eu ([91.136.14.40]:47026 helo=mail264c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuDLS-0003zJ-MA for 55628@debbugs.gnu.org; Thu, 26 May 2022 09:16:10 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1653570959; bh=594Duc4u6HrMuLG6BJSeMO/4TYBK10WHUy7v6WoMgKM=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=RQ8wgwMUTMLjqw/q83aBQvO/gYsJEyutufPFjsyfu64z+uzc0j+1l4t8kmRQIawPN dC3FoFW2w+w+Zvtzo2BenpDH3Z5eKoMoaac8LwhYLjnrnnU3ulT92cShDix4ggKZuX 43ZDGTtj+Fn1Ca5PDajYYNBvMmfxevM0COcu3/gM= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 24QDFve1012969; Thu, 26 May 2022 13:15:58 +0000 In-Reply-To: <837d68plsk.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F16.628F7D8F.0066, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233110 Archived-At: --Apple-Mail=_E25A00F3-9D13-4F03-A77C-585DF49FCCA5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 26 maj 2022 kl. 13.37 skrev Eli Zaretskii : > Not in principle, but we in this project don't do that. E.g., there > are several debug-related functions and commands in xdisp.c that are > only compiled in under ENABLE_CHECKING. I don't think that not having done it in the past is justification = enough for not doing it now, but I agree that it would be preferable to = have it covered by a test that doesn't need a special interface. It looks like funcall-with-delayed-message could be used for this = purpose. I came up with the attached test, which also has the benefit of = extending test coverage to that function which previously had none. --Apple-Mail=_E25A00F3-9D13-4F03-A77C-585DF49FCCA5 Content-Disposition: attachment; filename=funcall-with-delayed-message-test.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="funcall-with-delayed-message-test.diff" Content-Transfer-Encoding: 7bit diff --git a/test/src/eval-tests.el b/test/src/eval-tests.el index e4230c10ef..1b2ad99360 100644 --- a/test/src/eval-tests.el +++ b/test/src/eval-tests.el @@ -240,4 +240,31 @@ eval-tests/backtrace-in-batch-mode/demoted-errors (should (equal (string-trim (buffer-string)) "Error: (error \"Boo\")"))))) +(ert-deftest eval-tests/funcall-with-delayed-message () + ;; Check that `funcall-with-delayed-message' displays its message before + ;; its function terminates iff the timeout is short enough. + + ;; This also serves as regression test for bug#55628 where a short + ;; timeout was rounded up to the next whole second. + (dolist (params '((0.8 0.4) + (0.1 0.8))) + (let ((timeout (nth 0 params)) + (work-time (nth 1 params))) + (ert-info ((prin1-to-string params) :prefix "params: ") + (with-current-buffer "*Messages*" + (let ((inhibit-read-only t)) + (erase-buffer)) + (let ((stop (+ (float-time) work-time))) + (funcall-with-delayed-message + timeout "timed out" + (lambda () + (while (< (float-time) stop)) + (message "finished")))) + (let ((expected-messages + (if (< timeout work-time) + "timed out\nfinished" + "finished"))) + (should (equal (string-trim (buffer-string)) + expected-messages)))))))) + ;;; eval-tests.el ends here --Apple-Mail=_E25A00F3-9D13-4F03-A77C-585DF49FCCA5--