From: xah lee <xah@xahlee.org>
To: Xavier Maillard <xma@gnu.org>
Cc: bug-gnu-emacs@gnu.org, 1286@emacsbugs.donarmstrong.com,
bug-submit-list@donarmstrong.com
Subject: bug#1286: comment-dwim on a comment line does not toggle comment
Date: Mon, 3 Nov 2008 13:10:24 -0800 [thread overview]
Message-ID: <244A228E-2192-4165-8495-C760C253DE9E@xahlee.org> (raw)
In-Reply-To: <200811031125.mA3BP8eZ024503@zogzog.maillard.mobi>
Xavier Maillard wrote:
«For my point of view, this is well defined here and it behaves just
as described.»
I agree it's well defined and documented. However, i think it is not
intuitive, even people who have used emacs for 3 or more years and
are familiar with its terminologies and behaviors.
when a cursor is on a comment line (whole line is comment) and
there's no active region, i don't see any reason it shouldn't just
uncomment the line when calling comment-dwim. I would say that, any
person, including those using emacs for 3 or more years, who are
using comment-dwim for the first time, would expect it to uncomment it.
is there a reason why it shouldn't uncomment other than “it's that
way for long”?
PS I only started to use comment-dwim in this or last year. In the
past, i've always used string-rectangle and kill-rectangle. I started
to use emacs daily in a day job since 1998, and for the first 7 years
i use it exclusively in terminals.
Xah
∑ http://xahlee.org/
☄
----------------------------------
On Nov 3, 2008, at 3:25 AM, Xavier Maillard wrote:
this appears to be like a bug.
in emacs-lisp-mode, if you have a comment like this:
;; This is a comment
and your cursor is somewhere on that line. Now, do comment-dwim, it
doesn't uncomment the line. It just moves the cursor to the T
in This .
Same behavior in cperl mode and probably all others.
I think this might be by design, but it seems counter-intuitive.
I am sure you read it but just in case:
comment-dwim is an interactive autoloaded Lisp function in
`newcomment.el'.
It is bound to M-;.
(comment-dwim ARG)
Call the comment command you want (Do What I Mean).
If the region is active and `transient-mark-mode' is on, call
`comment-region' (unless it only consists of comments, in which
case it calls `uncomment-region').
Else, if the current line is empty, call `comment-insert-comment-
function'
if it is defined, otherwise insert a comment and indent it.
Else if a prefix ARG is specified, call `comment-kill'.
Else, call `comment-indent'.
You can configure `comment-style' to change the way regions are
commented.
For my point of view, this is well defined here and it behaves
just as described.
-----------------------
next prev parent reply other threads:[~2008-11-03 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <jwvabcknsf4.fsf-monnier+emacsbugreports@gnu.org>
2008-10-31 21:25 ` bug#1286: comment-dwim on a comment line does not toggle comment xah lee
2008-11-01 1:40 ` bug#1286: marked as done (comment-dwim on a comment line does not toggle comment) Emacs bug Tracking System
2008-11-03 11:25 ` bug#1286: comment-dwim on a comment line does not toggle comment Xavier Maillard
2008-11-03 21:10 ` xah lee [this message]
2008-11-04 16:34 ` Stefan Monnier
2008-11-05 7:25 ` Xavier Maillard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=244A228E-2192-4165-8495-C760C253DE9E@xahlee.org \
--to=xah@xahlee.org \
--cc=1286@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
--cc=bug-submit-list@donarmstrong.com \
--cc=xma@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).