From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: thunk2@arcor.de (Thomas Plass) Newsgroups: gmane.emacs.bugs Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling Date: Mon, 10 Aug 2020 19:04:00 +0200 Message-ID: <24369.32256.954408.774614@AGAME7.local> References: <23640.9851.562972.730234@AGAME7.local> <875ztog7hx.fsf@panama> <87wom1otsw.fsf@panama> <87zh7267sy.fsf@gnus.org> <87pn7yo54t.fsf@panama> <83o8ni4fhu.fsf@gnu.org> Reply-To: Thomas Plass Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39399"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 34315@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 10 19:05:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5BEc-000A60-NC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 19:05:18 +0200 Original-Received: from localhost ([::1]:56052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5BEb-0004Ti-OB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 13:05:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5BEP-0004TL-8E for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 13:05:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54093) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5BEM-00025r-Ln for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 13:05:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5BEM-0006xX-H5 for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 13:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: thunk2@arcor.de (Thomas Plass) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Aug 2020 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34315-submit@debbugs.gnu.org id=B34315.159707907526713 (code B ref 34315); Mon, 10 Aug 2020 17:05:02 +0000 Original-Received: (at 34315) by debbugs.gnu.org; 10 Aug 2020 17:04:35 +0000 Original-Received: from localhost ([127.0.0.1]:37406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5BDu-0006wn-SD for submit@debbugs.gnu.org; Mon, 10 Aug 2020 13:04:35 -0400 Original-Received: from mx009.vodafonemail.xion.oxcs.net ([153.92.174.39]:14800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5BDs-0006wY-0K for 34315@debbugs.gnu.org; Mon, 10 Aug 2020 13:04:33 -0400 Original-Received: from vsmx002.vodafonemail.xion.oxcs.net (unknown [192.168.75.192]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTP id 9B24B605259; Mon, 10 Aug 2020 17:04:26 +0000 (UTC) Original-Received: from agame7.arcor.de (unknown [2.205.18.233]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTPA id 02F9460524B; Mon, 10 Aug 2020 17:04:17 +0000 (UTC) In-Reply-To: Your message of Monday, August 10 2020 19:45:01 (ID: <83o8ni4fhu.fsf@gnu.org>). X-VADE-STATUS: LEGIT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184564 Archived-At: Eli Zaretskii wrote at 19:45 on August 10, 2020: : : As for the patch, I've looked at it again now, and I don't think it's : specific to MS-Windows, is it? Exactly, the patch has nothing to do with MS-Windows' DST handling (though incidentally, it was developed while dealing with that issue). It fixes general issues with icalendar.el's handling of timezones as commonly used in ical data and the standard tzurl.org repo. It is also completely backwards-compatible as far as I can make out. Here's the README for the testcases I provided to Ulf along with the patch: This ZIP contains a patch for icalendar.el 0.19 and a set of iCalendar test files. VTIMEZONE sections contained therein were retrieved from http://tzurl.org. - Europe_Berlin-20181103T201500_no_in-calendar_VTIMEZONE.ics no VTIMEZONE, so no TZID references for DTSTART/DTEND, contains non-standard property X-WR-TIMEZONE which is invisible to icalendar.el - Europe_Berlin-20181103T201500_in-calendar_VTIMEZONE_tzurl_standard.ics standard VTIMEZONE ("Outlook-style") - Europe_Berlin-20181103T201500_in-calendar_VTIMEZONE_tzurl_historical.ics comprehensive VTIMEZONE including historical records - America_Creston-20181103T121500_in-calendar_VTIMEZONE_tzurl_standard.ics standard ("Outlook-style") VTIMEZONE - America_Creston-20181103T121500_in-calendar_VTIMEZONE_tzurl_historical_RDATE.ics comprehensive VTIMEZONE including historical records which use RDATE, not RRULE