From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#40967: 27.0.50; vc-diff in indirect buffers Date: Sat, 3 Oct 2020 21:32:28 +0300 Message-ID: <2427bd4f-2523-7232-5678-432d3cc87531@yandex.ru> References: <4a643eda-2b72-857e-4d25-3b9bcbd1e086@yandex.ru> <5f6e0c6c-d699-d9ff-34f6-a8967fc84dfb@orcon.net.nz> <77dd86b8-c5f8-5a91-a424-74feed90b037@yandex.ru> <87d0214ypv.fsf@gnus.org> <87eemfuscg.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10840"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Phil Sainty , 40967@debbugs.gnu.org To: Lars Ingebrigtsen , Nathan Moreau Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 03 20:33:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOmLI-0002iB-4r for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Oct 2020 20:33:12 +0200 Original-Received: from localhost ([::1]:46770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOmLG-0000HB-P6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Oct 2020 14:33:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOmL9-0000Gr-Ns for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 14:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kOmL8-0000kF-GU for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 14:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kOmL8-0001PG-Di for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 14:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Oct 2020 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40967 X-GNU-PR-Package: emacs Original-Received: via spool by 40967-submit@debbugs.gnu.org id=B40967.16017499595374 (code B ref 40967); Sat, 03 Oct 2020 18:33:02 +0000 Original-Received: (at 40967) by debbugs.gnu.org; 3 Oct 2020 18:32:39 +0000 Original-Received: from localhost ([127.0.0.1]:44462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOmKk-0001Ob-Pc for submit@debbugs.gnu.org; Sat, 03 Oct 2020 14:32:39 -0400 Original-Received: from mail-ej1-f49.google.com ([209.85.218.49]:34110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOmKi-0001OP-Tp for 40967@debbugs.gnu.org; Sat, 03 Oct 2020 14:32:37 -0400 Original-Received: by mail-ej1-f49.google.com with SMTP id u8so6195133ejg.1 for <40967@debbugs.gnu.org>; Sat, 03 Oct 2020 11:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VwtSl5NH6OI931D32DLdBO9/r9JagY2JeoD360ilOUc=; b=UobRtqEdrnRAestJNNxZR7AlX/gaP/cNmnmf3o6imiRJhy94wl8D0JrmIyA+feBlkF TMlx4u3v4JeeDGRS09FfqH+7ypqHmzKLB1eC+jy2TclvEtmftwMtziDO5L8FsIsbL0hm qNda8GzDXuIUxmVaZ1sw05ZvSfHiIWQmXP2rRjVNWPeZ+k6E62i3WmQWuullqNYttzap uNKpHHLAwhV4oaE/qO/BKd0dI+429h83QPI97C3oEQ5cvlH3JyYg/b6FfF8QqW5yVvYh kQIuglA35GovoT14tHccrqSlwwf5WHkBnof0ra1wTNvhRnag1VExCquq7hpnbvOYBTTR /iSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VwtSl5NH6OI931D32DLdBO9/r9JagY2JeoD360ilOUc=; b=OAvGIkj5BCvx4+iTKIyEEgkMiQLOtxt67pBxkDYZz/VGcDYr2eIXbdOvqnZycvt9OX nQbongWk7LZ75f57PSzrRvWTEXDaOvFSbTBL/wIIAzV3OtX08copg0X6pDKHaJuDJh2r Y1fTJHJoC07FNqCAIR1h65qXB/sYNI6wp8h13eNuVJdeMvo8d1WGaiAvWATrStKsNWqZ WZu8EDuOKU82VktrBDLqTLJZdxZJNpn8oyoopDY682N6SM331n5d4T2Pqn2JFLeb0M12 uaM2FYqjggbQIGEgReMaQLV9QF4cfvrCMRO4iva5lW7L3K0RzWDOrtFAvtxq++2HzBiC O6Ig== X-Gm-Message-State: AOAM5306QBxrLq04NRuNoS57WhncJDsZr/IhSNO1nDipOhOHxAKw1bgh Zxmb2CCi6+sDiSkhICkgfBgWMUZVr71trQ== X-Google-Smtp-Source: ABdhPJy/MFWITsLr4Ad5nSMtQ1H/OqY3QBCo6HSTzpvQSTskTaRBNA7Q7ozHAJg6IQd8HddPbuG1Qg== X-Received: by 2002:a17:906:a8b:: with SMTP id y11mr7500135ejf.302.1601749950909; Sat, 03 Oct 2020 11:32:30 -0700 (PDT) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id d13sm4817768edu.54.2020.10.03.11.32.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Oct 2020 11:32:30 -0700 (PDT) In-Reply-To: <87eemfuscg.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189720 Archived-At: On 03.10.2020 20:33, Lars Ingebrigtsen wrote: > Nathan Moreau writes: > >> Thanks for having a look. This looks good to me. > > Dmitry, do you have any comments here? The feature makes sense to me > conceptually, but I'm not a domain expert. No objections from me. I'm not a fan of using indirect buffers like this, but if you like the feature, and the patch works well for you, please go ahead.