From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Date: Mon, 25 May 2009 10:42:05 -0700 Message-ID: <2425239E1D3C418886AD82BF7680D4BF@us.oracle.com> References: <87prdynkm5.fsf@cyd.mit.edu><87tz3admt1.fsf@cyd.mit.edu> <4A19F427.40606@gnu.org><874ov9aivv.fsf@cyd.mit.edu><460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> Reply-To: Drew Adams , 3370@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1243289023 14865 80.91.229.12 (25 May 2009 22:03:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 May 2009 22:03:43 +0000 (UTC) Cc: 'Dan Nicolaescu' , 'Chong Yidong' , rms@gnu.org, 3370@emacsbugs.donarmstrong.com To: "'Stefan Monnier'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 26 00:03:35 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M8iGc-000215-18 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 May 2009 00:03:34 +0200 Original-Received: from localhost ([127.0.0.1]:51554 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M8iGb-0003Y3-JU for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 May 2009 18:03:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M8iGX-0003XH-U9 for bug-gnu-emacs@gnu.org; Mon, 25 May 2009 18:03:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M8iGR-0003US-Fa for bug-gnu-emacs@gnu.org; Mon, 25 May 2009 18:03:29 -0400 Original-Received: from [199.232.76.173] (port=33635 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M8iGR-0003UF-6u for bug-gnu-emacs@gnu.org; Mon, 25 May 2009 18:03:23 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:32842) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M8iGQ-0001ra-7m for bug-gnu-emacs@gnu.org; Mon, 25 May 2009 18:03:22 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PLnBmM015386; Mon, 25 May 2009 14:49:14 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n4PLUCiM012128; Mon, 25 May 2009 14:30:12 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 25 May 2009 21:30:12 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3370 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3370-submit@emacsbugs.donarmstrong.com id=B3370.124328675011143 (code B ref 3370); Mon, 25 May 2009 21:30:12 +0000 Original-Received: (at 3370) by emacsbugs.donarmstrong.com; 25 May 2009 21:25:50 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from rgminet14.oracle.com (rcsinet14.oracle.com [148.87.113.126]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4PLPj2c011114 for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 14:25:46 -0700 Original-Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rgminet14.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PHgrbs005149 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <3370@emacsbugs.donarmstrong.com>; Mon, 25 May 2009 17:42:54 GMT Original-Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PHfd3n019090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 25 May 2009 17:41:43 GMT Original-Received: from abhmt008.oracle.com (abhmt008.oracle.com [141.146.116.17]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4PHfoWN029050; Mon, 25 May 2009 17:41:50 GMT Original-Received: from dradamslap1 (/98.210.250.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 25 May 2009 10:41:45 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcndPhZhNNv6jvvgS7+R5iw32iOPRAAHwU2w X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt008.oracle.com [141.146.116.17] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010206.4A1AD85B.0119:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 25 May 2009 18:03:28 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:28152 Archived-At: > Emacs put the comment-starters at column-0 because that code > was written a looooonnng time ago and keeping things simple > was more important than now. Emacs Lisp files still use ;; in column 0 in file headers, AFAICT. What column would you prefer to indent them to? That is exactly the use case here: commenting a line that will be in a file header. There is nothing in the surrounding code that would indicate an indentation level (other than 0 indent). > Emacs-21's new commenting code was improved to be able to > comment and uncomment at other columns than column-0, I have no problem with that. > which made it more useful since most commenting styles use > other indentation styles. No idea what that means. Please define "commenting style" and "indentation style" or otherwise explain what you're trying to say here. > Emacs-21's default (as well as 22) was set to `plain' because Richard > always puts such comments at column-0 (the `plain' setting > had actually to be added specifically for this). Well I don't always put "such comments" (depending on what you mean by that) at column 0. I put `;;' comments where Emacs has always put them: at the same level of indentation that TAB puts code. This is about commenting out a region, however, not about inserting a comment at the current indentation level. Commenting out this line: `abcdef' gives this, prior to Emacs 23: ;; `abcdef' Commenting out the line is different from inserting a comment at the same level: ;; `abcdef' > If you don't like it, just (setq comment-style 'plain) and > live happily ever after. Done (just let-bound in the pertinent code context). That's all I needed. I would prefer, however, to _understand_, by getting some information about `comment-style', `comment-styles', etc. Please document `comment-style' and the rest of what might be missing. Please document this change in NEWS also. Thx.