unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ikumi Keita <ikumi@ikumi.que.jp>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 61210@debbugs.gnu.org
Subject: bug#61210: 28.2; Request to modify code which can accidentally overwrite AUCTeX function
Date: Mon, 20 Mar 2023 21:25:12 +0900	[thread overview]
Message-ID: <24110.1679315112@localhost> (raw)
In-Reply-To: <jwvsfe14s07.fsf-monnier+emacs@gnu.org>

Hi Stefan,

>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
> In Emacs-29 (see commit 18d75b4ab91fef6e344e612580088b714acfdb6e), the
> above `defalias` are now predefined once and for all:

>     ;;;###autoload (defalias 'TeX-mode #'tex-mode)
>     ;;;###autoload (defalias 'plain-TeX-mode #'plain-tex-mode)
>     ;;;###autoload (defalias 'LaTeX-mode #'latex-mode)

> It's still not ideal, but at least  loading `tex-mode` won't override
> any other definition such as AUCTeX's.

Thanks, then AUCTeX can use LaTeX-mode etc. for names of its own major
modes for emacs 29 and later. (I assume that it isn't problematic that
AUCTeX overrides unconditionally them by `autoload' for them in the init
code and
(define-derived-mode LaTeX-mode text-mode "LaTeX" ...)
or
(defun LaTeX-mode () ...)
later.)

> I'd like to hear what you think about this "solution", both in the
> short term and what we could try to do in the longer term (e.g. I'd
> like to aim to get rid of those defaliases, but I'm not sure how to
> get there progressively.

I see that `major-mode-remap-alist' was also incorporated into emacs-29.
So in short term, the conflicts between built-in modes and AUCTeX modes
will reduce, and disappear when the least supported emacs version is
raised to emacs-29.
In the longer term, I think there's no practical problem regardless
of existence of those aliases.
1. If they persist, AUCTeX changes the doc string for LaTeX-mode etc.
   in a brutal manner, but most ordinary users won't mind it. (Maybe it
   increases difficulty a bit in debug process? But I expect that
   drawback is small enough.)
2. The only reason that built-in tex-mode.el needs those aliases is, as
   you wrote in tex-mode.el, "for those users who may have files
   annotated with -*- LaTeX -*- (e.g. because they received them from
   someone using AUCTeX)." They can install AUCTeX even when those
   aliases are erased.

Best regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine





  reply	other threads:[~2023-03-20 12:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01 12:13 bug#61210: 28.2; Request to modify code which can accidentally overwrite AUCTeX function Ikumi Keita
2023-03-18 22:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-20 12:25   ` Ikumi Keita [this message]
2023-03-20 15:07     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-20 17:44       ` Ikumi Keita
2023-09-05 23:29         ` Stefan Kangas
2023-09-06  6:08           ` Ikumi Keita
2023-09-06  8:02             ` Stefan Kangas
2023-09-12 21:50             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24110.1679315112@localhost \
    --to=ikumi@ikumi.que.jp \
    --cc=61210@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).