From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#36644: Git log search Date: Tue, 16 Jul 2019 17:25:39 +0300 Message-ID: <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="99816"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 Cc: 36644@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 16 16:26:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hnOPH-000Pju-7Q for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Jul 2019 16:26:15 +0200 Original-Received: from localhost ([::1]:49554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnOP9-0006wR-C7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Jul 2019 10:26:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41102) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnOP5-0006ul-Sp for bug-gnu-emacs@gnu.org; Tue, 16 Jul 2019 10:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnOP4-0004gT-UI for bug-gnu-emacs@gnu.org; Tue, 16 Jul 2019 10:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42129) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hnOP4-0004gJ-Q1 for bug-gnu-emacs@gnu.org; Tue, 16 Jul 2019 10:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hnOP4-0002EA-Kg for bug-gnu-emacs@gnu.org; Tue, 16 Jul 2019 10:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jul 2019 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs Original-Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15632871508537 (code B ref 36644); Tue, 16 Jul 2019 14:26:02 +0000 Original-Received: (at 36644) by debbugs.gnu.org; 16 Jul 2019 14:25:50 +0000 Original-Received: from localhost ([127.0.0.1]:50949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnOOs-0002Dd-FM for submit@debbugs.gnu.org; Tue, 16 Jul 2019 10:25:50 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:38015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnOOq-0002DK-2r for 36644@debbugs.gnu.org; Tue, 16 Jul 2019 10:25:48 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id g17so21198128wrr.5 for <36644@debbugs.gnu.org>; Tue, 16 Jul 2019 07:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DWMW/w5hpPeXRYxYvGJaAX44mUetuocd3MHYAVLJSJ4=; b=rumER4ofi39SPoeON+EcyP6/DpwgXA2OBcjpXAmXqN0Bcxyb8CzXPL5OivawYt/m0s +16F+nJ7GcUw540PcDtrEVoD2PXn1/Sj7QeGjZ7GzsCQGfpgXQdeQWelsOUz5U5b2sxJ P69Sq0B30MM+JMBuuVerc0RNLup3UEIu9/IuAPYG0gXocAEZ8XysRWM8M71kvmvZ5Rg/ X3csKk4JQss23WnoSs+BWyXD0oauRHEBTNNBuTUI7utv91IGhSH9pEXyL58EaQ1YHD8v K0Ief8yfUiHmccs0qbGc5K8xcO+cuN8Xzv3vslvni4zb9vci9q/8MDlXTVFHmiAMylfo kBYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DWMW/w5hpPeXRYxYvGJaAX44mUetuocd3MHYAVLJSJ4=; b=qqLI7Dgw7knGzkM64t35ZCOIPlG7wmi6+G/Rk+39129pBxtBu/A8nWwsmhpfX/W7PR iWKT02n2e+uWsy7Vbkl+HseSctEKwYBVS1H/fySvDbvmO/iDgPEPCtuEoqOAYsDNIxrC AJYQEJ4vMAW2pAzrnxpVwRy0B/I5aapxRMrgKX0W6bSTJ30wpVpOkzA4japa8ss/VPp+ fjuwgHt7O+3nKRnZ2RC5a/e4f51YJ/kGB5i+HltfjDEd+DwvWAioAGa6GETM1ZYRMcl3 O7nRnXso69Vr63lbPQXGzlxBedM8WiG/uH7xvZFbdr1bx3aC8UhIOzLFSs+tEgQ6JWqH F0Uw== X-Gm-Message-State: APjAAAVrxkQDSKGBKFaMH7h0CLhFH5Ivbjd5Ppd9QyGg0TI356d3gE0T WXM8FDG4gUGx5fyfOp1Uq7eiRLHe X-Google-Smtp-Source: APXvYqwubet5xYDJIiHRgLBW3s1eOrmRWjvyRQIbG1cHgS5f0MiQtojPZ46vYm3TvJtsxvYmcKcWMw== X-Received: by 2002:a5d:56c7:: with SMTP id m7mr36733519wrw.64.1563287141946; Tue, 16 Jul 2019 07:25:41 -0700 (PDT) Original-Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id n9sm37477157wrp.54.2019.07.16.07.25.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jul 2019 07:25:41 -0700 (PDT) In-Reply-To: <87blxvj5lv.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163193 Archived-At: On 16.07.2019 1:27, Juri Linkov wrote: > Thanks for the review. Installed to master after fixing > according to your comments. Thanks. >>> +;; - log-search (pattern) >>> +;; >>> +;; Search for PATTERN in the revision log. >> >> Is pattern a regexp or a verbatim string? That should be documented. > > Fixed to use string. Since --grep expects a regexp, shouldn't PATTERN be passed through regexp-quote as well? Though it expects Emacs regexps, so it doesn't quote parens or pipes. >> Git supports regexps, but maybe we should look at what other backends >> can support as well. > > It seems the most compatible type is string. OK, if that is your conclusion. >> I wonder if the format of the output should be specified as well. >> E.g. by saying that it's the same as for print-log, long version. > > Fixed by saying it's long version. > > Should it support short format as well? I don't know. How would it be used? > Should it have a key binding? > > For example, `vc-log-incoming' is bound to `C-x v I', > `vc-log-outgoing' is bound to key `C-x v O', so logically > `vc-log-search' would be bound to `C-x v s', but unfortunately > it's already taken by `vc-create-tag'. 'C-x v S', then?