From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java. Date: Fri, 3 Mar 2023 14:32:02 -0800 Message-ID: <23F92D53-993F-43D6-8A22-00F7AAE10505@gmail.com> References: <3399763.44csPzL39Z@3-191.divsi.unimi.it> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14634"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 61913@debbugs.gnu.org To: Vincenzo Pupillo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 03 23:33:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYDxg-0003Zx-EO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Mar 2023 23:33:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYDxX-00012W-Mm; Fri, 03 Mar 2023 17:33:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYDxW-00012A-Q6 for bug-gnu-emacs@gnu.org; Fri, 03 Mar 2023 17:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYDxW-0000N2-Ct for bug-gnu-emacs@gnu.org; Fri, 03 Mar 2023 17:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYDxW-000081-8k for bug-gnu-emacs@gnu.org; Fri, 03 Mar 2023 17:33:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <3399763.44csPzL39Z@3-191.divsi.unimi.it> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Mar 2023 22:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61913 X-GNU-PR-Package: emacs Original-Received: via spool by 61913-submit@debbugs.gnu.org id=B61913.1677882741435 (code B ref 61913); Fri, 03 Mar 2023 22:33:02 +0000 Original-Received: (at 61913) by debbugs.gnu.org; 3 Mar 2023 22:32:21 +0000 Original-Received: from localhost ([127.0.0.1]:34123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYDwr-00006w-Ik for submit@debbugs.gnu.org; Fri, 03 Mar 2023 17:32:21 -0500 Original-Received: from mail-pj1-f54.google.com ([209.85.216.54]:46717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYDwq-00006f-1w for 61913@debbugs.gnu.org; Fri, 03 Mar 2023 17:32:20 -0500 Original-Received: by mail-pj1-f54.google.com with SMTP id q31-20020a17090a17a200b0023750b69614so3703893pja.5 for <61913@debbugs.gnu.org>; Fri, 03 Mar 2023 14:32:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677882734; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=1myuNm6gv4aFUKAZnsvYISmkNpRJelFl1fF3v1LtG24=; b=ijRDDEND4Oxc5SW7mhokJ8jqj4eVKkyJNGa6u188gu970AU8039++2Hn6zam6+iFes PpnI2zJMGxMacpDSivHssP8KpcCapB06CErtZU++MnUBt7XejGJlRZ2bGK99xkoIzzsN APqaXNGbJByfUKGqAzDN27pMB7vYlA+QUztIoMvpE2J6BJzSUjJ8m6EtHSE0Hn28gepW WcFZ+UKpQr74Vc+5Oe41o4pHEmD4cgXRMZm3IThEckTpnMWfNAotyADCoLA55BpXr+QX TyemEvTAEHKAK4okt5YB/eXkLQ/YAQDOyl8GII0DfZ37V7sKftESzPJQqP+UjnJFQWf5 2OFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677882734; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1myuNm6gv4aFUKAZnsvYISmkNpRJelFl1fF3v1LtG24=; b=moFKZyanXMsr69lLprv73NR4p6L/MCdVMoSmC049oOfaZXI6WZQxiQ5EUvN3Y+aWDV IQzJPjsKzeUnc6Mh+AThv7m64XM4iy6wnwNcdcv6gycDMJSggkB2uAYhPIwTwN0ZHh1B bqPLNiXfCM5occ7PQ4QjBSkiryqs6pm4pE6qYW851VAX+LKfqpo1L5SsuchqTku/YQrH BeHWQFd8WGZ5N/O31f+vilYHd3yOODDHRFmoLloCbp2csmWJlxw4IhuXDNadMmq6KYZ1 g2Tc5TCx3ssx/+WbmWaUKDK9nOpG6CSdEmAOfNcBhGedC3WRVnSLeETK2I0RQjRsGQBz zl7Q== X-Gm-Message-State: AO0yUKUOFZDVrNRK2N0rydaF1mgca1Fb1jfugXhbNhKEezBBQ6hTNHNu 6iEMeV7+T+99cPQ57jil4V3n7JVQKokQkA== X-Google-Smtp-Source: AK7set/y1KEw/bFcFtlTtNDdwg/b4n7JENONhrmMBeboiugk3Ji6X+NThlg9XKgc9jHaWoSpthy1kg== X-Received: by 2002:a17:90a:4146:b0:233:f393:f6cd with SMTP id m6-20020a17090a414600b00233f393f6cdmr3368546pjg.5.1677882734189; Fri, 03 Mar 2023 14:32:14 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id lx3-20020a17090b4b0300b00233bc4edb77sm3882525pjb.25.2023.03.03.14.32.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Mar 2023 14:32:13 -0800 (PST) X-Mailer: Apple Mail (2.3731.400.51.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257237 Archived-At: Vincenzo Pupillo writes: > Yes, indeed "text_block" are not recognized by earlier versions of = tree-sitter-java.=20 > I have prepared a new patch that checks if "text_block" are recognized = and adjusts the query accordingly. > > Also java-mode seems not to recognize "text_block". > You can check the result in the attached images. > > Thank you. > > Vincenzo > > In data gioved=EF=BF=BD 2 marzo 2023 14:01:56 CET, Eli Zaretskii ha = scritto: >> > From: Vincenzo Pupillo >> > Date: Thu, 02 Mar 2023 13:21:05 +0100 >> >=20 >> > a recent commit in tree-sitter-java = (https://github.com/tree-sitter/tree-sitter-java/commit/2b3b776b953a34ccff= b647dd89732db79690d4c5)=20 >> > removed "text_block" from grammar.js. This causes a bug in = java-ts-mode when treesit-fon-lock-level is > 1 >> >=20 >> > Error during redeployment: (jit-lock-function 8295) reported >> > (treesit-query-error "Node type error at" 42 "(string_literal) >> > @font-lock-string-face (text_block) @font-lock-string-face" >> > "Debugging the query with `treesit-query-validate'") >> >=20 >> >=20 >> > The attached patch fixes the problem.=20 >>=20 >> Wouldn't removing text_block from our code cause problems if someone >> uses tree-sitter-java from before the removal? >>=20 >> Is there a way to write code which handles text_block if it exists? >>=20 Tree-sitter language grammars really need some versioning system. I wonder how do we propose such things to them tho... Yuan