From: "Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 70352@debbugs.gnu.org
Cc: yang.yingchao@qq.com, luangruo@yahoo.com, eliz@gnu.org
Subject: bug#70352: Fwd: Re: bug#70352: 29.3.50; emacs-pgtk: possible leak of virtual memory
Date: Fri, 10 May 2024 23:34:55 +0300 [thread overview]
Message-ID: <23675.0776109815$1715373412@news.gmane.org> (raw)
In-Reply-To: <87wmogcrxc.fsf@yahoo.com> (Po Lu via's message of "Mon, 29 Apr 2024 19:46:39 +0800")
Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@gnu.org> writes:
> Yang Yingchao <yang.yingchao@qq.com> writes:
>
>> Could this be an issue with gtk+? I made some changes to gtk+-3.24.41,
>> and it seems like the issue has disappeared...
>
> I don't understand. Aren't you building with GTK 4.x?
>
>> ,----
>> | diff -urNa gtk+-3.24.41.orig/gdk/wayland/gdkwindow-wayland.c gtk+-3.24.41/gdk/wayland/gdkwindow-wayland.c
>> | --- gtk+-3.24.41.orig/gdk/wayland/gdkwindow-wayland.c 2024-01-24 09:14:34.000000000 +0800
>> | +++ gtk+-3.24.41/gdk/wayland/gdkwindow-wayland.c 2024-04-29 16:41:00.691373426 +0800
>> | @@ -952,6 +952,11 @@
>> | /* Release came in, we haven't done any interim updates, so we can just use
>> | * the old committed buffer again.
>> | */
>> | +
>> | + if (impl->staging_cairo_surface) {
>> | + g_clear_pointer (&impl->staging_cairo_surface, cairo_surface_destroy);
>> | + }
>> | +
>> | impl->staging_cairo_surface = g_steal_pointer (&impl->committed_cairo_surface);
>> | }
>> `----
>>
>> Actually, I do not understand the logic of the function
>> `buffer_release_callback()', but when debugging this issue with gdb, I
>> noticed that the `impl->staging_cairo_surface' which was created via
>> `_gdk_wayland_display_create_shm_surface' was replaced by
>> `impl->committed_cairo_surface' without being released first.
>
> I'm afraid the GDK Wayland backend is outside my line of country.
> Perhaps you ought to take this up with their developers, but be prepared
> for weeks of frustration as they presume to tell you how your program
> should bend over backwards to accommodate their misdesigns.
Doesn't seem to go that bad this time:
https://gitlab.gnome.org/GNOME/gtk/-/issues/6675
Luckily mentioning Emacs did not cause any issues.
next prev parent reply other threads:[~2024-05-10 20:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 10:56 bug#70352: 29.3.50; emacs-pgtk: possible leak of virtual memory Yang Yingchao via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-13 1:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-13 7:15 ` Eli Zaretskii
2024-04-13 10:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-13 12:02 ` Eli Zaretskii
2024-04-14 0:11 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87sezozttr.fsf@>
2024-04-14 0:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-14 5:48 ` Eli Zaretskii
2024-04-14 6:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-14 7:31 ` Eli Zaretskii
[not found] ` <699acc927ca7decaaac0d06a59c80426bb9ae3059c3eebd7cced56cb021310bf@mu.id>
[not found] ` <871q7argry.fsf@qq.com>
2024-04-15 1:36 ` bug#70352: Fwd: " Yang Yingchao via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <db6105b7ec2a3d0db0d1741e43bea07e1ca0a8e2e7f360933771f524e9266d13@mu.id>
2024-04-15 1:58 ` Yang Yingchao via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87wmoz75g4.fsf@qq.com>
2024-04-17 7:30 ` Yang Yingchao via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-27 8:32 ` Eli Zaretskii
2024-04-29 8:45 ` Yang Yingchao via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-29 11:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-29 12:27 ` Yang Yingchao via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-09 7:35 ` Eli Zaretskii
2024-05-10 0:00 ` Yang Yingchao via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-10 6:34 ` Eli Zaretskii
2024-05-10 20:34 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-10 20:34 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
[not found] ` <87h6f5h0cw.fsf@>
2024-05-11 0:23 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-14 3:05 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='23675.0776109815$1715373412@news.gmane.org' \
--to=bug-gnu-emacs@gnu.org \
--cc=70352@debbugs.gnu.org \
--cc=bjorn.bidar@thaodan.de \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
--cc=yang.yingchao@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).