From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#47244: 28.0.50; SIGSEGV in long-runnning Emacs Date: Wed, 7 Apr 2021 11:00:36 +0200 Message-ID: <233daa4b-ca64-955f-2612-49a0503b1938@gmx.at> References: <87im5ofp3z.fsf@md5i.com> <834kgrifrt.fsf@gnu.org> <106ce987-1a45-bbdf-3897-445baa99a476@gmx.at> <745cb501-d742-8797-d07c-00125f60f8ec@gmx.at> <7a37c708-0ac1-3b06-9042-b4b2b6d6c5d6@gmx.at> <87v990r41n.fsf@md5i.com> <4ad20b14-f4a5-07c0-3f86-698d0934d5af@gmx.at> <58c0bfca-02e6-760f-dcff-05fdc4cca135@gmx.at> <870479cc-efd3-3a19-98a3-1d7a8b9346e8@gmx.at> <79cfe67d-3a2c-952d-7c51-20e8a4859380@gmx.at> <87czv6q1f8.fsf@md5i.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------CA01BB873C7F90B14D27E14E" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4361"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "schwab@linux-m68k.org" , "47244@debbugs.gnu.org" <47244@debbugs.gnu.org> To: Michael Welsh Duggan , Michael Welsh Duggan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 07 11:02:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lU44y-00010u-HU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Apr 2021 11:02:28 +0200 Original-Received: from localhost ([::1]:46368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU44x-00013l-Ga for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Apr 2021 05:02:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU43b-0008Pm-8J for bug-gnu-emacs@gnu.org; Wed, 07 Apr 2021 05:01:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59761) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lU43b-0006Pt-05 for bug-gnu-emacs@gnu.org; Wed, 07 Apr 2021 05:01:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lU43a-0001wi-VD for bug-gnu-emacs@gnu.org; Wed, 07 Apr 2021 05:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Apr 2021 09:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47244 X-GNU-PR-Package: emacs Original-Received: via spool by 47244-submit@debbugs.gnu.org id=B47244.16177860547452 (code B ref 47244); Wed, 07 Apr 2021 09:01:02 +0000 Original-Received: (at 47244) by debbugs.gnu.org; 7 Apr 2021 09:00:54 +0000 Original-Received: from localhost ([127.0.0.1]:43073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lU43R-0001w6-Cv for submit@debbugs.gnu.org; Wed, 07 Apr 2021 05:00:53 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:50193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lU43P-0001vl-Le for 47244@debbugs.gnu.org; Wed, 07 Apr 2021 05:00:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1617786039; bh=Dx/izhZLA9JY969ICa1TDV5RO2yPBsQsDnYO65SkQ9s=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=CIFCn62v9SNxP6FOJYM/OL8wPFjftuExGnMpoIycrQ66YPPDPEJrAlNQpwwEtA9bH Whd/oNuZrQD2OqEeQFd4Ht2FOS5lQ7v/JSyr5zsUh3/6rVZtajhn2Xn3KHTP/VKFsq dlvwwyxW8Wby0MqYfqrtD7erKQMKR0FUjRDRkXsE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.199]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N5VD8-1lfdoC3Zpi-016tcA; Wed, 07 Apr 2021 11:00:38 +0200 In-Reply-To: <87czv6q1f8.fsf@md5i.com> Content-Language: en-US X-Provags-ID: V03:K1:hgWZbbBCIBZwHTQEiMvr+P7VtFarRwZDNnQDcj3gGA7lxoyfDxx w7+2m1vxxToQ8m3CNKRbtTA9BM6jaja6MnZYFrCBfKWWayZqnYXMyKS3mmwpFyZSSwmvR9Z MkePt4Ccj5oGUpkZK8uhLc8KYqmbcrIW6h1I94pm5m82y7ejcXb+dN9Q3MAt3jRP3NuB5Sk qohdDDU9NyWPk1LGgVvlQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:L6TajokQr+c=:6ZampqC5ZYGwYENldq7Ggx hVzmgAI2E8U5Fy0UH5IxXKBoB3kHvwVnk3WSoxig6roKGKbo49W1naUsWDJXF9b1SKUaoshj4 OXT+UlOcnl0nrDD0EpIuElh2P4tt5jU3IT3GJ3gHmMOslT6PT4TwhD/o+kjd8tT/SSEV5pAJL Ixjg698QTXOyDb/wddQvwA/pkfFO3ee2w2Y7sxg0wY4tOqPbwKCr410t6BSbEMkUqjkJkQzLD hYTNczQdFYOTiar4yzASrzbj5jPeToJXlBMlP+jBlTjpv5Z59KAHZE3cbKhrQl3k4iej99cfZ pSy8VHAn5ivZ0xBnhjhXOc3Z6Gt5w6DN777/IDymxMXjXiZ7SdH1WML+U0P5v0bjnFgh6BJE4 /0V+N3Bxlflr2k3JM6iFjfQS6+t/9vIQ91QNXIXn1lq0yguKAjS8Nkfx/uri8MWKEco1/jRvL +U2yUdPETx5ZdV5RA/JNWjKQEHAIDuFvVbdxn3eedTlV096GOvq+o14HfKnn5ocgOUa1xvEea Sg1VLUkmsydG4tEkxGejR9fU4YQNqJRkdZKfedd314Yp6SViH186V6WZPKR0U7es00vkA9uAj m43blRvvuyeX8zTFvkuqm6nrMyUkAZoZdNP0Hg1Ki1hZCP9nAxCQlKMZAo6xjtmU06gwMITi8 liFvmxUzSCg7Vqn1xHYvaDL/jBCc62FE6efPE4Vq3L5w+7bh3wt2v6optRVaRKFBysOooZu1t ZXu+QDGVt6u+HkA+0Co2X+KPaDR2aSNSDmEN1hbfttfdR107sHqNdRhPDUPLvNqZ6BIQ5Lwx X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203671 Archived-At: This is a multi-part message in MIME format. --------------CA01BB873C7F90B14D27E14E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable > Just a shot in the dark here. The only way I can think of this > occurring (Vwindow_list being too small), is that something modified > Vwindow_list when we don't expect it to be modified. I looked through > all the uses of Vwindow_list and window_list(), and they all look > kosher. The only modification seems to be setting Vwindow_list to nil. > But window_list() does call into lisp (nconc2, which calls Fnconc) when > constructing Vwindow_list, and it uses Vwindow_list as a temporary in > the process. Is it possible that during that call something happens > asynchronously (via gc?) that calls something that sets Vwindow_list > to nil again, while Vwindow_list is being constructed? Improbable but I attached some code that could detect such an incidence. Put a breakpoint at the Vwindow_list =3D window_list_2; line. > I don't think > so, off hand, but I'm grasping at straws. I also added a variable called `window-list-lengths' which records the last 20 or so last changes in the number of windows seen by window_list. Maybe you can detect some strange 2 ~> 6 or 6 ~> 2 change while running Gnus. I'm still not sure whether your daemon setup could be involved somehow. martin --------------CA01BB873C7F90B14D27E14E Content-Type: text/x-patch; name="selected_window_contents.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="selected_window_contents.diff" diff --git a/src/buffer.c b/src/buffer.c index 8e33162989..70b37e61a2 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -1951,6 +1951,9 @@ DEFUN ("kill-buffer", Fkill_buffer, Skill_buffer, 0= , 1, "bKill buffer: ", This gets rid of them for certain. */ reset_buffer_local_variables (b, 1); =20 + if (!b->base_buffer) + eassert (b->window_count =3D=3D 0); + bset_name (b, Qnil); =20 block_input (); @@ -1991,6 +1994,8 @@ DEFUN ("kill-buffer", Fkill_buffer, Skill_buffer, 0= , 1, "bKill buffer: ", =20 run_buffer_list_update_hook (b); =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + return Qt; } =0C @@ -2151,6 +2156,9 @@ set_buffer_internal_1 (register struct buffer *b) =20 BUFFER_CHECK_INDIRECTION (b); =20 + if (!BUFFER_LIVE_P (b)) + error ("Selecting deleted buffer"); + old_buf =3D current_buffer; current_buffer =3D b; last_known_column_point =3D -1; /* Invalidate indentation cache. */= diff --git a/src/window.c b/src/window.c index eb16e2a433..16c75a13d5 100644 --- a/src/window.c +++ b/src/window.c @@ -307,7 +307,11 @@ wset_buffer (struct window *w, Lisp_Object val) if (BUFFERP (val)) /* Make sure that we do not assign the buffer to an internal window. */ - eassert (MARKERP (w->start) && MARKERP (w->pointm)); + { + eassert (BUFFER_LIVE_P (XBUFFER (val))); + eassert (MARKERP (w->start) && MARKERP (w->pointm)); + } + w->contents =3D val; adjust_window_count (w, 1); } @@ -315,6 +319,7 @@ wset_buffer (struct window *w, Lisp_Object val) static void wset_old_buffer (struct window *w, Lisp_Object val) { + eassert (BUFFER_LIVE_P (XBUFFER (val))); w->old_buffer =3D val; } =20 @@ -594,6 +599,8 @@ select_window_1 (Lisp_Object window, bool inhibit_poi= nt_swap) =20 selected_window =3D window; =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + /* Go to the point recorded in the window. This is important when the buffer is in more than one window. It also matters when @@ -2556,6 +2563,7 @@ window_list (void) if (!CONSP (Vwindow_list)) { Lisp_Object tail, frame; + Lisp_Object window_list_2 =3D Qnil; =20 Vwindow_list =3D Qnil; FOR_EACH_FRAME (tail, frame) @@ -2569,6 +2577,42 @@ window_list (void) arglist =3D Fnreverse (arglist); Vwindow_list =3D nconc2 (Vwindow_list, arglist); } + + if (NILP (window_list_lengths)) + window_list_lengths + =3D Fcons (make_fixnum (list_length (Vwindow_list)), Qnil); + else + { + int old_length =3D XFIXNUM (Fcar (window_list_lengths)); + int new_length =3D list_length (Vwindow_list); + + if (old_length !=3D new_length) + { + Lisp_Object twentieth; + + window_list_lengths + =3D Fcons (make_fixnum (new_length), window_list_lengths); + + /* Crop to 20 elements. */ + twentieth =3D Fnthcdr (make_fixnum (20), window_list_lengths); + + if (!NILP (twentieth)) + XSETCDR (twentieth, Qnil); + } + } + + FOR_EACH_FRAME (tail, frame) + { + Lisp_Object arglist =3D Qnil; + + foreach_window (XFRAME (frame), add_window_to_list, &arglist); + arglist =3D Fnreverse (arglist); + window_list_2 =3D nconc2 (window_list_2, arglist); + } + + if (NILP (Fequal (Vwindow_list, window_list_2))) + Vwindow_list =3D window_list_2; + } =20 return Vwindow_list; @@ -2950,6 +2994,8 @@ DEFUN ("window-list-1", Fwindow_list_1, Swindow_lis= t_1, 0, 3, 0, CHECK_ALL_WINDOWS /* Arg is ignored */ }; =20 +static int replace_buffer_in_windows_safely_count; + static Lisp_Object window_loop (enum window_loop type, Lisp_Object obj, bool mini, Lisp_Object frames) @@ -3048,6 +3094,8 @@ window_loop (enum window_loop type, Lisp_Object obj= , bool mini, if (EQ (window, selected_window) && XBUFFER (w->contents) =3D=3D current_buffer) Fset_buffer (w->contents); + + replace_buffer_in_windows_safely_count +=3D 1; } break; =20 @@ -3411,6 +3459,8 @@ DEFUN ("delete-other-windows-internal", Fdelete_oth= er_windows_internal, replace_buffer_in_windows (Lisp_Object buffer) { call1 (Qreplace_buffer_in_windows, buffer); + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* If BUFFER is shown in a window, safely replace it with some other @@ -3419,7 +3469,28 @@ replace_buffer_in_windows (Lisp_Object buffer) void replace_buffer_in_windows_safely (Lisp_Object buffer) { - if (buffer_window_count (XBUFFER (buffer))) + if (!NILP (Fstring_equal (XBUFFER (buffer)->name_, + build_string ("*Server*")))) + { + int count =3D buffer_window_count (XBUFFER (buffer)); + + replace_buffer_in_windows_safely_count =3D 0; + + + if (buffer_window_count (XBUFFER (buffer))) + { + Lisp_Object tail, frame; + + /* A single call to window_loop won't do the job because it only + considers frames on the current keyboard. So loop manually over + frames, and handle each one. */ + FOR_EACH_FRAME (tail, frame) + window_loop (REPLACE_BUFFER_IN_WINDOWS_SAFELY, buffer, true, frame)= ; + } + + eassert (count =3D=3D replace_buffer_in_windows_safely_count); + } + else if (buffer_window_count (XBUFFER (buffer))) { Lisp_Object tail, frame; =20 @@ -3429,6 +3500,7 @@ replace_buffer_in_windows_safely (Lisp_Object buffe= r) FOR_EACH_FRAME (tail, frame) window_loop (REPLACE_BUFFER_IN_WINDOWS_SAFELY, buffer, true, frame); } + } =0C /* The following three routines are needed for running a window's @@ -3960,6 +4032,8 @@ run_window_change_functions (void) /* Record changes for all frames (if asked for), selected window and frame. */ unbind_to (count, Qnil); + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* Make WINDOW display BUFFER. RUN_HOOKS_P means it's allowed @@ -4054,6 +4128,9 @@ set_window_buffer (Lisp_Object window, Lisp_Object = buffer, if (!samebuf && !MINI_WINDOW_P (w) && !WINDOW_PSEUDO_P (w)) FRAME_WINDOW_CHANGE (XFRAME (w->frame)) =3D true; =20 + if (WINDOWP (selected_window)) + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents= ))); + unbind_to (count, Qnil); } =20 @@ -5174,6 +5251,8 @@ DEFUN ("delete-window-internal", Fdelete_window_int= ernal, Sdelete_window_interna error ("Deletion failed"); } =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + return Qnil; } =0C @@ -7233,6 +7312,9 @@ DEFUN ("set-window-configuration", Fset_window_conf= iguration, minibuf_selected_window =3D data->minibuf_selected_window; =20 SAFE_FREE (); + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + return FRAME_LIVE_P (f) ? Qt : Qnil; } =20 @@ -8479,6 +8561,10 @@ syms_of_window (void) displayed after a scrolling operation to be somewhat inaccurate. */); fast_but_imprecise_scrolling =3D false; =20 + DEFVAR_LISP ("window-list-lengths", window_list_lengths, + doc: /* Last lengths of `window-list'. */); + window_list_lengths =3D Qnil; + defsubr (&Sselected_window); defsubr (&Sold_selected_window); defsubr (&Sminibuffer_window); diff --git a/src/xdisp.c b/src/xdisp.c index cc0a689ba3..ea64e5037a 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -12980,6 +12980,8 @@ restore_selected_window (Lisp_Object window) /* Abort if we cannot find a live frame. */ emacs_abort (); } + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* Restore WINDOW, if live, as its frame's selected window. */ @@ -12997,6 +12999,8 @@ restore_frame_selected_window (Lisp_Object window= ) if (EQ (frame, selected_frame)) selected_window =3D window; } + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); } =20 /* Update the tab-bar item list for frame F. This has to be done @@ -13074,6 +13078,8 @@ update_tab_bar (struct frame *f, bool save_match_= data) XSETFRAME (frame, f); selected_frame =3D frame; selected_window =3D FRAME_SELECTED_WINDOW (f); + + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents)= )); #endif =20 /* Build desired tab-bar items from keymaps. */ @@ -14010,6 +14016,8 @@ update_tool_bar (struct frame *f, bool save_match= _data) selected_frame =3D frame; selected_window =3D FRAME_SELECTED_WINDOW (f); =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents)= )); + /* Build desired tool-bar items from keymaps. */ new_tool_bar =3D tool_bar_items (Fcopy_sequence (f->tool_bar_items), @@ -17246,6 +17254,8 @@ run_window_scroll_functions (Lisp_Object window, = struct text_pos startp) set_buffer_internal (XBUFFER (w->contents)); } =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + return startp; } =20 @@ -25450,6 +25460,8 @@ display_mode_lines (struct window *w) =20 unbind_to (count, Qnil); =20 + eassert (BUFFER_LIVE_P (XBUFFER (XWINDOW (selected_window)->contents))= ); + if (n > 0) w->must_be_updated_p =3D true; return n; --------------CA01BB873C7F90B14D27E14E--