From: Yuan Fu <casouri@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: 66223@debbugs.gnu.org
Subject: bug#66223: treesit-major-mode-setup should not call font-lock-mode
Date: Wed, 27 Sep 2023 00:21:16 -0700 [thread overview]
Message-ID: <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> (raw)
In-Reply-To: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev>
> On Sep 26, 2023, at 5:17 PM, Dmitry Gutov <dmitry@gutov.dev> wrote:
>
> X-Debbugs-CC: Yuan Fu <casouri@gmail.com>
>
> It doesn't seem necessary (everything seems to work okay without that call), and it's not the right thing idiomatically (the user should have the ability to disable global-font-lock-mode).
>
> If it does get called, the call to treesit-font-lock-recompute-features should happen before that.
>
> The report was triggered by somewhat unusual circumstances (somebody trying out mmm-mode together with typescript-ts-mode: https://github.com/dgutov/mmm-mode/issues/138), but the fix seems easy and natural enough.
>
> To reproduce the bug, though, try this:
>
> (with-current-buffer (generate-new-buffer "foo")
> (let (font-lock-support-mode)
> (typescript-ts-mode)))
>
> It results in
>
> Debugger entered--Lisp error: (treesit-query-error "Node type error at" 2 "(jsx_opening_element [(nested_identifier (identifier)) (identifier)] @typescript-ts-jsx-tag-face) (jsx_closing_element [(nested_identifier (identifier)) (identifier)] @typescript-ts-jsx-tag-face) (jsx_self_closing_element [(nested_identifier (identifier)) (identifier)] @typescript-ts-jsx-tag-face) (jsx_attribute (property_identifier) @typescript-ts-jsx-attribute-face)" "Debug the query with `treesit-query-validate'")
> treesit-query-capture(#<treesit-node program in 1-1> #<treesit-compiled-query> 1 1)
> (let* ((delta-start ...
> treesit--font-lock-fontify-region-1(#<treesit-node program in 1-1> #<treesit-compiled-query> 1 1 nil nil)
> (let ((sub-node (car tail)))...
> treesit-font-lock-fontify-region(1 1 nil)
> font-lock-fontify-syntactically-region(1 1 nil)
> font-lock-default-fontify-region(1 1 nil)
> font-lock-fontify-region(1 1 nil)
> font-lock-default-fontify-buffer()
> font-lock-fontify-buffer()
> font-lock-initial-fontify()
> font-lock-mode(1)
> (progn (set (make-lo...
> treesit-major-mode-setup()
> typescript-ts-mode()
>
> because typescript-ts-mode's treesit-font-lock-settings hide the jsx rule (which the typescript grammar itself doesn't support, only the tsx one does) using the absence of that feature in treesit-font-lock-feature-list. But for that to take effect, the call to 'treesit-font-lock-recompute-features' needs to happen first. The jit-lock conceals the problem by inhibiting the first fontification until the major mode function has run and the buffer is visible. I ended up disabling it in mmm-mode's auxiliary temp buffer because it spams the message "Not enabling jit-lock: it does not work in indirect buffer”.
Makes sense. We can remove that line in master, and see if anything comes up. I don’t remember why I added it, I don’t think there was any particular reason.
Yuan
next prev parent reply other threads:[~2023-09-27 7:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 0:17 bug#66223: treesit-major-mode-setup should not call font-lock-mode Dmitry Gutov
2023-09-27 7:21 ` Yuan Fu [this message]
2023-09-27 8:51 ` Dmitry Gutov
2023-09-27 11:15 ` Stefan Kangas
2023-09-27 19:42 ` Dmitry Gutov
2023-09-28 0:23 ` Yuan Fu
2023-09-28 3:40 ` Eli Zaretskii
2023-09-28 4:55 ` Yuan Fu
2023-10-08 23:03 ` Yuan Fu
2023-10-08 23:05 ` Dmitry Gutov
2023-10-09 5:04 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23152919-A885-4B9A-8624-D5F079D576CF@gmail.com \
--to=casouri@gmail.com \
--cc=66223@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).