unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: martin rudalics <rudalics@gmx.at>, 28978@debbugs.gnu.org
Subject: bug#28978: 26.0; Regression: separate, dedicated `*Completions*' frame no longer has parameter `minibuffer'
Date: Wed, 25 Oct 2017 07:47:41 -0700 (PDT)	[thread overview]
Message-ID: <22c73180-e9a6-416f-9e28-da98d07908f8@default> (raw)
In-Reply-To: <59F0412F.9090206@gmx.at>

Thanks for looking into this.

>  > It should be the case in my context that this returns the minibuffer
>  > window: (cdr (assoc 'minibuffer (frame-parameters
>  >                                  (#<frame *Completions*
>  >                                   000000000cacf6c8>))))
>  >
>  > Instead, it now returns nil.  Parameter `minibuffer' for the
>  > `*Completions*' frame is no longer the minibuffer window; it is nil.
> 
> Since the 'minibuffer' parameter of a frame cannot be changed (from nil
> to some non-nil value and vice-versa at least) after its creation, 

Is that something new?

> your code somehow now seems to fail to set up that parameter.
> Please show the corresponding part where your code tries to
> set the parameter.  If necessary, debug it to show that after
> the corresponding ‘make-frame’ call the frame does not have
> that parameter set as requested.

I don't call `make-frame' to create frame `*Completions*'.
It is created when ` 1on1-display-*Completions*-frame' is
called, and that is done by `special-display-function'.
I showed the code for that in my previous message.

I don't ever set parameter `minibuffer' explicitly for
*Completions*.  I'm guessing that it has always gotten
set automatically when frame input was redirected from
frame *Completions* to the standalone minibuffer.

(It is redirected to `completion-reference-buffer' if
the minibuffer is not active (and if `c-r-b' is not
frame *Completions*)).

See previous message for that code.  The complete code is
here: https://www.emacswiki.org/emacs/download/oneonone.el

As I say, the code works in all Emacs releases.  It
does not work in this Emacs 26 prerelease (only).

Here is (some of) the code (from icicles-mcmd.el) that
relies on the parameter having being set:

(defun icicle-delete-windows-on (buffer)
  "Delete all windows showing BUFFER.
If such a window is alone in its frame, then delete the frame
- unless it is the only frame or a standalone minibuffer frame."
  (interactive
   (list (let ((enable-recursive-minibuffers  t))
           (read-buffer "Remove all windows showing buffer: "
                        (current-buffer)
                        'existing))))
  (setq buffer  (get-buffer buffer))
  (when buffer
    (let* ((this-buffer-frames  (icicle-frames-on buffer))
           (this-frame          (car this-buffer-frames))
           mini-param)
      (unless (and this-frame
                   (frame-visible-p this-frame)
                   (null (cdr this-buffer-frames))
                   (setq mini-param
                         (cdr
                          (assoc
                           'minibuffer ; <=================
                           (frame-parameters this-frame))))
                   (eq mini-param (active-minibuffer-window))
                   (save-window-excursion
                     (select-frame this-frame)
                     (one-window-p t 'SELECTED-FRAME-ONLY)))
        (let (win)
          (dolist (fr  this-buffer-frames)
            (setq win  (get-buffer-window buffer fr))
            (select-window win)
            (if (and (one-window-p t)
                     (cdr (visible-frame-list)))
                (delete-frame)
              (delete-window (selected-window)))))))))





  reply	other threads:[~2017-10-25 14:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 20:20 bug#28978: 26.0; Regression: separate, dedicated `*Completions*' frame no longer has parameter `minibuffer' Drew Adams
2017-10-25  7:45 ` martin rudalics
2017-10-25 14:47   ` Drew Adams [this message]
2017-10-26  7:57     ` martin rudalics
2017-10-26 14:01       ` Drew Adams
2017-10-27  8:25         ` martin rudalics
2017-10-27 14:19           ` Drew Adams
2017-10-28  8:45             ` martin rudalics
2017-10-28 19:15               ` Drew Adams
2017-10-29 11:18                 ` martin rudalics
2017-10-29 15:59                   ` Drew Adams
2017-10-29 18:13                     ` martin rudalics
2017-10-29 23:56                       ` Drew Adams
2017-10-30  8:24                         ` martin rudalics
2017-10-30 14:32                           ` Drew Adams
2017-10-30 19:00                             ` martin rudalics
2017-10-30 19:16                               ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22c73180-e9a6-416f-9e28-da98d07908f8@default \
    --to=drew.adams@oracle.com \
    --cc=28978@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).