From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#42708: Let users copy "*Char Help*" buffer Date: Tue, 13 Oct 2020 08:27:36 -0700 (PDT) Message-ID: <22b854e0-4fdd-4eac-86ec-6205b2e42a39@default> References: <87r1smy1du.5.fsf@jidanni.org> <877duerlw2.fsf@mail.linkov.net> <87h7the985.fsf@gnus.org> <87a6z8pr7f.fsf@mail.linkov.net> <87bljogscr.fsf@gnus.org> <87r1q27rvz.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14635"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42708@debbugs.gnu.org, rms@gnu.org, =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson To: Lars Ingebrigtsen , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 13 17:30:59 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSMGR-0003fL-E1 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Oct 2020 17:30:59 +0200 Original-Received: from localhost ([::1]:34368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSMGQ-0006HS-Cl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Oct 2020 11:30:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSMDa-0004l4-G2 for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 11:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSMDa-0001yD-6o for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 11:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSMDa-0000vg-3h for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 11:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Oct 2020 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 42708-submit@debbugs.gnu.org id=B42708.16026028713552 (code B ref 42708); Tue, 13 Oct 2020 15:28:02 +0000 Original-Received: (at 42708) by debbugs.gnu.org; 13 Oct 2020 15:27:51 +0000 Original-Received: from localhost ([127.0.0.1]:48277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSMDP-0000vE-DC for submit@debbugs.gnu.org; Tue, 13 Oct 2020 11:27:51 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:34556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSMDN-0000v0-9O for 42708@debbugs.gnu.org; Tue, 13 Oct 2020 11:27:50 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09DFMNnj078539; Tue, 13 Oct 2020 15:27:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=4AJvJnVVTFz8IPsLTWGinWiB875VII0KNBtbNZ12g6o=; b=tuyqMWkBGA3OW3C4JjqrlIqytyPn2klBRgSvICP8Pa7b1e8iD9DIrg5/+W4F3JL52dth shZR4jRHhSIktqWdZc4qV0AN2XyXX9212tNlFle0I5tdWyZ38pHbUBp1Q/UsO5qK9ttF xIyi+HYpLRwft5oV/TV+sJxbpoiX/LqKfWSD4JgzxrVbKlajVJy+FIKcUKYJ09ZbYuVm lVz7xnl9OeyjvuNbLxDs+I/VgskfR2xquA1attuorRMh9obIiSGhD0whb7w3FPxAirJZ 8knWz7cMrD1J81Xpzfq15G6Umu7b71R7fxM3j7EoYphz8+4br7bkRz4PipVIG6S1fzdi 7A== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 343vae9505-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 13 Oct 2020 15:27:43 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09DFAX33113102; Tue, 13 Oct 2020 15:27:43 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 343pvwhdut-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Oct 2020 15:27:42 +0000 Original-Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 09DFRbOY027616; Tue, 13 Oct 2020 15:27:37 GMT In-Reply-To: <87r1q27rvz.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9772 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010130112 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9772 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 clxscore=1011 impostorscore=0 phishscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010130112 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190424 Archived-At: > > Juri Linkov writes: > > > >> Oh, I noticed it doesn't support 'C-h' that should pop up the buffer " > >> *Char Help*" from the dynamic variable 'help-form'. > >> > >> Then maybe we should rewrite read-char-choice to use > >> read-char-from-minibuffer? > > > > Yes, that's even better -- then all the callers to read-char-choice > > would no longer be as modal as they are now. >=20 > I've now done this on the trunk. This is another step backward. If you want to use a read-a-character-using-minibuffer function here or there you should just it directly. `read-char-choice' should not have been co-opted to use the minibuffer. Big mistake in UI. There are good use cases for the classic `read-char' and `read-char-choice', which read an event WITHOUT involving the minibuffer. Using the minibuffer for everything is just wrong, very wrong. (And I'm saying this as someone who makes extensive use of the minibuffer.) Use a read-using-minibuffer function when it makes sense to do that. Not every (or even most - maybe not any?) uses of `read-char-choice' should involve the minibuffer. Those that should could of course be changed to use the minibuffer. Certainly not all. This has really become a have-hammer-see-only-nails phenomenon, IMHO.