unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 25895@debbugs.gnu.org
Subject: bug#25895: Remove update-game-score
Date: Sat, 11 Mar 2017 09:30:07 +0100	[thread overview]
Message-ID: <22723.46478.235358.161776@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <2d6ba53c-2e0e-9076-4d3e-c79db9243ff6@cs.ucla.edu>

>>>>> On Fri, 10 Mar 2017, Paul Eggert wrote:

> On second thought, how about if we install update-game-score only
> when the builder specifies the game user or group. This will let
> Gentoo roll along much as before, while simplifying installation for
> distributions that don't support or bother to configure a game user
> or group. Although this doesn't simplify the Emacs source as much as
> the previously proposed patch, it's still better than what we have
> now.

I like this idea much better than the first one.

> Proposed patch attached.

Tested and it doesn't work. With the --with-gameuser=":gamestat"
configure option, it properly installs the update-game-score binary.
In spite of this, Emacs doesn't use the shared directory, but creates
a score file in the user's home directory instead.

The reason is that gameuser and gamegroup are not propagated to the
top-level Makefile:

--- emacs/Makefile.in~
+++ emacs/Makefile.in
@@ -268,6 +268,8 @@
 
 # Where to install Emacs game score files.
 gamedir=@gamedir@
+gameuser=@gameuser@
+gamegroup=@gamegroup@
 
 # ==================== Utility Programs for the Build ====================
 





      parent reply	other threads:[~2017-03-11  8:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28  6:54 bug#25895: Remove update-game-score Glenn Morris
2017-03-09  8:50 ` Paul Eggert
2017-03-09 22:56   ` Glenn Morris
2017-03-10  6:42   ` Ulrich Mueller
2017-03-10  8:16     ` Paul Eggert
2017-03-10 22:40     ` Paul Eggert
2017-03-11  6:32       ` Eli Zaretskii
2017-03-12  8:45         ` Paul Eggert
2017-03-12 13:53           ` Ulrich Mueller
2017-03-12 15:14           ` Eli Zaretskii
2017-03-12 19:06             ` Paul Eggert
2017-03-11  8:30       ` Ulrich Mueller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22723.46478.235358.161776@a1i15.kph.uni-mainz.de \
    --to=ulm@gentoo.org \
    --cc=25895@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).