From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#50538: [PATCH v5] 28.0.50; electric-pair-mode fails to pair double quotes in some cases in CC mode Date: Sun, 3 Oct 2021 10:58:15 -0700 Message-ID: <226f9647-8932-5377-9a24-1edd160d32e4@gmail.com> References: <021853bf-0169-c158-ab3d-296b6c144e08@gmail.com> <83r1dufgxu.fsf@gnu.org> <94c7b4ec-813b-515f-d947-116c294dd74b@gmail.com> <456ed31d-77dc-cc2d-2fe9-8fcd379e04c6@gmail.com> <543ebfcc-d032-f0cd-f605-3f0607fe1df1@gmail.com> <36deabe8-9b2b-2c04-5d99-2c0a4b03abde@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------55BB4DAAC4D852E4E72CD576" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18197"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50538@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 03 19:59:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mX5ln-0004Zv-SW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Oct 2021 19:59:28 +0200 Original-Received: from localhost ([::1]:40446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mX5ll-0004MH-Hj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Oct 2021 13:59:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mX5lO-0004G7-TL for bug-gnu-emacs@gnu.org; Sun, 03 Oct 2021 13:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mX5lO-0004Fy-5M for bug-gnu-emacs@gnu.org; Sun, 03 Oct 2021 13:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mX5lO-0006Xw-35 for bug-gnu-emacs@gnu.org; Sun, 03 Oct 2021 13:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Oct 2021 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50538 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50538-submit@debbugs.gnu.org id=B50538.163328390425117 (code B ref 50538); Sun, 03 Oct 2021 17:59:02 +0000 Original-Received: (at 50538) by debbugs.gnu.org; 3 Oct 2021 17:58:24 +0000 Original-Received: from localhost ([127.0.0.1]:34896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mX5km-0006X3-Cz for submit@debbugs.gnu.org; Sun, 03 Oct 2021 13:58:24 -0400 Original-Received: from mail-pf1-f175.google.com ([209.85.210.175]:35831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mX5kj-0006Wp-O4 for 50538@debbugs.gnu.org; Sun, 03 Oct 2021 13:58:23 -0400 Original-Received: by mail-pf1-f175.google.com with SMTP id c29so2182181pfp.2 for <50538@debbugs.gnu.org>; Sun, 03 Oct 2021 10:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:cc:references:message-id:date:mime-version :in-reply-to:content-language; bh=wdQXWZ3Iej8dhvpkcJr3XZbujZOuuEYBYeUcx9cCpUw=; b=M2dEilGJay8cVJWiii97Je4CTHcH2rO9OU0QSRT/NRkpvHL8tsZ6xZYc5V9hKVLIwM uq6+hN3ObJflXA6dCDxWVoxKxcqfqcEPsLjUk1ujI00C2l1fODC8MQEjsRCiyGlBhXdm g8f2+XRO/nHkEadqK53qRFuK4Kl3kccOav3XVrvTyXFyauwYN0ZD+C2inQdgIBv5P2Sx 56wu/g9rf0HIHG55XLcV9BNHkwd5TybNnyaNkvuNsRe3JramYvsIb513kf7GM4a1ucvr UY3AQFlChwGFdVnY3wvamR6UBwVYrfWdXs0kJjagv3fmzD9fPqD+cBRpRnumbucnluXi XI2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :mime-version:in-reply-to:content-language; bh=wdQXWZ3Iej8dhvpkcJr3XZbujZOuuEYBYeUcx9cCpUw=; b=54bmGH1w+xdLQdaYr6Rvhl4KzpOTyIDxiq1cqWjBMjMtFRnxMZhihrpwj+S0+/VHiW ZCmiSppdWEsmPdw/vOHXe+lRWpXp4p5O5seriaPhNWhax9wlEfU4OYBTKdEU80Yd1z9J 1DNWJy2ZTd3obbuaoino+uzWLbp5rdOBaF2/MWhMJtPArE/dSzsjjv49owpM0XbAXw6D vm6QiOAc2i3Qiz2hBw82LgNGHKh7rm7cWg30yfmK4HmcOnTi0j31/80tKZSjpyGh038P 1UsBOLIYGdzar9U2Pyuw9AAoSt7b99rhipFhGda0eUB2Wkl2BHqYbbvhwGTOY62K56eA UKgg== X-Gm-Message-State: AOAM531SD+SWLEbAi8V85GYTXYl34gFz6R1s1WsvqKeh1t9AEv0Jv3KC X9/tSsy0oqimYZlz8s0HPrUcQbSjHRg= X-Google-Smtp-Source: ABdhPJw7VQLWuyUnwQ2n/AC964T9rIoZjqXLRpiyY1YXtHLCHk0AD2LFCdDqbDNjhKfMH4CtmJIVhA== X-Received: by 2002:a63:4d20:: with SMTP id a32mr7483823pgb.247.1633283895763; Sun, 03 Oct 2021 10:58:15 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id s3sm13521642pjr.1.2021.10.03.10.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Oct 2021 10:58:15 -0700 (PDT) In-Reply-To: <36deabe8-9b2b-2c04-5d99-2c0a4b03abde@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216292 Archived-At: This is a multi-part message in MIME format. --------------55BB4DAAC4D852E4E72CD576 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 9/27/2021 9:57 PM, Jim Porter wrote: > I don't have a strong opinion on this either way, so here's a patch that > uses an `if' form as you suggest. Oops, I was looking over this patch again and realized that I simply re-attached the old patch. Sorry about that. Here's the version that *really* uses the `if' form. Like I said in my previous message, I don't have a strong opinion on whether to use the `if' form or the `or' form; either works fine for me. --------------55BB4DAAC4D852E4E72CD576 Content-Type: text/plain; charset=UTF-8; name="0001-Improve-behavior-of-electric-pair-mode-in-cc-mode.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Improve-behavior-of-electric-pair-mode-in-cc-mode.patch" RnJvbSA5OWQyZTdlZmEwOGU5MDZhMjFiMDUxMjhlMDJlOGFkOTY3MjE5ZDBiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMyBPY3QgMjAyMSAxMDo0NjowMSAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIEltcHJvdmUgYmVoYXZpb3Igb2YgJ2VsZWN0cmljLXBhaXItbW9kZScgaW4gJ2NjLW1v ZGUnCgpUaGlzIGVuc3VyZXMgdGhhdCBxdW90ZXMgYXJlIHBhaXJlZCBjb3JyZWN0bHkgd2l0 aGluIGNvbW1lbnRzLCBhbGxvd3MgZm9yCmluc2VydGlvbiBvZiBxdW90ZSBwYWlycyBpbW1l ZGlhdGVseSBiZWZvcmUgYW5vdGhlciBxdW90ZSwgYW5kIGFsbG93cwppbnNlcnRpbmcgcXVv dGUgcGFpcnMgd2l0aGluIGEgc3RyaW5nICh0aHVzIHNwbGl0dGluZyB0aGUgc3RyaW5nIGlu IHR3bykuCgoqIGxpc3AvcHJvZ21vZGVzL2NjLW1vZGUuZWwgKGMtZWxlY3RyaWMtcGFpci1p bmhpYml0LXByZWRpY2F0ZSk6CkluaGliaXQgaW5zZXJ0aW9uIG9mIHBhaXJlZCBxdW90ZSBp biBmZXdlciBjYXNlcy4KKiB0ZXN0L2xpc3AvZWxlY3RyaWMtdGVzdHMuZWwgKGRlZmluZS1l bGVjdHJpYy1wYWlyLXRlc3QpOgpBZGQgJ2MtbW9kZScgdG8gbGlzdCBvZiBtb2RlcyB0byB0 ZXN0IGJ5IGRlZmF1bHQuCi0tLQogbGlzcC9wcm9nbW9kZXMvY2MtbW9kZS5lbCAgIHwgMTkg KysrKysrKysrKysrKy0tLS0tLQogdGVzdC9saXNwL2VsZWN0cmljLXRlc3RzLmVsIHwgIDUg KysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9jYy1tb2RlLmVsIGIvbGlzcC9wcm9n bW9kZXMvY2MtbW9kZS5lbAppbmRleCA4YjMwMjQxNDQ5Li4yZDdmYjczMWU2IDEwMDY0NAot LS0gYS9saXNwL3Byb2dtb2Rlcy9jYy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2Nj LW1vZGUuZWwKQEAgLTI1NDksMTcgKzI1NDksMjQgQEAgYy1lbGVjdHJpYy1wYWlyLWluaGli aXQtcHJlZGljYXRlCiAKIEF0IHRoZSB0aW1lIG9mIGNhbGwsIHBvaW50IGlzIGp1c3QgYWZ0 ZXIgdGhlIG5ld2x5IGluc2VydGVkIENIQVIuCiAKLVdoZW4gQ0hBUiBpcyBcIiwgdCB3aWxs IGJlIHJldHVybmVkIHVubGVzcyB0aGUgXCIgaXMgbWFya2VkIHdpdGgKLWEgc3RyaW5nIGZl bmNlIHN5bnRheC10YWJsZSB0ZXh0IHByb3BlcnR5LiAgRm9yIG90aGVyIGNoYXJhY3RlcnMs Ci10aGUgZGVmYXVsdCB2YWx1ZSBvZiBgZWxlY3RyaWMtcGFpci1pbmhpYml0LXByZWRpY2F0 ZScgaXMgY2FsbGVkCi1hbmQgaXRzIHZhbHVlIHJldHVybmVkLgorV2hlbiBDSEFSIGlzIFwi IGFuZCBub3Qgd2l0aGluIGEgY29tbWVudCwgdCB3aWxsIGJlIHJldHVybmVkIGlmCit0aGUg cXVvdGVzIG9uIHRoZSBjdXJyZW50IGxpbmUgYXJlIGFscmVhZHkgYmFsYW5jZWQgKGkuZS4g aWYgdGhlCitsYXN0IFwiIGlzIG5vdCBtYXJrZWQgd2l0aCBhIHN0cmluZyBmZW5jZSBzeW50 YXgtdGFibGUgdGV4dAorcHJvcGVydHkpLiAgRm9yIG90aGVyIGNhc2VzLCB0aGUgZGVmYXVs dCB2YWx1ZSBvZgorYGVsZWN0cmljLXBhaXItaW5oaWJpdC1wcmVkaWNhdGUnIGlzIGNhbGxl ZCBhbmQgaXRzIHZhbHVlCityZXR1cm5lZC4KIAogVGhpcyBmdW5jdGlvbiBpcyB0aGUgYXBw cm9wcmlhdGUgdmFsdWUgb2YKIGBlbGVjdHJpYy1wYWlyLWluaGliaXQtcHJlZGljYXRlJyBm b3IgQ0MgTW9kZSBtb2Rlcywgd2hpY2ggbWFyawogaW52YWxpZCBzdHJpbmdzIHdpdGggc3Vj aCBhIHN5bnRheCB0YWJsZSB0ZXh0IHByb3BlcnR5IG9uIHRoZQogb3BlbmluZyBcIiBhbmQg dGhlIG5leHQgdW5lc2NhcGVkIGVuZCBvZiBsaW5lLiIKLSAgKGlmIChlcSBjaGFyID9cIikK LSAgICAgIChub3QgKGVxdWFsIChnZXQtdGV4dC1wcm9wZXJ0eSAoMS0gKHBvaW50KSkgJ2Mt Zmwtc3luLXRhYikgJygxNSkpKQorICAoaWYgKGFuZCAoZXEgY2hhciA/XCIpCisJICAgKG5v dCAobWVtcSAoY2FkciAoYy1zZW1pLXBwLXRvLWxpdGVyYWwgKDEtIChwb2ludCkpKSkgJyhj IGMrKykpKSkKKyAgICAgIChsZXQgKChsYXN0LXF1b3RlIChzYXZlLW1hdGNoLWRhdGEKKwkJ CSAgKHNhdmUtZXhjdXJzaW9uCisJCQkgICAgKGdvdG8tY2hhciAoYy1wb2ludCAnZW9sbCkp CisJCQkgICAgKHNlYXJjaC1iYWNrd2FyZCAiXCIiKSkpKSkKKwkobm90IChlcXVhbCAoYy1n ZXQtY2hhci1wcm9wZXJ0eSBsYXN0LXF1b3RlICdjLWZsLXN5bi10YWIpICcoMTUpKSkpCiAg ICAgKGZ1bmNhbGwgKGRlZmF1bHQtdmFsdWUgJ2VsZWN0cmljLXBhaXItaW5oaWJpdC1wcmVk aWNhdGUpIGNoYXIpKSkKIAogDApkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VsZWN0cmljLXRl c3RzLmVsIGIvdGVzdC9saXNwL2VsZWN0cmljLXRlc3RzLmVsCmluZGV4IDRlN2NiZjU0MTku LjVlZWMwNThlZGUgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lbGVjdHJpYy10ZXN0cy5lbAor KysgYi90ZXN0L2xpc3AvZWxlY3RyaWMtdGVzdHMuZWwKQEAgLTMyLDYgKzMyLDkgQEAKIChy ZXF1aXJlICdlbGVjLXBhaXIpCiAocmVxdWlyZSAnY2wtbGliKQogCis7OyBXaGVuIHJ1bm5p bmcgdGVzdHMgaW4gYy1tb2RlLCB1c2Ugc2luZ2xlLWxpbmUgY29tbWVudHMgKC8vKS4KKyhh ZGQtaG9vayAnYy1tb2RlLWhvb2sgKGxhbWJkYSAoKSAoYy10b2dnbGUtY29tbWVudC1zdHls ZSAtMSkpKQorCiAoZGVmdW4gY2FsbC13aXRoLXNhdmVkLWVsZWN0cmljLW1vZGVzIChmbikK ICAgKGxldCAoKHNhdmVkLWVsZWN0cmljIChpZiBlbGVjdHJpYy1wYWlyLW1vZGUgMSAtMSkp CiAgICAgICAgIChzYXZlZC1sYXlvdXQgKGlmIGVsZWN0cmljLWxheW91dC1tb2RlIDEgLTEp KQpAQCAtMTc0LDcgKzE3Nyw3IEBAIGRlZmluZS1lbGVjdHJpYy1wYWlyLXRlc3QKICAgICAg ICAgICBleHBlY3RlZC1zdHJpbmcKICAgICAgICAgICBleHBlY3RlZC1wb2ludAogICAgICAg ICAgIGJpbmRpbmdzCi0gICAgICAgICAgKG1vZGVzICcocXVvdGUgKHJ1YnktbW9kZSBqcy1t b2RlIHB5dGhvbi1tb2RlKSkpCisgICAgICAgICAgKG1vZGVzICcocXVvdGUgKHJ1YnktbW9k ZSBqcy1tb2RlIHB5dGhvbi1tb2RlIGMtbW9kZSkpKQogICAgICAgICAgICh0ZXN0LWluLWNv bW1lbnRzIHQpCiAgICAgICAgICAgKHRlc3QtaW4tc3RyaW5ncyB0KQogICAgICAgICAgICh0 ZXN0LWluLWNvZGUgdCkKLS0gCjIuMjUuMQoK --------------55BB4DAAC4D852E4E72CD576--