From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#60210: 30.0.50; tab-bar height not recalculated when face changes Date: Sun, 01 Jan 2023 21:50:56 +0000 Message-ID: <226b32f79fbbaf16469b@heytings.org> References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> <226b32f79feedbfa05f1@heytings.org> <83o7ri2jy7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23384"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60210@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 01 22:51:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC6Eo-0005no-5f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Jan 2023 22:51:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC6EV-0007ZK-Pk; Sun, 01 Jan 2023 16:51:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC6ER-0007Z2-Js for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 16:51:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC6EQ-0006zd-84 for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 16:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC6EP-0002ky-LR for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 16:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jan 2023 21:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60210 X-GNU-PR-Package: emacs Original-Received: via spool by 60210-submit@debbugs.gnu.org id=B60210.167260986010587 (code B ref 60210); Sun, 01 Jan 2023 21:51:01 +0000 Original-Received: (at 60210) by debbugs.gnu.org; 1 Jan 2023 21:51:00 +0000 Original-Received: from localhost ([127.0.0.1]:41911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC6EO-0002kg-5F for submit@debbugs.gnu.org; Sun, 01 Jan 2023 16:51:00 -0500 Original-Received: from heytings.org ([95.142.160.155]:54992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC6EL-0002kW-U8 for 60210@debbugs.gnu.org; Sun, 01 Jan 2023 16:50:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672609856; bh=ZnWJJ6qWlLNYkQOATjsZ2QOwjo5px7wQFt7HbqWfMzs=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=EUSzkK92Pe0VPqkagXL8SIChQNMdtYLtuYBavSMul82Uq00L3PdJYMeF8rO6BNqO3 8yysRramOy29/smkrBwdTjzSJYZXT3u61E150A9bArmfTvCDuBu7JvJnffQxptMWju 4H1vPg6h/tVZdMg3Bc8gWqJ8nZ0AO/hKlGTaWYj9V8TBig634K/63VEio1F39lUXMs uALTv2J2wfi+N0MmknicAPdozdWWEQ9XdkSrdPVvNbNTIBbPHyFkXRLLXBHprMEJHe vSwlqiI/8Pnzu8E5+ll2EsBkRY2g7BeYNfBWc6kvoQEA5ZLgqWCTr0c+2DVUMuZ87c nnqQaF0WQoj/Q== In-Reply-To: <83o7ri2jy7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252290 Archived-At: >> The bug is that, in redisplay_tab_bar, WINDOW_PIXEL_HEIGHT (w) uses the >> height of the default face, which is 39 pixels, whereas new_height, >> which is computed with tab_bar_height, uses the font of the tab-bar >> face (variable-pitch in emacs -Q). On my system, new_height is (with a >> single *scratch* tab) 36 pixels. Therefore new_height < >> WINDOW_PIXEL_HEIGHT (w), when in fact according to the logic of the >> code we should have new_height == WINDOW_PIXEL_HEIGHT (w). > > I'm not sure I understand how the above causes the tab bar not to be > displayed, or become empty. AFAIU, it just means the frame's > change_tab_bar_height_hook will be called. What did I miss? > I do not fully understand it either yet. A simpler recipe, which does not involve changing fonts: (set-face-attribute 'tab-bar nil :height 0.5) (tab-bar-mode 1) This should display a tiny tab-bar, it displays a white bar instead. In redisplay_tab_bar, new_height is set to half the height of a canonical line (17 and 34 on my system). Therefore redisplay_tab_bar returns true. The next redisplay cycle finds that WINDOW_TOTAL_LINES (w) == 0, and does nothing.