From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil Date: Sun, 01 Jan 2023 18:56:30 +0000 Message-ID: <226b32f79f65b964c636@heytings.org> References: <87zgb5lx6y.fsf@oracle.com> <6c9d91cffcdbff97f034@heytings.org> <87lemot7ek.fsf@gmail.com> <0a62cbaeff1ee0497715@heytings.org> <226b32f79f7db2be1bbe@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32958"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Knut Anders Hatlen , 60411@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 01 19:57:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC3WH-0008LV-9r for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Jan 2023 19:57:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC3W7-0005jF-Lt; Sun, 01 Jan 2023 13:57:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC3W2-0005ik-Ta for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 13:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC3W2-0006la-LN for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 13:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC3W2-0006PC-Hn for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 13:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jan 2023 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60411 X-GNU-PR-Package: emacs Original-Received: via spool by 60411-submit@debbugs.gnu.org id=B60411.167259939424583 (code B ref 60411); Sun, 01 Jan 2023 18:57:02 +0000 Original-Received: (at 60411) by debbugs.gnu.org; 1 Jan 2023 18:56:34 +0000 Original-Received: from localhost ([127.0.0.1]:41770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC3Va-0006OR-0b for submit@debbugs.gnu.org; Sun, 01 Jan 2023 13:56:34 -0500 Original-Received: from heytings.org ([95.142.160.155]:54790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC3VY-0006OI-B5 for 60411@debbugs.gnu.org; Sun, 01 Jan 2023 13:56:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1672599391; bh=KEOaS8mAbLFGqGnZOG68o3L6thMRG3koiac3kqqhm/k=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=uEd+U81yUm0Yr7eNYXHEdJQN3P+vHRKoU/ecoif4fnkbnN7EMeiT44/gQbYkJATUE pbSw7iSIDKA7M7J09umj8VdsWC4Mjp4sejEiC3iAPibIYnKYU+5cvTsDQoAp1gXx5f cudyktI1X1t57i9Ga7ucXp5f/oVVKl/lxizKQqiLVXOSihEJyDQcJ9MwPmd3gz8JWq i2zzuqO0uZu9ZMxaH+YoXHeAoriP/KTyBIFcDc7nQlOSNWNMkj4NhTF9ExMOmnuR4b w4QRkoS7zgdj4O0wpsT3jwOZShvZxI9CPX7Sarm/ogkT9KgTyM23Q2uLy0INxvDWxQ xmWilN4c/aOQg== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252278 Archived-At: > > I think the crux of the matter is that the state in which we are at the > beginning (when creating the *Completions* buffer) is unclear/accidental > (is the first completion already selected or not?). > Exactly. > > (when completions-highlight-face > (setq-local cursor-face-highlight-nonselected-window t)) > > It's not clear to me how to "make this right", but maybe a "better ugly > hack" is to work with the above `setq-local`, i.e. if > `cursor-face-highlight-nonselected-window` is still nil (in which case, > the cursor-face hilighting should be currently off), consider that > `minibuffer-next-completion` should move to the *first* completion > rather than to the next. > I thought about that solution, but what if someone sets completion-highlight-face to nil? I also tried to add another buffer-local variable to distinguish the first and later calls to minibuffer-next-completion, but that didn't work in all cases either.