From: Christer Ekholm <che@chrekh.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 23864@debbugs.gnu.org, eggert@cs.ucla.edu
Subject: bug#23864: 25.1.50; Poor network responsivenes using open-network-stream
Date: Sun, 3 Jul 2016 20:54:39 +0200 [thread overview]
Message-ID: <22393.24431.818038.99105@ender.chrekh.se> (raw)
In-Reply-To: <83oa6erbli.fsf@gnu.org>
Eli Zaretskii writes:
>
> Isn't that strange? The commit made exactly the change you proposed,
> didn't it?
Apparently not. But it was not easy to spot the difference. In my
try the test was added before the "if (WAIT == timeout)".
>
> > I'll examine further and report back here if I figure something out.
I have tested some more now, and a simple change from "else if" to
just "if" does help.
diff --git a/src/process.c b/src/process.c
index 376e872..031967e 100644
--- a/src/process.c
+++ b/src/process.c
@@ -5275,7 +5275,7 @@ wait_reading_process_output (intmax_t time_limit, int nsecs, int read_kbd,
break;
else if (wait == TIMEOUT)
cmp_time = end_time, have_cmp_time = true;
- else if (!process_skipped && got_some_output > 0
+ if (!process_skipped && got_some_output > 0
&& (timeout.tv_sec > 0 || timeout.tv_nsec > 0))
{
if (!timespec_valid_p (got_output_end_time))
--
Christer
next prev parent reply other threads:[~2016-07-03 18:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 19:24 bug#23864: 25.1.50; Poor network responsivenes using open-network-stream Christer Ekholm
2016-06-30 1:50 ` Glenn Morris
2016-07-03 9:01 ` Paul Eggert
2016-07-03 11:21 ` Christer Ekholm
2016-07-03 15:21 ` Eli Zaretskii
2016-07-03 18:54 ` Christer Ekholm [this message]
2016-07-03 22:51 ` Paul Eggert
2016-07-04 7:34 ` Christer Ekholm
2016-07-04 14:35 ` Eli Zaretskii
2016-07-05 18:43 ` Paul Eggert
2016-07-05 19:46 ` Eli Zaretskii
2016-07-05 23:10 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22393.24431.818038.99105@ender.chrekh.se \
--to=che@chrekh.se \
--cc=23864@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).