From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#73133: 29.2; EWW fails to render some webpages Date: Sun, 13 Oct 2024 21:35:33 -0700 Message-ID: <220e88e6-cbd4-331f-f25a-abb906852f6b@gmail.com> References: <86plox4bef.fsf@gnu.org> <7eb7b048-06ea-5751-56e1-590689c8c318@gmail.com> <8e285069-6e95-de49-dd46-92ce49b94372@gmail.com> <5e49a521-a191-15db-6368-6ca0f046d68a@gmail.com> <87y12y7y2s.fsf@sebasmonia.com> <9d90789a-ef06-1f7d-c340-2bba315dda5f@gmail.com> <87ttdk90c1.fsf@sebasmonia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="764"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 73133@debbugs.gnu.org, ganimard@tuta.io To: =?UTF-8?Q?Sebasti=C3=A1n_?= =?UTF-8?Q?Mon=C3=ADa?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 14 06:38:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t0CqP-000Ado-QZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Oct 2024 06:38:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0Cq6-0007J9-P1; Mon, 14 Oct 2024 00:37:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0Cq3-0007IS-P8 for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2024 00:37:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0Cq2-00057q-FB for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2024 00:37:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=wL1gxMmRWh1QpoPxxyWi2Gv9Lcvv0k+3HRdL5Yzt380=; b=NR6w4Sa1l8VHZ/19IpIiX9wdwCAbf+I20EBtswU2YbzElEhlMhanZNuhnIalyw0CNzUkTso3mpEv4xnkt8+E34iI8GrcKRs+T4SPxpG1I/jQ8Q3JRloQ745+WiVbwatBb66m5Nz6uS9IloXAgzg7LjWO/46Y/znZjtotWq6nKeNIiJjfcpU7Esc7xxpqwjvEiE4a2xTgZsIfxIxBzb9s3yrxHvkl9Zxjb0eofCxVnTYipFahkOeY5TgO3h4Ewha5HrYlULT1G7uGtJ3hAAe4ByeIgXOjBcYgzpG1yBgEFuhUzLXgdmF8NuOWe6tIZ6RfdH+4WtnTRgEL117CtMX0Lg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t0CqI-0006Xb-5U for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2024 00:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Oct 2024 04:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73133 X-GNU-PR-Package: emacs Original-Received: via spool by 73133-submit@debbugs.gnu.org id=B73133.172888062124998 (code B ref 73133); Mon, 14 Oct 2024 04:38:02 +0000 Original-Received: (at 73133) by debbugs.gnu.org; 14 Oct 2024 04:37:01 +0000 Original-Received: from localhost ([127.0.0.1]:33898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0CpJ-0006V2-7X for submit@debbugs.gnu.org; Mon, 14 Oct 2024 00:37:01 -0400 Original-Received: from mail-pg1-f182.google.com ([209.85.215.182]:49425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0CpE-0006Uc-Rc for 73133@debbugs.gnu.org; Mon, 14 Oct 2024 00:36:59 -0400 Original-Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7ae3d7222d4so3241452a12.3 for <73133@debbugs.gnu.org>; Sun, 13 Oct 2024 21:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728880534; x=1729485334; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=wL1gxMmRWh1QpoPxxyWi2Gv9Lcvv0k+3HRdL5Yzt380=; b=Y3D9ufpqYDoKjcuwmdPdcWtMZilclDCVVcxwdEY8Zi45uxWua7pJaszkH5KBr0A+4Y eqzeSmGhD9b9ZKpLV4Iz31noYuurZkXS9lPHg2VvQLXmg1MfIq26/ffpK+mc/mnuMzpi nZ70r/niNr6HLCZkrls2ZM6ARIXmjZU82yPsu/3P0V7QOVBouwkhDMJxR4DO7kmT5SL0 pIp404pT6bHCOGE94gy2dzVLFVHM5tCgfYL+gc+9C9U5STeTnIsv5OEa1qwtBsip2Y9+ megZSTY2C88zDNZlx5nptcJiUWyStBcx0VT1UNbZc5MgyDzGWYgXRpvDSznQfs5hF224 GyAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728880534; x=1729485334; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wL1gxMmRWh1QpoPxxyWi2Gv9Lcvv0k+3HRdL5Yzt380=; b=bDy5/NGskeuf6YTk70ClKNwHCtjkOuLMvOtKBeXTMclZu7rMtqTg10NmaXXCj8XzX/ zywkHz/PGChOSquDiNeQQP1+rGqk4n8kH89p3/vJ5EoaCBDAVjZCB1y8yY39aCqrRkpO ZyKrnMmcS1p+CA9kAplHU40SIOrRichZutpkowOWVB9jTlezfNi0RiJXPv+5W1QdoeNM fj+sBTLv2h8oIQYInakliK6Yzx7SJsAj6eZdjbtP7ZErhvIyDJup9O+gglQalba6l2q0 3WJWnIJgdflsPrlLEnZVVNE8QXuj18KZ/3T4Pg3E0rhuh1Xru6mEHJZYz/krx+unmKFV i5JQ== X-Forwarded-Encrypted: i=1; AJvYcCUW9TmvuEW9AJu6qRxwgzdFN35hmey+LHKeUSRAUcvduehY+1YobLktcT8VmRlaMzFFoDfIhA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxQHIzlcJjuwBweOWADtvRhsNoU8vaK5fitSxRn49XQb6cDyep8 8UruIgaIYBrcVlHj30m7UKyGIfXdFazD0MLk3/SfcchxoBfmXZ9p X-Google-Smtp-Source: AGHT+IHxiE/oV+U6TMWlbunlPsGUFVaBbAxZV6xUIp7bqZE+5kcDA9e54qHno+3ia8ADLPdd0wktCA== X-Received: by 2002:a05:6a20:4c20:b0:1d8:d27f:476 with SMTP id adf61e73a8af0-1d8d27f07bfmr5874579637.2.1728880534169; Sun, 13 Oct 2024 21:35:34 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-71e5ab29b9fsm2250077b3a.22.2024.10.13.21.35.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Oct 2024 21:35:33 -0700 (PDT) Content-Language: en-US In-Reply-To: <87ttdk90c1.fsf@sebasmonia.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293562 Archived-At: On 10/9/2024 7:08 PM, Sebastián Monía wrote: > Attached a modified patch. I also noticed and corrected another error, > that broke things when using the "g" (reload) command. Thanks, I think this looks good overall. I just noticed one small nit (which I can fix when merging): > +(defun eww--html-if-doctype (headers response-buffer) > + "Return \"text/html\" if RESPONSE-BUFFER has an HTML doctype declaration. > +HEADERS is unused." If an argument is unused, the convention is to prefix it with an underscore like "_headers". Then Flymake won't complain about an unused variable. :) One last question: do you have FSF copyright assignment paperwork filled out? If you haven't already, you'll need to fill that out before we can merge this. (I don't think I have access to the full list of people who've filled out paperwork, so I'm not sure if you've already done this.)